[MCH] added plots as function of SOLAR links

The commit adds plots with quantities averaged over SOLAR links,
similar to the existing ones as function of Detection Elements.

It also adds comparisons of DE and SOLAR plots with reference ones,
using the code from AliceO2Group#2578

Author: aferrero2707

Modules/MUON/MCH/include/MCH/DecodingErrorsPlotter.h

@@ -53,10 +53,12 @@ class DecodingErrorsPlotter : public HistPlotter
 
   std::string mPath;
 
-  std::unique_ptr<TH1F> mHistogramGoodBoardsPerDE;  ///< fraction of boards with errors per DE
   std::unique_ptr<TH2F> mHistogramErrorsPerDE;      ///< error codes per DE
   std::unique_ptr<TH2F> mHistogramErrorsPerChamber; ///< error codes per chamber
   std::unique_ptr<TH2F> mHistogramErrorsPerFeeId;   ///< error codes per FEE ID
+
+  std::unique_ptr<TH1F> mHistogramGoodBoardsPerDE;    ///< fraction of boards without errors per DE
+  std::unique_ptr<TH1F> mHistogramGoodBoardsPerSolar; ///< fraction of boards with errors per DE
 };
 
 } // namespace muonchambers

Modules/MUON/MCH/include/MCH/DecodingPostProcessing.h

@@ -21,12 +21,12 @@
 
 #include "MCH/PostProcessingConfigMCH.h"
 #include "MCH/Helpers.h"
-#include "Common/TH2Ratio.h"
 #include "MCH/HistoOnCycle.h"
 #include "MCH/DecodingErrorsPlotter.h"
 #include "MCH/HeartBeatPacketsPlotter.h"
 #include "MCH/FECSyncStatusPlotter.h"
-#include "QualityControl/PostProcessingInterface.h"
+#include "Common/ReferenceComparatorTask.h"
+#include "Common/TH2Ratio.h"
 
 #include <memory>
 
@@ -43,7 +43,7 @@ namespace o2::quality_control_modules::muonchambers
 {
 
 /// \brief  A post-processing task which trends MCH hits and stores them in a TTree and produces plots.
-class DecodingPostProcessing : public PostProcessingInterface
+class DecodingPostProcessing : public ReferenceComparatorTask
 {
  public:
   DecodingPostProcessing() = default;
@@ -73,6 +73,8 @@ class DecodingPostProcessing : public PostProcessingInterface
   static std::string hbPacketsSourceName() { return "hbpackets"; }
   static std::string syncStatusSourceName() { return "syncstatus"; }
 
+  TH1* getHistogram(std::string plotName);
+
   bool mFullHistos{ false };
   bool mEnableLastCycleHistos{ false };
   bool mEnableTrending{ false };
@@ -96,7 +98,10 @@ class DecodingPostProcessing : public PostProcessingInterface
   std::unique_ptr<FECSyncStatusPlotter> mSyncStatusPlotter;
   std::unique_ptr<FECSyncStatusPlotter> mSyncStatusPlotterOnCycle;
 
-  std::unique_ptr<TH2F> mHistogramQualityPerDE; ///< quality flags for each DE, to be filled by checker task
+  std::unique_ptr<TH2F> mHistogramQualityPerDE;    ///< quality flags for each DE, to be filled by checker task
+  std::unique_ptr<TH2F> mHistogramQualityPerSolar; ///< quality flags for each SOLAR, to be filled by checker task
+
+  std::vector<TH1*> mHistogramsAll;
 };
 
 template <typename T>

Modules/MUON/MCH/include/MCH/DigitsPostProcessing.h

@@ -24,6 +24,7 @@
 #include "MCH/RatesPlotter.h"
 #include "MCH/RatesTrendsPlotter.h"
 #include "MCH/OrbitsPlotter.h"
+#include "Common/ReferenceComparatorTask.h"
 #include "Common/TH2Ratio.h"
 #include "QualityControl/PostProcessingInterface.h"
 
@@ -40,7 +41,7 @@ namespace o2::quality_control_modules::muonchambers
 {
 
 /// \brief  A post-processing task which processes and trends MCH digits and produces plots.
-class DigitsPostProcessing : public PostProcessingInterface
+class DigitsPostProcessing : public ReferenceComparatorTask
 {
  public:
   DigitsPostProcessing() = default;
@@ -62,6 +63,8 @@ class DigitsPostProcessing : public PostProcessingInterface
   static std::string orbitsSourceName() { return "orbits"; }
   static std::string orbitsSignalSourceName() { return "orbits_signal"; }
 
+  TH1* getHistogram(std::string plotName);
+
   bool mFullHistos{ false };
   bool mEnableLastCycleHistos{ false };
   bool mEnableTrending{ false };
@@ -99,7 +102,10 @@ class DigitsPostProcessing : public PostProcessingInterface
   std::unique_ptr<OrbitsPlotter> mOrbitsPlotterSignal;
   std::unique_ptr<OrbitsPlotter> mOrbitsPlotterSignalOnCycle;
 
-  std::unique_ptr<TH2F> mHistogramQualityPerDE; ///< quality flags for each DE, to be filled by checker task
+  std::unique_ptr<TH2F> mHistogramQualityPerDE;    ///< quality flags for each DE, to be filled by checker task
+  std::unique_ptr<TH2F> mHistogramQualityPerSolar; ///< quality flags for each SOLAR, to be filled by checker task
+
+  std::vector<TH1*> mHistogramsAll;
 };
 
 } // namespace o2::quality_control_modules::muonchambers

Modules/MUON/MCH/include/MCH/EfficiencyPlotter.h

@@ -69,6 +69,7 @@ class EfficiencyPlotter : public HistPlotter
   std::unique_ptr<TH2ElecMapReductor> mElecMapReductor;
 
   std::array<std::unique_ptr<TH1F>, 2> mHistogramMeanEfficiencyPerDE;
+  std::unique_ptr<TH1F> mHistogramMeanEfficiencyPerSolar;
 
   std::array<std::map<int, std::shared_ptr<DetectorHistogram>>, 2> mHistogramEfficiencyDE; // 2D hit rate map for each DE
   std::array<std::unique_ptr<GlobalHistogram>, 2> mHistogramEfficiencyGlobal;              // Efficiency histogram (global XY view)

Modules/MUON/MCH/include/MCH/FECSyncStatusPlotter.h

@@ -49,11 +49,11 @@ class FECSyncStatusPlotter : public HistPlotter
     histograms().emplace_back(HistInfo{ h, drawOptions, displayHints });
   }
 
-  o2::mch::raw::Elec2DetMapper mElec2DetMapper;
-  o2::mch::raw::FeeLink2SolarMapper mFeeLink2SolarMapper;
+  o2::mch::raw::Det2ElecMapper mDet2ElecMapper;
 
   std::unique_ptr<TH1F> mGoodBoardsFractionPerDE; ///< fraction of out-of-sync DS boards per detection element
-  std::unique_ptr<TH1F> mGoodTFFractionPerDE;     ///< fraction of out-of-sync DS boards per chamber
+  std::unique_ptr<TH1F> mGoodTFFractionPerDE;     ///< fraction of in-sync TFs per DS boards, averaged on detection elements
+  std::unique_ptr<TH1F> mGoodTFFractionPerSolar;  ///< fraction of in-sync TFs per DS boards, averaged on SOLAR boards
 };
 
 } // namespace muonchambers

Modules/MUON/MCH/include/MCH/PreclustersPostProcessing.h

@@ -19,18 +19,17 @@
 #ifndef QC_MODULE_MCH_PP_PRECLUSTERS_H
 #define QC_MODULE_MCH_PP_PRECLUSTERS_H
 
-#include "QualityControl/PostProcessingInterface.h"
-
 #include "MCH/PostProcessingConfigMCH.h"
 #include "MCH/Helpers.h"
-#include "Common/TH2Ratio.h"
 #include "MCH/HistoOnCycle.h"
 #include "MCH/EfficiencyPlotter.h"
 #include "MCH/EfficiencyTrendsPlotter.h"
 #include "MCH/ClusterSizePlotter.h"
 #include "MCH/ClusterSizeTrendsPlotter.h"
 #include "MCH/ClusterChargePlotter.h"
 #include "MCH/ClusterChargeTrendsPlotter.h"
+#include "Common/ReferenceComparatorTask.h"
+#include "Common/TH2Ratio.h"
 
 namespace o2::quality_control::repository
 {
@@ -45,7 +44,7 @@ namespace o2::quality_control_modules::muonchambers
 {
 
 /// \brief  A post-processing task which processes and trends MCH pre-clusters and produces plots.
-class PreclustersPostProcessing : public PostProcessingInterface
+class PreclustersPostProcessing : public ReferenceComparatorTask
 {
  public:
   PreclustersPostProcessing() = default;
@@ -73,6 +72,8 @@ class PreclustersPostProcessing : public PostProcessingInterface
   static std::string clusterChargeSourceName() { return "clcharge"; }
   static std::string clusterSizeSourceName() { return "clsize"; }
 
+  TH1* getHistogram(std::string plotName);
+
   bool mFullHistos{ false };
   bool mEnableLastCycleHistos{ false };
   bool mEnableTrending{ false };
@@ -102,7 +103,10 @@ class PreclustersPostProcessing : public PostProcessingInterface
   std::unique_ptr<ClusterChargeTrendsPlotter> mClusterChargeTrendsPlotter;
   std::unique_ptr<ClusterSizeTrendsPlotter> mClusterSizeTrendsPlotter;
 
-  std::unique_ptr<TH2F> mHistogramQualityPerDE; ///< quality flags for each DE, to be filled by checker task
+  std::unique_ptr<TH2F> mHistogramQualityPerDE;    ///< quality flags for each DE, to be filled by checker task
+  std::unique_ptr<TH2F> mHistogramQualityPerSolar; ///< quality flags for each SOLAR, to be filled by checker task
+
+  std::vector<TH1*> mHistogramsAll;
 };
 
 template <typename T>

Modules/MUON/MCH/include/MCH/RatesPlotter.h

@@ -69,8 +69,10 @@ class RatesPlotter : public HistPlotter
   std::unique_ptr<TH2F> mHistogramRatePerStation;
 
   std::unique_ptr<TH1F> mHistogramMeanRatePerDE;
+  std::unique_ptr<TH1F> mHistogramMeanRatePerSolar;
 
   std::unique_ptr<TH1F> mHistogramGoodChannelsFractionPerDE;
+  std::unique_ptr<TH1F> mHistogramGoodChannelsFractionPerSolar;
 
   std::map<int, std::shared_ptr<DetectorHistogram>> mHistogramRateDE[2]; // 2D hit rate map for each DE
   std::shared_ptr<GlobalHistogram> mHistogramRateGlobal[2];              // Rate histogram (global XY view)

Modules/MUON/MCH/src/DecodingErrorsPlotter.cxx

@@ -60,8 +60,14 @@ DecodingErrorsPlotter::DecodingErrorsPlotter(std::string path) : mPath(path)
   // Number of decoding errors, grouped by FEE ID and normalized to the number of processed TF
   mHistogramGoodBoardsPerDE = std::make_unique<TH1F>(TString::Format("%sGoodBoardsFractionPerDE", path.c_str()),
                                                      "Fraction of boards not in error", getNumDE(), 0, getNumDE());
+  addDEBinLabels(mHistogramGoodBoardsPerDE.get());
   addHisto(mHistogramGoodBoardsPerDE.get(), false, "", "");
 
+  mHistogramGoodBoardsPerSolar = std::make_unique<TH1F>(TString::Format("%sGoodBoardsFractionPerSolar", path.c_str()),
+                                                        "Fraction of boards not in error per SOLAR board", getNumSolar(), 0, getNumSolar());
+  addSolarBinLabels(mHistogramGoodBoardsPerSolar.get());
+  addHisto(mHistogramGoodBoardsPerSolar.get(), false, "", "");
+
   //--------------------------------------------
   // Decoding errors per chamber, DE and FEEID
   //--------------------------------------------
@@ -122,7 +128,8 @@ void DecodingErrorsPlotter::update(TH2F* h)
   mHistogramErrorsPerDE->Reset("ICES");
   mHistogramErrorsPerChamber->Reset("ICES");
 
-  std::array<std::pair<float, float>, getNumDE()> goodBoardsFraction;
+  std::array<std::pair<float, float>, getNumDE()> goodBoardsFractionPerDE;
+  std::array<std::pair<float, float>, getNumSolar()> goodBoardsFractionPerSolar;
 
   // loop over bins in electronics coordinates, and map the channels to the corresponding cathode pads
   int nbinsx = h->GetXaxis()->GetNbins();
@@ -144,16 +151,21 @@ void DecodingErrorsPlotter::update(TH2F* h)
     // where one bin is one physical pad
     // get the unique solar ID and the DS address associated to this digit
     int feeId = -1;
+    int solarId = -1;
     std::optional<DsElecId> dsElecId = mDet2ElecMapper(dsDetId);
     if (dsElecId) {
-      uint32_t solarId = dsElecId->solarId();
+      solarId = dsElecId->solarId();
       uint32_t dsAddr = dsElecId->elinkId();
 
       std::optional<FeeLinkId> feeLinkId = mSolar2FeeLinkMapper(solarId);
       if (feeLinkId) {
         feeId = feeLinkId->feeId();
       }
     }
+    int solarIndex = (solarId >= 0) ? getSolarIndex(solarId) : -1;
+    if (solarIndex < 0) {
+      continue;
+    }
 
     bool hasError = false;
 
@@ -171,21 +183,33 @@ void DecodingErrorsPlotter::update(TH2F* h)
       incrementBin(mHistogramErrorsPerChamber.get(), chamber, j, count);
     }
 
-    goodBoardsFraction[deIndex].first += 1;
+    goodBoardsFractionPerDE[deIndex].first += 1;
+    goodBoardsFractionPerSolar[solarIndex].first += 1;
     if (!hasError) {
-      goodBoardsFraction[deIndex].second += 1;
+      goodBoardsFractionPerDE[deIndex].second += 1;
+      goodBoardsFractionPerSolar[solarIndex].second += 1;
     }
   }
 
   // update fraction of good boards per DE
   for (int i = 0; i < getNumDE(); i++) {
-    if (goodBoardsFraction[i].first > 0) {
-      float frac = goodBoardsFraction[i].second / goodBoardsFraction[i].first;
+    if (goodBoardsFractionPerDE[i].first > 0) {
+      float frac = goodBoardsFractionPerDE[i].second / goodBoardsFractionPerDE[i].first;
       mHistogramGoodBoardsPerDE->SetBinContent(i + 1, frac);
     } else {
       mHistogramGoodBoardsPerDE->SetBinContent(i + 1, 0);
     }
   }
+
+  // update fraction of good boards per Solar
+  for (int i = 0; i < getNumSolar(); i++) {
+    if (goodBoardsFractionPerSolar[i].first > 0) {
+      float frac = goodBoardsFractionPerSolar[i].second / goodBoardsFractionPerSolar[i].first;
+      mHistogramGoodBoardsPerSolar->SetBinContent(i + 1, frac);
+    } else {
+      mHistogramGoodBoardsPerSolar->SetBinContent(i + 1, 0);
+    }
+  }
 }
 
 } // namespace muonchambers