Skip to content

Report error when variable has no units and neither standard_name nor long_name #55

Description

@atmodatcode

Request for enhancement:
When performing run_checks.py on a file with no variable attributes, there is no error report that this is not ATMODAT Standard compliant.
The CF Checker writes out a warning, but no error.
It is important to report missing variable units and either long_name or standard_name as an error.

e.g.
(atmodat) angelika ~/Checker/demo_data: run_checks.py -s -f NOATTRIBUTES.nc -op checkoutput
Running Compliance Checker on the datasets from: ['NOATTRIBUTES.nc']
2021-09-03 07:40:27.459085 [INFO] :: PYESSV :: Loading vocabularies from /Users/angelika/Checker/atmodat_data_checker/AtMoDat_CVs/pyessv-archive:
2021-09-03 07:40:27.466281 [INFO] :: PYESSV :: ... loaded: atmodat
--- 4.3694 seconds for checking 1 files---
(atmodat) angelika ~/Checker/demo_data: more checkoutput/short_summary.txt
Short summary of checks:

Checking against: atmodat_standard:3.0, CF table version: 77
Version of the AtMoDat checker: 1.1.0
Checked at: 2021-09-03T09:40:31.270952

Number of checked files: 1
Total checks passed: 0/29
Mandatory checks passed: 0/2
Recommended checks passed: 0/18
Optional checks passed: 0/9
CF checker errors: 0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions