ci(release): verify shrinkwrap installs on node 20 before publish - #9555
Draft
pranavjain97 wants to merge 1 commit into
Draft
ci(release): verify shrinkwrap installs on node 20 before publish#9555pranavjain97 wants to merge 1 commit into
pranavjain97 wants to merge 1 commit into
Conversation
…bitgo Adds a pre-publish gate between the siblings publish (pass 1) and the bitgo publish (pass 2): npm pack triggers the shrinkwrap generator via prepack, then we install the resulting tarball on Node 20 with engine-strict=true. Any transitive pinned by the shrinkwrap that violates engines (like sanitize-html@2.17.6 in WCN-2091) fails the release before the bad bitgo tarball reaches npm. Runs after pass 1 because the generator resolves newly-published siblings from the registry. If it fails, siblings are on npm but bitgo isn't -- fix and re-run in recovery-mode. Skipped in dry-run since siblings aren't published there. TICKET: WCN-2098
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pre-publish gate between the siblings publish (pass 1) and the bitgo publish (pass 2): npm pack triggers the shrinkwrap generator via prepack, then we install the resulting tarball on Node 20 with engine-strict=true. Any transitive pinned by the shrinkwrap that violates engines (like sanitize-html@2.17.6 in WCN-2091) fails the release before the bad bitgo tarball reaches npm.
Runs after pass 1 because the generator resolves newly-published siblings from the registry. If it fails, siblings are on npm but bitgo isn't -- fix and re-run in recovery-mode.
Skipped in dry-run since siblings aren't published there.
TICKET: WCN-2098