You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary
Fixes client-v1 transactions against recent ClickHouse HEAD, where the transaction ID tuple grew a fourth element (sessionNodeVersion Int64). ClickHouseTransaction.XID.of() now accepts 3- or 4-element tuples, numeric parsing is loosened from a hard UnsignedLong cast to any Number (avoiding ClassCastException), and the new optional field is threaded through asTupleString(), equals/hashCode, and toString. A new unit test class covers parsing, empty/invalid tuples, and equality. Separately, the test_head.yml workflow drops R2DBC 0.9.1 from the matrix (keeping 1.0.0) and adds workflow_dispatch, and one jdbc-v2 test drops an explicit ENGINE = MergeTree clause to work on cluster test setups.
What this impacts
clickhouse-client (v1) transaction handling — public XID class gains a field, constructor, and getSessionNodeVersion() accessor; of() contract widened to 4-element tuples
.github/workflows/test_head.yml — R2DBC 0.9.1 removed from the CH-HEAD test matrix
jdbc-v2 test only (JdbcDataTypeTests), no jdbc-v2 source change
Concerns
Medium rules fired: GitHub workflow change, and test-infra scope reduction — R2DBC 0.9.1 is dropped from the test_head matrix with no replacement coverage (reviewer should confirm 0.9.x support is intentionally no longer tested against CH HEAD)
Public API surface of XID changes (new optional tuple element in asTupleString(), equality semantics now include sessionNodeVersion); kept at medium rather than high because the change is additive, backward-compatible for 3-element tuples, and covered by new unit tests — but XID is Serializable with an unchanged serialVersionUID, worth a glance
Three loosely related strands bundled (v1 tx fix, workflow matrix trim, jdbc-v2 test fix) and no linked issue for a non-trivial behavior change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR: