Fix SQS queue attribute names in tests

- Change VisibilityTimeoutSeconds to VisibilityTimeout
- Applies to both CreateStandardQueueAsync and CreateFifoQueueAsync
- Fixes InvalidAttributeNameException in LocalStack tests

Author: NinjaRocks

docs/Cloud-Integration-Testing.md

@@ -696,26 +696,39 @@ services:
 
 **AWS Credential Configuration:**
 
-The test infrastructure automatically sources AWS credentials from environment variables when available, falling back to default test credentials:
+The test infrastructure uses `BasicAWSCredentials` with dummy values for LocalStack testing. This approach provides better compatibility with AWS SDK endpoint resolution compared to `AnonymousAWSCredentials`.
 
 ```csharp
-// AwsTestConfiguration.cs
-public string AccessKey { get; set; } = 
-    Environment.GetEnvironmentVariable("AWS_ACCESS_KEY_ID") ?? "test";
+// LocalStackTestFixture.cs
+// Use BasicAWSCredentials with dummy values for LocalStack
+// AnonymousAWSCredentials can cause issues with endpoint resolution
+var credentials = new Amazon.Runtime.BasicAWSCredentials("test", "test");
 
-public string SecretKey { get; set; } = 
-    Environment.GetEnvironmentVariable("AWS_SECRET_ACCESS_KEY") ?? "test";
+var config = new Amazon.SQS.AmazonSQSConfig
+{
+    ServiceURL = LocalStackEndpoint,
+    UseHttp = true,
+    // Don't set RegionEndpoint when using ServiceURL - it can override the endpoint
+    AuthenticationRegion = _configuration.Region.SystemName,
+    // Force the use of the custom endpoint
+    ForcePathStyle = true
+};
 ```
 
-**Credential Resolution Order:**
-1. **Environment Variables** - `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` (preferred for CI/CD)
-2. **Default Test Credentials** - Falls back to "test"/"test" for local development
+**Credential Configuration Details:**
+- **BasicAWSCredentials** - Uses dummy "test"/"test" credentials for LocalStack
+- **ServiceURL** - Explicitly set to LocalStack endpoint (http://localhost:4566)
+- **UseHttp** - Enables HTTP instead of HTTPS for LocalStack
+- **AuthenticationRegion** - Set to match configured region (us-east-1)
+- **ForcePathStyle** - Forces path-style URLs for better LocalStack compatibility
+- **No RegionEndpoint** - Omitted when using ServiceURL to prevent endpoint override
 
 **Benefits:**
-- **CI/CD Integration** - Seamlessly uses credentials configured in GitHub Actions workflow
-- **Local Development** - Works out-of-the-box with default "test" credentials for LocalStack
-- **Flexibility** - Supports custom credentials via environment variables without code changes
-- **Security** - Credentials can be managed through CI/CD secrets instead of hardcoded values
+- **Endpoint Compatibility** - BasicAWSCredentials works reliably with custom ServiceURL
+- **LocalStack Support** - Dummy credentials accepted by LocalStack without validation
+- **Consistent Behavior** - Same credential approach across all AWS service clients (SQS, SNS, KMS)
+- **CI/CD Integration** - Works seamlessly in GitHub Actions with LocalStack service containers
+- **Local Development** - No configuration needed for LocalStack testing
 
 **LocalStack Security Configuration:**
 - **`ENFORCE_IAM: 0`** - Disables IAM policy enforcement for simplified testing with dummy credentials

docs/SourceFlow.Cloud.AWS-README.md

@@ -799,12 +799,12 @@ services.UseSourceFlowAws(
 # LocalStack endpoints
 export AWS_ENDPOINT_URL=http://localhost:4566
 
-# No credentials needed - LocalStack accepts anonymous credentials
-# AWS SDK will use AnonymousAWSCredentials automatically
+# LocalStack uses hardcoded test credentials in test fixtures
+# BasicAWSCredentials("test", "test") provides better endpoint compatibility
 export AWS_DEFAULT_REGION=us-east-1
 ```
 
-**Note**: LocalStack does not validate AWS credentials. The AWS SDK can use `AnonymousAWSCredentials` to bypass credential validation, eliminating the need for dummy access keys.
+**Note**: LocalStack does not validate AWS credentials. The test infrastructure uses `BasicAWSCredentials` with dummy "test"/"test" values for better compatibility with AWS SDK endpoint resolution. This approach avoids endpoint override issues that can occur with `AnonymousAWSCredentials`.
 
 #### Testing
 

tests/SourceFlow.Cloud.AWS.Tests/Integration/AwsDeadLetterQueueProcessingTests.cs

@@ -56,7 +56,7 @@ public async Task DeadLetterProcessing_ShouldCaptureCompleteMetadata()
 
         var mainQueueUrl = await CreateStandardQueueAsync(mainQueueName, new Dictionary<string, string>
         {
-            ["VisibilityTimeoutSeconds"] = "2",
+            ["VisibilityTimeout"] = "2",
             ["RedrivePolicy"] = JsonSerializer.Serialize(new
             {
                 deadLetterTargetArn = dlqArn,
@@ -1374,7 +1374,7 @@ private async Task<string> CreateStandardQueueAsync(string queueName, Dictionary
         var attributes = new Dictionary<string, string>
         {
             ["MessageRetentionPeriod"] = "1209600",
-            ["VisibilityTimeoutSeconds"] = "30"
+            ["VisibilityTimeout"] = "30"
         };
 
         if (additionalAttributes != null)
@@ -1402,7 +1402,7 @@ private async Task<string> CreateFifoQueueAsync(string queueName, Dictionary<str
             ["FifoQueue"] = "true",
             ["ContentBasedDeduplication"] = "true",
             ["MessageRetentionPeriod"] = "1209600",
-            ["VisibilityTimeoutSeconds"] = "30"
+            ["VisibilityTimeout"] = "30"
         };
 
         if (additionalAttributes != null)

tests/SourceFlow.Cloud.AWS.Tests/TestHelpers/LocalStackTestFixture.cs

@@ -152,9 +152,7 @@ public async Task InitializeAsync()
             ServiceURL = LocalStackEndpoint,
             UseHttp = true,
             // Don't set RegionEndpoint when using ServiceURL - it can override the endpoint
-            AuthenticationRegion = _configuration.Region.SystemName,
-            // Force the use of the custom endpoint
-            ForcePathStyle = true
+            AuthenticationRegion = _configuration.Region.SystemName
         };
 
         SqsClient = new AmazonSQSClient(credentials, config);