NW | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | improve with precomputing #178
Open
ZabihollahNamazi wants to merge 2 commits into
Open
NW | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | improve with precomputing #178ZabihollahNamazi wants to merge 2 commits into
ZabihollahNamazi wants to merge 2 commits into
Conversation
ZabihollahNamazi
added
📅 Sprint 2
cjyuan
reviewed
Jun 26, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good.
Could you use complexity to explain how the new implementation is better than the original implementation?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Could you please check my code?
The old code used slow loops and would freeze with big data. I fixed them by using sorting and sets so they now run instantly and easily handle millions of characters.All tests are passing perfectly. Thank you!