Glasgow | Jan-26-ITP | Fattouma Ouannassi | Sprint 3 | coursework/sprint-3-practice-tdd#1094
Open
FAprogrammerO wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Conversation
FAprogrammerO
added
the
Needs Review
FAprogrammerO
force-pushed
the
coursework/sprint-3practice-tdd
branch
from
b53bdab to
eac7d73
Compare
kyle-tightest
suggested changes
Mar 12, 2026
kyle-tightest
left a comment
kyle-tightest
left a comment
There was a problem hiding this comment.
get-ordinal-number and repeat-str.js look good! its just count.js that has some issues
Comment on lines
+1
to
+7
| // function countChar(stringOfCharacters, findCharacter) { | ||
| // let count = 0; | ||
| // for (let i = 0; i < stringOfCharacters.length; i++) { | ||
| // if (stringOfCharacters[i] === findCharacter) { | ||
| // count++; | ||
| // } | ||
| // } |
There was a problem hiding this comment.
The ITP assignment does need countChar method to be implemented so that the tests, which call countChar will pass
Comment on lines
+12
to
+19
| let numbers=[1,2,3,4,5,6,1,2,3,4,5,6] | ||
| let idxArray=[]; | ||
| numbers.find((el,ix,numbers)=>{ | ||
| if (el===3){ | ||
|
|
||
| idxArray.push(ix);} | ||
| }) | ||
| console.log(idxArray); |
There was a problem hiding this comment.
this piece of code does not seem to be related to the assignment.
please let me know if i can help you understand the problem better
or perhaps this was an accident?
kyle-tightest
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This project (sprint 3) focuses on learning how to use JavaScript methods and npm test the code.
Questions
N/A