London|ITP-Jan-2026|Ping Wang|Sprint 3|1-implement-and -rewrite -tests#1103
Open
pathywang wants to merge 10 commits intoCodeYourFuture:mainfrom
Open
London|ITP-Jan-2026|Ping Wang|Sprint 3|1-implement-and -rewrite -tests#1103pathywang wants to merge 10 commits intoCodeYourFuture:mainfrom
pathywang wants to merge 10 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
pathywang
changed the title
pathywang
added
the
Needs Review
Lindronics
reviewed
Mar 7, 2026
Lindronics
left a comment
Lindronics
left a comment
There was a problem hiding this comment.
Overall looks great! I would add a few more assertions here and there to test for edge cases!
| const right = getAngleType(90); | ||
| assertEquals(right, "Right angle"); | ||
|
|
||
| // Case 2: Identify Acute Angles: |
There was a problem hiding this comment.
Can you think of a couple more edge cases that could happen here? Try to think of boundaries and possible invalid values.
| assertEquals(isProperFraction(5,5), false); | ||
|
|
||
| //Case 3: (-3)/(-5) is a proper fraction | ||
| assertEquals(isFinite(-3,-5), true); |
There was a problem hiding this comment.
Are we testing for the right thing here?
Comment on lines
+32
to
+39
| if (!validSuits.includes(suit) || !validRanks.includes(rank)) { | ||
| throw new Error("Invalid card"); | ||
| } | ||
|
|
||
| if (rank === "A") return 11; | ||
| if (["J", "Q", "K"].includes(rank)) return 10; | ||
|
|
||
| return Number(rank); |
There was a problem hiding this comment.
Nice, I really like the use of the "guard pattern" here to deal with errors first 👍🏻.
| // Handling invalid cards | ||
| try { | ||
| getCardValue("invalid"); | ||
| //Examples J Q K:, |
There was a problem hiding this comment.
Seems like we might be missing a case here?
| }) | ||
|
|
||
| // Case 6: Invalid angles | ||
| test('should return "Invalid angle"when (angle>=360)', ()=> { |
There was a problem hiding this comment.
Again, let's focus on other edge cases and boundaries that could occur here!
| }); | ||
|
|
||
| //case:absolute numerator is bigger than absolute denominator | ||
| test ('should return false when numerator absolute is bigger than denominator absolute',() => { |
There was a problem hiding this comment.
Are these all possible combinations? Keep in mind that you can group similar tests together with Jest.
Lindronics
added
Reviewed
pathywang
added
Needs Review
Lindronics
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
i did prep the do this coursework with node and npm test to check everything is ok