London | 26-ITP-January | Eugenie Ahangama | Sprint 1 | coursework/sprint-1 #927
Open
Eugenie-A wants to merge 21 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-January | Eugenie Ahangama | Sprint 1 | coursework/sprint-1 #927Eugenie-A wants to merge 21 commits intoCodeYourFuture:mainfrom
Eugenie-A wants to merge 21 commits intoCodeYourFuture:mainfrom
Conversation
…onvert cardNumber to a string
…alid JavaScript strings
… and replaceAll explanation
…aviour and console output
Eugenie-A
added
Needs Review
cjyuan
reviewed
Feb 12, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good. I just have a few suggestions and questions.
cjyuan
added
Reviewed
Author
|
Hi @cjyuan Thank you for the feedback, I was hoping you could check my changes to the files. |
Contributor
|
Can you add "Needs review" label? |
Eugenie-A
added
Needs Review
Author
I have changed the label to 'Needs review' |
Contributor
|
Thanks for addressing each inline comment clearly! Well done! |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this project, I completed both the coding exercises and practical exploration of browser based functions using the Chome DevTools console. I tested how different JavaScript features behave, documented my findings and wrote clear explanations in Markdown.
I referred to MDN documentation throughout this project:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/charAt
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/slice
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Remainder
Questions
Are there habits I should start building now to avoid problems later?