Skip to content

concoredocker.v is an identical copy of concore.v with no Docker adaptations #284

@GaneshPatil7517

Description

@GaneshPatil7517

@pradeeban
Both concore.v and concoredocker.v are 352 lines and completely identical. Unlike the Python/C++ Docker variants (concoredocker.py, concoredocker.hpp) which modify file paths from relative ./in/./out to absolute /in//out for Docker containers, the Verilog Docker variant makes no such adjustment.

In concore.v, the paths are hardcoded as:

reg[(`INPATHLEN-2)*8-1:0] inpath =  "/in";
reg[(`OUTPATHLEN-2)*8-1:0] outpath = "/out";

These already use absolute paths, so it coincidentally works in Docker, but the INPATHLEN and OUTPATHLEN defines are set for these absolute paths and would break if someone tried to use relative ./in paths locally. The Verilog variant should either:

  • Have distinct local vs Docker path configurations like Python/C++, or
  • Be removed if it's truly identical, with mkconcore.py just copying concore.v for both cases.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions