diff --git a/CHANGELOG.md b/CHANGELOG.md index 566fc8355..13a23b45c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +## [55.2.3] +- [ChipGroup] Fixed potential null reference when selected items don't match chip items. +- [SingleLineInputField] Added error logging to Focus method instead of silently swallowing exceptions. +- [FloatingNavigationButton] Replaced hardcoded color with design token `color_fill_highlight`. + ## [55.2.2] - [iOS26][Tip] Added more padding. diff --git a/src/library/DIPS.Mobile.UI/Components/ChipGroup/ChipGroup.cs b/src/library/DIPS.Mobile.UI/Components/ChipGroup/ChipGroup.cs index 498b5968b..8666c4533 100644 --- a/src/library/DIPS.Mobile.UI/Components/ChipGroup/ChipGroup.cs +++ b/src/library/DIPS.Mobile.UI/Components/ChipGroup/ChipGroup.cs @@ -45,8 +45,9 @@ private void SetChipsToggledBasedOnSelectedItems() if (selectedItem is not null) { var chipItem = m_chipItems.FirstOrDefault(chipItem => chipItem.Obj.GetPropertyValue(ItemDisplayProperty)!.Equals(selectedItem.GetPropertyValue(ItemDisplayProperty))); - chipItem!.Chip.IsToggled = true; - ChipToggled(chipItem!, false); + if (chipItem is null) return; + chipItem.Chip.IsToggled = true; + ChipToggled(chipItem, false); } } else @@ -58,8 +59,9 @@ private void SetChipsToggledBasedOnSelectedItems() selectedItemList.ForEach(item => { var chipItem = m_chipItems.FirstOrDefault(chipItem => chipItem.Obj.GetPropertyValue(ItemDisplayProperty)!.Equals(item.GetPropertyValue(ItemDisplayProperty))); - chipItem!.Chip.IsToggled = true; - ChipToggled(chipItem!, false); + if (chipItem is null) return; + chipItem.Chip.IsToggled = true; + ChipToggled(chipItem, false); }); } } diff --git a/src/library/DIPS.Mobile.UI/Components/Navigation/FloatingNavigationButton/FloatingNavigationButton.cs b/src/library/DIPS.Mobile.UI/Components/Navigation/FloatingNavigationButton/FloatingNavigationButton.cs index 09c1f0442..b199bfc32 100644 --- a/src/library/DIPS.Mobile.UI/Components/Navigation/FloatingNavigationButton/FloatingNavigationButton.cs +++ b/src/library/DIPS.Mobile.UI/Components/Navigation/FloatingNavigationButton/FloatingNavigationButton.cs @@ -16,7 +16,7 @@ namespace DIPS.Mobile.UI.Components.Navigation.FloatingNavigationButton; internal class FloatingNavigationButton : Grid { private Color OpenedColor = Colors.GetColor(ColorName.color_fill_default); - private Color ClosedColor = Color.FromArgb("#BF8DCE"); + private Color ClosedColor = Colors.GetColor(ColorName.color_fill_highlight); private ImageSource OpenedIcon = Icons.GetIcon(IconName.close_line); private ImageSource ClosedIcon = Icons.GetIcon(IconName.menu_line); private readonly FloatingNavigationButtonConfigurator m_floatingNavigationButtonConfigurator; @@ -132,7 +132,7 @@ public View CreateAnimateableButton() { DUI.EnsureSkLottieResourcesAdded(); - var closedColor = Color.FromArgb("#BF8DCE"); + var closedColor = Colors.GetColor(ColorName.color_fill_highlight); var button = new Border() { HeightRequest = Sizes.GetSize(SizeName.size_15), diff --git a/src/library/DIPS.Mobile.UI/Components/TextFields/InputFields/SingleLineInputField.cs b/src/library/DIPS.Mobile.UI/Components/TextFields/InputFields/SingleLineInputField.cs index cceb82fe8..220b5a744 100644 --- a/src/library/DIPS.Mobile.UI/Components/TextFields/InputFields/SingleLineInputField.cs +++ b/src/library/DIPS.Mobile.UI/Components/TextFields/InputFields/SingleLineInputField.cs @@ -2,6 +2,7 @@ using DIPS.Mobile.UI.Effects.Touch; using DIPS.Mobile.UI.Formatters; using DIPS.Mobile.UI.Internal; +using DIPS.Mobile.UI.Internal.Logging; using DIPS.Mobile.UI.Resources.LocalizedStrings.LocalizedStrings; using DIPS.Mobile.UI.Resources.Styles; using DIPS.Mobile.UI.Resources.Styles.InputField; @@ -298,7 +299,7 @@ private void UpdateInputViewVisibility() } catch (Exception e) { - + DUILogService.LogError($"Focus failed: {e.Message}"); } }