Skip to content

effect/ui: an annotated update $ no longer replaces a component's loaders - #10591

Merged
tim-smart merged 1 commit into
agent/architect/dda317b8e7e4from
agent/nelson/eff-3716-annotated-update
Nov 13, 2026
Merged

tim-smart merged 1 commit into
agent/architect/dda317b8e7e4from
agent/nelson/eff-3716-annotated-update

Conversation

@tim-smart

@tim-smart tim-smart commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #10590, from the review on EFF-3716.

Preserves regression coverage for an annotated update helper accidentally erasing a component's declared loaders and read-service requirements.

Rebased onto integration head 9ebcae7184 after #10592 introduced Component.define(...).make(...). That API fixes the inference boundary structurally: loader type L is fixed by define before make receives the annotated update callback. The old conditional inference guard is therefore no longer needed. The rebase keeps the new API and migrates the reviewed regression, asserting both the loader record and required read service. The remaining diff is test-only.

Validation after rebase (through nix develop -c):

  • pnpm test-types packages/effect/typetest/ui/Loaders.tst.ts: 40 tests / 118 assertions across TypeScript 5.9.3 and 6.0.3.
  • pnpm check
  • pnpm check-tsc

Automatic CI does not run for this integration-branch target. Full PR CI runs on parent #10483 after integration.

No changeset: test-only follow-up for unreleased effect/ui.

Closes EFF-3716

@changeset-bot

changeset-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1307bb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tim-smart
tim-smart force-pushed the agent/nelson/eff-3716-annotated-update branch from f0047ed to 1307bb4 Compare November 13, 2026 01:14
@tim-smart
tim-smart merged commit 4d0cf03 into agent/architect/dda317b8e7e4 Nov 13, 2026
@tim-smart
tim-smart deleted the agent/nelson/eff-3716-annotated-update branch November 13, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant