Repository navigation
Conversation
|
tim-smart
force-pushed
the
agent/nelson/eff-3716-annotated-update
branch
from
November 13, 2026 01:14
f0047ed to
1307bb4
Compare
tim-smart
added a commit
that referenced
this pull request
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10590, from the review on EFF-3716.
Preserves regression coverage for an annotated update helper accidentally erasing a component's declared loaders and read-service requirements.
Rebased onto integration head
9ebcae7184after #10592 introducedComponent.define(...).make(...). That API fixes the inference boundary structurally: loader typeLis fixed bydefinebeforemakereceives the annotated update callback. The old conditional inference guard is therefore no longer needed. The rebase keeps the new API and migrates the reviewed regression, asserting both the loader record and required read service. The remaining diff is test-only.Validation after rebase (through
nix develop -c):pnpm test-types packages/effect/typetest/ui/Loaders.tst.ts: 40 tests / 118 assertions across TypeScript 5.9.3 and 6.0.3.pnpm checkpnpm check-tscAutomatic CI does not run for this integration-branch target. Full PR CI runs on parent #10483 after integration.
No changeset: test-only follow-up for unreleased effect/ui.
Closes EFF-3716