Migrate the query banned users payload to the generated QueryBannedUsersPayload - #6737
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
529fc69 to
3192a5b
Compare
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe banned-user query now uses ChangesBanned-user query
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to The banned-user query migration has no identified issue requiring a fix before merge. Normal checks remain appropriate. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The query appears to retain its authenticated endpoint and request behavior. No new security exposure was identified, but server-side enforcement was not assessed. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the payload fields, Comment |
|
|
🚀 Available in v7.13.0 |



Goal
Send the query banned users payload with the generated
QueryBannedUsersPayload.Part of AND-1291
Implementation
QueryBannedUsersPayload, with the typedSortParamRequestsort, for thequery_banned_userspayload, and delete the hand-writtenQueryBannedUsersRequest.The payload on the wire is unchanged, key order aside. The new optional
exclude_expired_bansstays unset.Testing
QueryBannedUsersPayloadAdapterTestpins the serialized payload.On a device, with two bans two seconds apart: the filter, both sort directions,
limit,offsetand eachcreated_atbound returned exactly the expected bans, and everyBannedUserfield matched.🤖 Generated with Claude Code