Add iscover, the cover predicate#30
Merged
Merged
Conversation
a[i]*b[j] >= abs(A[i,j]) is the inequality this package is organized around, but there was no function to ask it. The solvers satisfy it by construction, so the gap went unnoticed; soft covers do not, which makes "does this actually cover A?" a real question a caller cannot currently put to the package. The test suite had already answered it by carrying its own predicate, which is the usual sign one belongs in the package. Coverage is a walk over the support: an entry that is zero constrains nothing, so only nonnegative scales make it sound to skip it. That precondition is enforced rather than documented -- a negative scale raises rather than silently reporting a cover that isn't one -- and it lets the check run in time proportional to the support, through the same foreach_support hook the solvers use. rtol and atol supply the slack a producing algorithm warrants, and default to none, so the bare call is the exact inequality. atol is subtracted only when nonzero, since abs(A[i,j]) - atol is undefined when the two carry different units. The tests now exercise the shipped function instead of a private copy. Assisted-by: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 98.53% 98.55% +0.01%
==========================================
Files 12 13 +1
Lines 2052 2070 +18
==========================================
+ Hits 2022 2040 +18
Misses 30 30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a[i]*b[j] >= abs(A[i,j]) is the inequality this package is organized
around, but there was no function to ask it. The solvers satisfy it by
construction, so the gap went unnoticed; soft covers do not, which makes
"does this actually cover A?" a real question a caller cannot currently
put to the package. The test suite had already answered it by carrying
its own predicate, which is the usual sign one belongs in the package.
Coverage is a walk over the support: an entry that is zero constrains
nothing, so only nonnegative scales make it sound to skip it. That
precondition is enforced rather than documented -- a negative scale
raises rather than silently reporting a cover that isn't one -- and it
lets the check run in time proportional to the support, through the same
foreach_support hook the solvers use.
rtol and atol supply the slack a producing algorithm warrants, and
default to none, so the bare call is the exact inequality. atol is
subtracted only when nonzero, since abs(A[i,j]) - atol is undefined when
the two carry different units.
The tests now exercise the shipped function instead of a private copy.
Assisted-by: Claude Opus 4.8 noreply@anthropic.com