Add logging, simplify validation of folder.

Author: HarelM

src/ElevationHelper.cs

@@ -19,20 +19,12 @@ internal static class ElevationHelper
 
         public static bool ValidateFolder(IFileProvider fileProvider, ILogger logger)
         {
-            if (fileProvider.GetDirectoryContents(ELEVATION_CACHE).Any() == false)
-            {
-                logger.LogError($"Elevation service initialization: The folder: {ELEVATION_CACHE} does not exists, please make sure this folder exists");
-                return false;
-            }
-
-            var hgtFiles = fileProvider.GetDirectoryContents(ELEVATION_CACHE);
-            if (hgtFiles.Any())
+            if (fileProvider.GetDirectoryContents(ELEVATION_CACHE).Any())
             {
                 return true;
             }
-            logger.LogError($"Elevation service initialization: There are no file in folder: {ELEVATION_CACHE}");
+            logger.LogError($"Elevation service initialization: The folder: {ELEVATION_CACHE} does not exists, please make sure this folder exists");
             return false;
-
         }
 
         public static Coordinate FileNameToKey(string fileName)

src/InMemoryElevationProvider.cs

@@ -36,6 +36,7 @@ public InMemoryElevationProvider(IWebHostEnvironment webHostEnvironment, ILogger
         /// <inheritdoc/>
         public async Task Initialize()
         {
+            _logger.LogInformation("Starting Initialization of In Memory Elevation Provider.");
             if (!ElevationHelper.ValidateFolder(_fileProvider, _logger))
             {
                 return;
@@ -64,7 +65,7 @@ public async Task Initialize()
             }
 
             await Task.WhenAll(_initializationTaskPerLatLng.Values);
-            _logger.LogInformation("Initialization complete.");
+            _logger.LogInformation("Finished Initialization.");
         }
 
         /// <inheritdoc/>

src/MemoryMapElevationProvider.cs

@@ -43,6 +43,7 @@ public MemoryMapElevationProvider(IWebHostEnvironment webHostEnvironment, ILogge
         /// </summary>
         public Task Initialize()
         {
+            _logger.LogInformation("Starting Initialization of Memory Map Elevation Provider.");
             if (!ElevationHelper.ValidateFolder(_fileProvider, _logger))
             {
                 return Task.CompletedTask;
@@ -64,7 +65,7 @@ public Task Initialize()
                 _initializationAvailableFiles[key] = (hgtFile.PhysicalPath, hgtFile.Length); 
             }
 
-            _logger.LogInformation("Initialization complete.");
+            _logger.LogInformation("Finished Initialization.");
             return Task.CompletedTask;
         }