diff --git a/src/SparseArrays.jl b/src/SparseArrays.jl index 98207891..a0217d7a 100644 --- a/src/SparseArrays.jl +++ b/src/SparseArrays.jl @@ -63,6 +63,12 @@ end ## Functions to switch to 0-based indexing to call external sparse solvers # Convert from 1-based to 0-based indices +# `decrement!` has no caller here; JuliaSparse/SuiteSparse.jl, which Julia ships as a +# stdlib, binds it at load time. +function decrement!(A::AbstractArray{T}) where T<:Integer + for i in eachindex(A); A[i] -= oneunit(T) end + A +end decrement(A::AbstractArray) = let y = Array(A) y .= y .- oneunit(eltype(A)) end diff --git a/test/solvers/issues.jl b/test/solvers/issues.jl index 4c2bf346..7e9504fd 100644 --- a/test/solvers/issues.jl +++ b/test/solvers/issues.jl @@ -303,4 +303,13 @@ end @test cond(sparse(Float32[1 2; 3 4]), 1) isa Float32 end +@testset "the names SuiteSparse.jl binds exist" begin + # JuliaSparse/SuiteSparse.jl, which Julia ships as a stdlib, binds these at load time + for name in (:increment, :increment!, :decrement, :decrement!, :LibSuiteSparse, + :CHOLMOD, :SPQR, :UMFPACK) + @test isdefined(SparseArrays, name) + end + @test SparseArrays.decrement!([1, 2, 3]) == [0, 1, 2] +end + end # module