Fix lint errors

Author: Mrtenz

.eslintrc.js

@@ -27,13 +27,6 @@ module.exports = {
         'import-x/unambiguous': 'off',
       },
     },
-    {
-      files: ['**/*.test.js', '**/*.test.ts'],
-      extends: ['@metamask/eslint-config-jest'],
-      rules: {
-        '@typescript-eslint/restrict-template-expressions': 'off',
-      },
-    },
   ],
 
   ignorePatterns: ['!.eslintrc.js', 'lib/', 'dist/'],

package.json

@@ -54,7 +54,6 @@
     "@lavamoat/allow-scripts": "^2.5.1",
     "@lavamoat/preinstall-always-fail": "^3.0.0",
     "@metamask/eslint-config": "^13.0.0",
-    "@metamask/eslint-config-jest": "^13.0.0",
     "@metamask/eslint-config-nodejs": "^13.0.0",
     "@metamask/eslint-config-typescript": "^13.0.0",
     "@types/glob": "^7.1.3",
@@ -68,7 +67,6 @@
     "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import-x": "^0.5.1",
-    "eslint-plugin-jest": "^27.9.0",
     "eslint-plugin-jsdoc": "^47.0.2",
     "eslint-plugin-n": "^16.6.2",
     "eslint-plugin-prettier": "^5.5.5",

src/git-operations.test.ts

@@ -1,9 +1,10 @@
+/* eslint-disable import-x/first */
 // This must be set before the import, so that the default root workspace is set
 process.env.GITHUB_WORKSPACE = 'root';
 
 import execa from 'execa';
-
 import { vi, describe, it, expect } from 'vitest';
+
 import {
   didPackageChange,
   getRepositoryHttpsUrl,

src/index.test.ts

@@ -1,10 +1,9 @@
 import * as actionsCore from '@actions/core';
+import { describe, expect, it, vi } from 'vitest';
 
 import * as actionModule from './update';
 import * as utils from './utils';
 
-import { describe, expect, it, vi } from 'vitest';
-
 vi.mock('@actions/core', () => {
   return {
     error: vi.fn(),

src/package-operations.test.ts

@@ -1,14 +1,24 @@
-import {
+import type {
   ManifestDependencyFieldNames,
   PackageManifest,
+} from '@metamask/action-utils';
+import {
   getPackageManifest,
   getWorkspaceLocations,
   writeJsonFile,
+  ManifestFieldNames,
 } from '@metamask/action-utils';
-import { ManifestFieldNames } from '@metamask/action-utils';
 import * as autoChangelog from '@metamask/auto-changelog';
 import { promises as fs } from 'fs';
 import cloneDeep from 'lodash.clonedeep';
+import {
+  beforeEach,
+  describe,
+  expect,
+  it,
+  vi,
+  type MockInstance,
+} from 'vitest';
 
 import * as gitOps from './git-operations';
 import {
@@ -19,8 +29,6 @@ import {
   updatePackages,
 } from './package-operations';
 
-import { beforeEach, describe, expect, it, vi, type MockInstance } from 'vitest';
-
 vi.mock('fs', () => ({
   default: {},
   promises: {
@@ -70,10 +78,6 @@ type DependencyFieldsDict = Partial<
   Record<ManifestDependencyFieldNames, Record<string, string>>
 >;
 
-// Convenience method to match behavior of utils.writeJsonFile
-const jsonStringify = (value: unknown): string =>
-  `${JSON.stringify(value, null, 2)}\n`;
-
 const getMockManifest = (
   name: string,
   version: string,
@@ -104,9 +108,7 @@ describe('package-operations', () => {
     };
 
     beforeEach(() => {
-      vi.spyOn(fs, 'lstat').mockImplementation((async (
-        path: string,
-      ) => {
+      vi.spyOn(fs, 'lstat').mockImplementation((async (path: string) => {
         return path.endsWith(SOME_FILE)
           ? { isDirectory: (): boolean => false }
           : { isDirectory: (): boolean => true };
@@ -411,9 +413,10 @@ describe('package-operations', () => {
 
         // no new changelog content and no unreleased changes will cause an error
         updateChangelogMock.mockImplementation(async () => '');
-        const actualChangelog = await vi.importActual<typeof import('@metamask/auto-changelog')>(
-          '@metamask/auto-changelog/dist/changelog',
-        );
+        const actualChangelog = await vi.importActual<
+          // eslint-disable-next-line @typescript-eslint/consistent-type-imports
+          typeof import('@metamask/auto-changelog')
+        >('@metamask/auto-changelog/dist/changelog');
 
         // @ts-expect-error: Partial mock.
         parseChangelogMock.mockImplementationOnce(() => {
@@ -478,6 +481,7 @@ describe('package-operations', () => {
 
         updateChangelogMock.mockImplementation(async () => '');
         const actualChangelog = await vi.importActual<
+          // eslint-disable-next-line @typescript-eslint/consistent-type-imports
           typeof import('@metamask/auto-changelog')
         >('@metamask/auto-changelog/dist/changelog');
 
@@ -543,6 +547,7 @@ describe('package-operations', () => {
         // no new changelog content and no unreleased changes will cause an error
         updateChangelogMock.mockImplementation(async () => '');
         const actualChangelog = await vi.importActual<
+          // eslint-disable-next-line @typescript-eslint/consistent-type-imports
           typeof import('@metamask/auto-changelog')
         >('@metamask/auto-changelog/dist/changelog');
 

src/update.test.ts

@@ -1,13 +1,13 @@
 import * as actionsCore from '@actions/core';
 import * as actionUtils from '@metamask/action-utils';
+import type { Mock } from 'vitest';
+import { describe, expect, it, beforeEach, vi } from 'vitest';
 
 import * as gitOperations from './git-operations';
 import * as packageOperations from './package-operations';
 import { performUpdate } from './update';
 import * as utils from './utils';
 
-import { describe, expect, it, beforeEach, vi, Mock } from 'vitest';
-
 vi.mock('@actions/core', () => {
   return {
     setOutput: vi.fn(),

src/utils.test.ts

@@ -1,11 +1,11 @@
+import { afterEach, describe, expect, it, vi } from 'vitest';
+
 import {
   AcceptedSemverReleaseTypes,
   getActionInputs,
   InputKeys,
 } from './utils';
 
-import { afterEach, describe, expect, it, vi } from 'vitest';
-
 vi.mock('fs', () => ({
   promises: {
     readFile: vi.fn(),