[JitDiff X64] [hez2010] JIT: fold obj.GetType() == typeof(T) with the help of VN

[MihuBot]

Job completed in 23 minutes 48 seconds (remote runner delay: 1 minute 21 seconds).
dotnet/runtime#129753

Main commit: dotnet/runtime@f4430a4
PR commit: hez2010/runtime@79dcae0

Diffs

Found 90 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 135994779
Total bytes of diff: 135994746
Total bytes of delta: -33 (-0.00 % of base)
Total relative delta: -0.20
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
         -21 : System.Private.CoreLib.dasm (-0.00 % of base)
         -12 : nunit.framework.dasm (-0.00 % of base)

2 total files with Code Size differences (2 improved, 0 regressed), 350 unchanged.

Top method improvements (bytes):
         -21 (-0.42 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource+EventSourceHelpers:CreateManifestAndDescriptors(System.Type,System.String,System.Diagnostics.Tracing.EventSource,int):byte[] (FullOpts)
         -12 (-20.00 % of base) : nunit.framework.dasm - NUnit.Framework.Internal.Extensions.ArgumentsExtensions:LastArgumentIsCancellationToken(System.Object[]):bool (FullOpts)

Top method improvements (percentages):
         -12 (-20.00 % of base) : nunit.framework.dasm - NUnit.Framework.Internal.Extensions.ArgumentsExtensions:LastArgumentIsCancellationToken(System.Object[]):bool (FullOpts)
         -21 (-0.42 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource+EventSourceHelpers:CreateManifestAndDescriptors(System.Type,System.String,System.Diagnostics.Tracing.EventSource,int):byte[] (FullOpts)

2 total methods with Code Size differences (2 improved, 0 regressed), 734927 unchanged.

--------------------------------------------------------------------------------

Artifacts:

• PackageList.json (33 KB)
• diff-frameworks.txt (1 KB)
• ShortDiffsImprovements.md (3 KB)
• LongDiffsImprovements.md (92 KB)
• jit-diffs-pr.7z (111 MB)
• jit-diffs-main.7z (118 MB)

[MihuBot]

Top method improvements

-12 (-20.00 % of base) - NUnit.Framework.Internal.Extensions.ArgumentsExtensions:LastArgumentIsCancellationToken(System.Object[]):bool

 ; Assembly listing for method NUnit.Framework.Internal.Extensions.ArgumentsExtensions:LastArgumentIsCancellationToken(System.Object[]):bool (FullOpts)
 ; Emitting BLENDED_CODE for x64 + VEX + EVEX on Unix
 ; FullOpts code
 ; optimized code
 ; rbp based frame
 ; partially interruptible
 ; No PGO data
 ; Final local variable assignments
 ;
 ;  V00 arg0         [V00,T00] (  4,  3.50)     ref  ->  rdi         class-hnd single-def <System.Object[]>
 ;# V01 OutArgs      [V01    ] (  1,  1   )  struct ( 0) [rsp+0x00]  do-not-enreg[XS] addr-exposed "OutgoingArgSpace" <Empty>
-;  V02 tmp1         [V02,T01] (  3,  3   )     ref  ->  rdi         class-hnd single-def "dup spill" <System.Object>
+;  V02 tmp1         [V02,T01] (  3,  3   )     ref  ->  rax         class-hnd single-def "dup spill" <System.Object>
 ;* V03 tmp2         [V03    ] (  0,  0   )     ref  ->  zero-ref    single-def
-;  V04 tmp3         [V04,T03] (  2,  1   )     ref  ->  rax        
-;  V05 cse0         [V05,T04] (  2,  1   )     int  ->  rax         "CSE #02: aggressive"
+;* V04 tmp3         [V04    ] (  0,  0   )     ref  ->  zero-ref   
+;  V05 cse0         [V05,T03] (  2,  1   )     int  ->  rax         "CSE #02: aggressive"
 ;  V06 cse1         [V06,T02] (  3,  2.50)     int  ->  rax         "CSE #01: aggressive"
 ;
 ; Lcl frame size = 0
 
 G_M39729_IG01:
        push     rbp
        mov      rbp, rsp
 						;; size=4 bbWeight=1 PerfScore 1.25
 G_M39729_IG02:
        mov      eax, dword ptr [rdi+0x08]
        test     eax, eax
        je       SHORT G_M39729_IG05
 						;; size=7 bbWeight=1 PerfScore 3.25
 G_M39729_IG03:
        dec      eax
-       mov      rdi, gword ptr [rdi+8*rax+0x10]
-       test     rdi, rdi
+       mov      rax, gword ptr [rdi+8*rax+0x10]
+       test     rax, rax
        je       SHORT G_M39729_IG05
-       mov      rax, 0xD1FFAB1E      ; code for System.Object:GetType():System.Type:this
-       call     [rax]System.Object:GetType():System.Type:this
-       mov      rcx, 0xD1FFAB1E      ; 'System.Threading.CancellationToken'
-       cmp      rax, rcx
+       mov      rcx, 0xD1FFAB1E      ; System.Threading.CancellationToken
+       cmp      qword ptr [rax], rcx
        sete     al
        movzx    rax, al
-						;; size=43 bbWeight=0.50 PerfScore 4.00
+						;; size=31 bbWeight=0.50 PerfScore 3.25
 G_M39729_IG04:
        pop      rbp
        ret      
 						;; size=2 bbWeight=0.50 PerfScore 0.75
 G_M39729_IG05:
        xor      eax, eax
 						;; size=2 bbWeight=0.25 PerfScore 0.06
 G_M39729_IG06:
        pop      rbp
        ret      
 						;; size=2 bbWeight=0.25 PerfScore 0.38
 
-; Total bytes of code 60, prolog size 4, PerfScore 9.69, instruction count 20, allocated bytes for code 60 (MethodHash=3a7264ce) for method NUnit.Framework.Internal.Extensions.ArgumentsExtensions:LastArgumentIsCancellationToken(System.Object[]):bool (FullOpts)
+; Total bytes of code 48, prolog size 4, PerfScore 8.94, instruction count 18, allocated bytes for code 48 (MethodHash=3a7264ce) for method NUnit.Framework.Internal.Extensions.ArgumentsExtensions:LastArgumentIsCancellationToken(System.Object[]):bool (FullOpts)
 ; ============================================================

Note: some changes were skipped as they were too large to fit into a comment.

Larger list of diffs: https://gist.github.com/MihuBot/0f08c9126365f0f96adfc336812bb442

[MihuBot]

@hez2010