[JitDiff X64] [hez2010] JIT: fold obj.GetType() == typeof(T) with the help of VN

[MihuBot]

Job completed in 23 minutes 35 seconds (remote runner delay: 1 minute 10 seconds).
dotnet/runtime#129753
Using arguments: -nuget
Main commit: dotnet/runtime@f4430a4
PR commit: hez2010/runtime@c485ab6

Diffs

Found 104 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 352423404
Total bytes of diff: 352423356
Total bytes of delta: -48 (-0.00 % of base)
Total relative delta: -0.25
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
         -21 : System.Private.CoreLib.dasm (-0.00 % of base)
         -15 : AngleSharp.Css.dasm (-0.00 % of base)
         -12 : nunit.framework.dasm (-0.00 % of base)

3 total files with Code Size differences (3 improved, 0 regressed), 739 unchanged.

Top method improvements (bytes):
         -21 (-0.42 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource+EventSourceHelpers:CreateManifestAndDescriptors(System.Type,System.String,System.Diagnostics.Tracing.EventSource,int):byte[] (FullOpts)
         -15 (-4.27 % of base) : AngleSharp.Css.dasm - AngleSharp.Css.Dom.CssValueExtensions:Is(AngleSharp.Css.Dom.ICssValue,System.String):bool (FullOpts)
         -12 (-20.00 % of base) : nunit.framework.dasm - NUnit.Framework.Internal.Extensions.ArgumentsExtensions:LastArgumentIsCancellationToken(System.Object[]):bool (FullOpts)

Top method improvements (percentages):
         -12 (-20.00 % of base) : nunit.framework.dasm - NUnit.Framework.Internal.Extensions.ArgumentsExtensions:LastArgumentIsCancellationToken(System.Object[]):bool (FullOpts)
         -15 (-4.27 % of base) : AngleSharp.Css.dasm - AngleSharp.Css.Dom.CssValueExtensions:Is(AngleSharp.Css.Dom.ICssValue,System.String):bool (FullOpts)
         -21 (-0.42 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource+EventSourceHelpers:CreateManifestAndDescriptors(System.Type,System.String,System.Diagnostics.Tracing.EventSource,int):byte[] (FullOpts)

3 total methods with Code Size differences (3 improved, 0 regressed), 1922107 unchanged.

--------------------------------------------------------------------------------

Artifacts:

• PackageList.json (202 KB)
• diff-frameworks.txt (1 KB)
• ShortDiffsImprovements.md (11 KB)
• LongDiffsImprovements.md (100 KB)
• jit-diffs-main.7z (300 MB)
• jit-diffs-pr.7z (306 MB)

[MihuBot]

Top method improvements

-15 (-4.27 % of base) - AngleSharp.Css.Dom.CssValueExtensions:Is(AngleSharp.Css.Dom.ICssValue,System.String):bool

 ; Assembly listing for method AngleSharp.Css.Dom.CssValueExtensions:Is(AngleSharp.Css.Dom.ICssValue,System.String):bool (FullOpts)
 ; Emitting BLENDED_CODE for x64 + VEX + EVEX on Unix
 ; FullOpts code
 ; optimized code
 ; rbp based frame
 ; partially interruptible
 ; No PGO data
 ; 0 inlinees with PGO data; 3 single block inlinees; 0 inlinees without PGO data
 ; Final local variable assignments
 ;
 ;  V00 arg0         [V00,T00] ( 12, 31   )     ref  ->  rbx         class-hnd <AngleSharp.Css.Dom.ICssValue>
 ;  V01 arg1         [V01,T02] (  4,  6   )     ref  ->  r15         class-hnd single-def <System.String>
 ;* V02 loc0         [V02    ] (  0,  0   )  struct ( 8) zero-ref    ld-addr-op <AngleSharp.Css.Values.CssIdentifierValue>
 ;  V03 loc1         [V03,T01] (  4, 12   )     ref  ->  r14         class-hnd <AngleSharp.Css.Values.ICssMultipleValue>
 ;  V04 loc2         [V04,T03] (  4,  8   )     ref  ->  r14         class-hnd <AngleSharp.Css.Values.ICssSpecialValue>
 ;# V05 OutArgs      [V05    ] (  1,  1   )  struct ( 0) [rsp+0x00]  do-not-enreg[XS] addr-exposed "OutgoingArgSpace" <Empty>
 ;* V06 tmp1         [V06    ] (  0,  0   )     int  ->  zero-ref    "spilling qmarkNull"
-;  V07 tmp2         [V07,T07] (  2,  4   )     ref  ->  rax        
+;* V07 tmp2         [V07    ] (  0,  0   )     ref  ->  zero-ref   
 ;* V08 tmp3         [V08    ] (  0,  0   )     ref  ->  zero-ref    class-hnd exact "Inlining Arg" <System.String>
 ;* V09 tmp4         [V09    ] (  0,  0   )     ref  ->  zero-ref    class-hnd exact "Inlining Arg" <System.String>
 ;* V10 tmp5         [V10    ] (  0,  0   )     int  ->  zero-ref    "Single return block return value"
-;  V11 tmp6         [V11,T08] (  2,  4   )     ref  ->  rdi         "field V02._text (fldOffset=0x0)" P-INDEP
+;  V11 tmp6         [V11,T07] (  2,  4   )     ref  ->  rdi         "field V02._text (fldOffset=0x0)" P-INDEP
 ;  V12 tmp7         [V12,T04] (  2,  8   )     ref  ->  rdi         "argument with side effect"
 ;  V13 tmp8         [V13,T05] (  2,  8   )     ref  ->  rbx         single-def "argument with side effect"
 ;  V14 tmp9         [V14,T06] (  2,  8   )     ref  ->  rbx         single-def "argument with side effect"
-;  V15 cse0         [V15,T09] (  2,  2   )    long  ->  rdi         "CSE #01: moderate"
+;  V15 cse0         [V15,T08] (  2,  2   )    long  ->  rdi         "CSE #01: moderate"
 ;
 ; Lcl frame size = 8
 
 G_M6878_IG01:
        push     rbp
        push     r15
        push     r14
        push     rbx
        push     rax
        lea      rbp, [rsp+0x20]
        mov      rbx, rdi
        mov      r15, rsi
 						;; size=18 bbWeight=1 PerfScore 6.00
 G_M6878_IG02:
        jmp      G_M6878_IG12
 						;; size=5 bbWeight=1 PerfScore 2.00
 G_M6878_IG03:
        mov      rdi, r14
        mov      r11, 0xD1FFAB1E      ; code for AngleSharp.Css.Values.ICssSpecialValue:get_Value():AngleSharp.Css.Dom.ICssValue:this
        call     [r11]AngleSharp.Css.Values.ICssSpecialValue:get_Value():AngleSharp.Css.Dom.ICssValue:this
        mov      rbx, rax
        jmp      G_M6878_IG12
 						;; size=24 bbWeight=2 PerfScore 11.50
 G_M6878_IG04:
        test     rbx, rbx
        je       SHORT G_M6878_IG06
 						;; size=5 bbWeight=4 PerfScore 5.00
 G_M6878_IG05:
-       mov      rdi, rbx
-       mov      rax, 0xD1FFAB1E      ; code for System.Object:GetType():System.Type:this
-       call     [rax]System.Object:GetType():System.Type:this
-       mov      rdi, 0xD1FFAB1E      ; 'AngleSharp.Css.Values.CssConstantValue`1[T]'
-       cmp      rax, rdi
+       mov      rdi, 0xD1FFAB1E      ; AngleSharp.Css.Values.CssConstantValue`1[<UNDEF>]
+       cmp      qword ptr [rbx], rdi
        jne      SHORT G_M6878_IG06
        mov      rdi, rbx
        mov      r11, 0xD1FFAB1E      ; code for AngleSharp.Css.Dom.ICssValue:get_CssText():System.String:this
        call     [r11]AngleSharp.Css.Dom.ICssValue:get_CssText():System.String:this
        mov      rdi, rax
        mov      rsi, r15
        mov      edx, 5
        mov      rax, 0xD1FFAB1E      ; code for System.String:Equals(System.String,System.String,int):bool
        call     [rax]System.String:Equals(System.String,System.String,int):bool
        test     eax, eax
        jne      G_M6878_IG15
-						;; size=77 bbWeight=2 PerfScore 27.50
+						;; size=62 bbWeight=2 PerfScore 24.00
 G_M6878_IG06:
        mov      rsi, rbx
        mov      rdi, 0xD1FFAB1E      ; AngleSharp.Css.Values.ICssMultipleValue
        mov      rax, 0xD1FFAB1E      ; code for CORINFO_HELP_ISINSTANCEOFINTERFACE
        call     [rax]CORINFO_HELP_ISINSTANCEOFINTERFACE
        mov      r14, rax
        test     r14, r14
        je       SHORT G_M6878_IG08
 						;; size=33 bbWeight=4 PerfScore 21.00
 G_M6878_IG07:
        mov      rdi, r14
        mov      r11, 0xD1FFAB1E      ; code for AngleSharp.Css.Values.ICssMultipleValue:get_Count():int:this
        call     [r11]AngleSharp.Css.Values.ICssMultipleValue:get_Count():int:this
        cmp      eax, 1
        je       SHORT G_M6878_IG11
 						;; size=21 bbWeight=2 PerfScore 9.50
 G_M6878_IG08:
        mov      rsi, rbx
        mov      rdi, 0xD1FFAB1E      ; AngleSharp.Css.Values.ICssSpecialValue
        mov      rax, 0xD1FFAB1E      ; code for CORINFO_HELP_ISINSTANCEOFINTERFACE
        call     [rax]CORINFO_HELP_ISINSTANCEOFINTERFACE
        mov      r14, rax
        test     r14, r14
        je       SHORT G_M6878_IG09
        mov      rdi, r14
        mov      r11, 0xD1FFAB1E      ; code for AngleSharp.Css.Values.ICssSpecialValue:get_Value():AngleSharp.Css.Dom.ICssValue:this
        call     [r11]AngleSharp.Css.Values.ICssSpecialValue:get_Value():AngleSharp.Css.Dom.ICssValue:this
        test     rax, rax
        jne      G_M6878_IG03
 						;; size=58 bbWeight=2 PerfScore 20.00
 G_M6878_IG09:
        xor      eax, eax
 						;; size=2 bbWeight=0.50 PerfScore 0.12
 G_M6878_IG10:
        add      rsp, 8
        pop      rbx
        pop      r14
        pop      r15
        pop      rbp
        ret      
 						;; size=11 bbWeight=0.50 PerfScore 1.62
 G_M6878_IG11:
        mov      rdi, r14
        mov      r11, 0xD1FFAB1E      ; code for AngleSharp.Css.Values.ICssMultipleValue:get_Item(int):AngleSharp.Css.Dom.ICssValue:this
        xor      esi, esi
        call     [r11]AngleSharp.Css.Values.ICssMultipleValue:get_Item(int):AngleSharp.Css.Dom.ICssValue:this
        mov      rbx, rax
 						;; size=21 bbWeight=2 PerfScore 8.00
 G_M6878_IG12:
        test     rbx, rbx
        je       G_M6878_IG04
 						;; size=9 bbWeight=8 PerfScore 10.00
 G_M6878_IG13:
        mov      rdi, 0xD1FFAB1E      ; AngleSharp.Css.Values.CssIdentifierValue
        cmp      qword ptr [rbx], rdi
        jne      G_M6878_IG04
 						;; size=19 bbWeight=1 PerfScore 3.25
 G_M6878_IG14:
        mov      rdi, gword ptr [rbx+0x08]
        mov      rsi, r15
        mov      edx, 5
        mov      rax, 0xD1FFAB1E      ; code for System.String:Equals(System.String,System.String,int):bool
        call     [rax]System.String:Equals(System.String,System.String,int):bool
        test     eax, eax
        je       G_M6878_IG05
 						;; size=32 bbWeight=2 PerfScore 14.00
 G_M6878_IG15:
        mov      eax, 1
 						;; size=5 bbWeight=0.50 PerfScore 0.12
 G_M6878_IG16:
        add      rsp, 8
        pop      rbx
        pop      r14
        pop      r15
        pop      rbp
        ret      
 						;; size=11 bbWeight=0.50 PerfScore 1.62
 
-; Total bytes of code 351, prolog size 12, PerfScore 141.25, instruction count 87, allocated bytes for code 351 (MethodHash=3252e521) for method AngleSharp.Css.Dom.CssValueExtensions:Is(AngleSharp.Css.Dom.ICssValue,System.String):bool (FullOpts)
+; Total bytes of code 336, prolog size 12, PerfScore 137.75, instruction count 84, allocated bytes for code 336 (MethodHash=3252e521) for method AngleSharp.Css.Dom.CssValueExtensions:Is(AngleSharp.Css.Dom.ICssValue,System.String):bool (FullOpts)
 ; ============================================================

-12 (-20.00 % of base) - NUnit.Framework.Internal.Extensions.ArgumentsExtensions:LastArgumentIsCancellationToken(System.Object[]):bool

 ; Assembly listing for method NUnit.Framework.Internal.Extensions.ArgumentsExtensions:LastArgumentIsCancellationToken(System.Object[]):bool (FullOpts)
 ; Emitting BLENDED_CODE for x64 + VEX + EVEX on Unix
 ; FullOpts code
 ; optimized code
 ; rbp based frame
 ; partially interruptible
 ; No PGO data
 ; Final local variable assignments
 ;
 ;  V00 arg0         [V00,T00] (  4,  3.50)     ref  ->  rdi         class-hnd single-def <System.Object[]>
 ;# V01 OutArgs      [V01    ] (  1,  1   )  struct ( 0) [rsp+0x00]  do-not-enreg[XS] addr-exposed "OutgoingArgSpace" <Empty>
-;  V02 tmp1         [V02,T01] (  3,  3   )     ref  ->  rdi         class-hnd single-def "dup spill" <System.Object>
+;  V02 tmp1         [V02,T01] (  3,  3   )     ref  ->  rax         class-hnd single-def "dup spill" <System.Object>
 ;* V03 tmp2         [V03    ] (  0,  0   )     ref  ->  zero-ref    single-def
-;  V04 tmp3         [V04,T03] (  2,  1   )     ref  ->  rax        
-;  V05 cse0         [V05,T04] (  2,  1   )     int  ->  rax         "CSE #02: aggressive"
+;* V04 tmp3         [V04    ] (  0,  0   )     ref  ->  zero-ref   
+;  V05 cse0         [V05,T03] (  2,  1   )     int  ->  rax         "CSE #02: aggressive"
 ;  V06 cse1         [V06,T02] (  3,  2.50)     int  ->  rax         "CSE #01: aggressive"
 ;
 ; Lcl frame size = 0
 
 G_M39729_IG01:
        push     rbp
        mov      rbp, rsp
 						;; size=4 bbWeight=1 PerfScore 1.25
 G_M39729_IG02:
        mov      eax, dword ptr [rdi+0x08]
        test     eax, eax
        je       SHORT G_M39729_IG05
 						;; size=7 bbWeight=1 PerfScore 3.25
 G_M39729_IG03:
        dec      eax
-       mov      rdi, gword ptr [rdi+8*rax+0x10]
-       test     rdi, rdi
+       mov      rax, gword ptr [rdi+8*rax+0x10]
+       test     rax, rax
        je       SHORT G_M39729_IG05
-       mov      rax, 0xD1FFAB1E      ; code for System.Object:GetType():System.Type:this
-       call     [rax]System.Object:GetType():System.Type:this
-       mov      rcx, 0xD1FFAB1E      ; 'System.Threading.CancellationToken'
-       cmp      rax, rcx
+       mov      rcx, 0xD1FFAB1E      ; System.Threading.CancellationToken
+       cmp      qword ptr [rax], rcx
        sete     al
        movzx    rax, al
-						;; size=43 bbWeight=0.50 PerfScore 4.00
+						;; size=31 bbWeight=0.50 PerfScore 3.25
 G_M39729_IG04:
        pop      rbp
        ret      
 						;; size=2 bbWeight=0.50 PerfScore 0.75
 G_M39729_IG05:
        xor      eax, eax
 						;; size=2 bbWeight=0.25 PerfScore 0.06
 G_M39729_IG06:
        pop      rbp
        ret      
 						;; size=2 bbWeight=0.25 PerfScore 0.38
 
-; Total bytes of code 60, prolog size 4, PerfScore 9.69, instruction count 20, allocated bytes for code 60 (MethodHash=3a7264ce) for method NUnit.Framework.Internal.Extensions.ArgumentsExtensions:LastArgumentIsCancellationToken(System.Object[]):bool (FullOpts)
+; Total bytes of code 48, prolog size 4, PerfScore 8.94, instruction count 18, allocated bytes for code 48 (MethodHash=3a7264ce) for method NUnit.Framework.Internal.Extensions.ArgumentsExtensions:LastArgumentIsCancellationToken(System.Object[]):bool (FullOpts)
 ; ============================================================

Note: some changes were skipped as they were too large to fit into a comment.

Larger list of diffs: https://gist.github.com/MihuBot/9f3ebf51bb2969b55978545935cf6055

[MihuBot]

@hez2010