Increase udp responsetime (20ms) and process all messages

backend
=======
- main: add last20ms and use for devices
- devices: loop20 for direct response, readudp loops over received packets, use preset.selected

Author: ewowi

.coderabbit.yaml

@@ -1,9 +1,18 @@
+# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
 language: "en-US"
-
-review:
-  enable_review: true
-  enable_fix_suggestions: true
-  enable_tests_generation: false
-
-context:
-  timeout_ms: 900000   # 15 minutes max
+early_access: true
+reviews:
+  profile: "chill"
+  request_changes_workflow: true
+  high_level_summary: true
+  poem: true
+  review_status: true
+  collapse_walkthrough: false
+  auto_review:
+    enabled: true
+    drafts: true
+  tools:
+    github-checks:
+      timeout_ms: 900000   # 15 minutes max
+chat:
+  auto_reply: true

src/MoonBase/Modules/ModuleDevices.h

@@ -16,6 +16,7 @@
 
   #include "MoonBase/Module.h"
   #include "MoonBase/Utilities.h"
+  #include "MoonBase/pal.h"
 
 struct UDPMessage {
   uint8_t rommel[6];
@@ -40,22 +41,22 @@ class ModuleDevices : public Module {
 
     _moduleLightsControl->addUpdateHandler([this](const String& originId) {
       if (deviceUDP.beginPacket(IPAddress(255, 255, 255, 255), deviceUDPPort)) {
-        UDPMessage message;
+        UDPMessage message{};  // {}: zero message
         message.name = esp32sveltekit.getWiFiSettingsService()->getHostname().c_str();
         message.version = APP_VERSION;
         _moduleLightsControl->read(
             [&](ModuleState& state) {
               message.brightness = state.data["brightness"];
               message.palette = state.data["palette"];
-              message.preset = state.data["preset"];
+              message.preset = state.data["preset"]["selected"];
               String ddd;
               serializeJson(state.data["preset"], ddd);
               EXT_LOGD(MB_TAG, "pr %s", ddd.c_str());
             },
             _moduleName);
-            
+
         EXT_LOGD(MB_TAG, "b: %d pa %d pr %d", message.brightness, message.palette, message.preset);
-        message.uptime = time(nullptr) - millis() / 1000;
+        message.uptime = time(nullptr) - pal::millis() / 1000;
         deviceUDP.write((uint8_t*)&message, sizeof(message));
         deviceUDP.endPacket();
 
@@ -90,7 +91,7 @@ class ModuleDevices : public Module {
     }
   }
 
-  void loop1s() {
+  void loop20ms() {
     if (!WiFi.localIP() && !ETH.localIP()) return;
 
     if (!deviceUDPConnected) return;
@@ -166,15 +167,16 @@ class ModuleDevices : public Module {
   }
 
   void readUDP() {
-    size_t packetSize = deviceUDP.parsePacket();
-    if (packetSize >= 38) {  // WLED has 44, MM had ! 38
-      char buffer[packetSize];
-      UDPMessage message;
-      deviceUDP.read(buffer, packetSize);
-      memcpy(&message, buffer, ::min(packetSize, sizeof(message)));
-      // EXT_LOGD(ML_TAG, "UDP packet read from %d: %s (%d)", deviceUDP.remoteIP()[3], buffer + 6, packetSize);
+    while (size_t packetSize = deviceUDP.parsePacket()) {
+      if (packetSize >= 38) {  // WLED has 44, MM had ! 38
+        char buffer[packetSize];
+        UDPMessage message;
+        deviceUDP.read(buffer, packetSize);
+        memcpy(&message, buffer, ::min(packetSize, sizeof(message)));
+        // EXT_LOGD(ML_TAG, "UDP packet read from %d: %s (%d)", deviceUDP.remoteIP()[3], buffer + 6, packetSize);
 
-      updateDevices(message, deviceUDP.remoteIP());
+        updateDevices(message, deviceUDP.remoteIP());
+      }
     }
   }
 
@@ -187,11 +189,11 @@ class ModuleDevices : public Module {
           [&](ModuleState& state) {
             message.brightness = state.data["brightness"];
             message.palette = state.data["palette"];
-            message.preset = state.data["preset"];
+            message.preset = state.data["preset"]["selected"];
           },
           _moduleName);
 
-      message.uptime = time(nullptr) - millis() / 1000;
+      message.uptime = time(nullptr) ? time(nullptr) - pal::millis() / 1000 : pal::millis() / 1000;
       deviceUDP.write((uint8_t*)&message, sizeof(message));
       deviceUDP.endPacket();
 

src/main.cpp

@@ -361,37 +361,42 @@ void setup() {
   esp32sveltekit.addLoopFunction([]() {
     for (Module* module : modules) module->loop();
 
-    // every second
-    static unsigned long lastSecond = 0;
-    if (millis() - lastSecond >= 1000) {
-      lastSecond = millis();
+    static unsigned long last20ms = 0;
+    if (millis() - last20ms >= 20) {
+      last20ms = millis();
+      moduleDevices.loop20ms();
 
-      moduleIO.loop1s();
-      moduleDevices.loop1s();
-      moduleTasks.loop1s();
+      // every second
+      static unsigned long lastSecond = 0;
+      if (millis() - lastSecond >= 1000) {
+        lastSecond = millis();
 
-      // logYield();
+        moduleIO.loop1s();
+        moduleTasks.loop1s();
+
+        // logYield();
 
   #if FT_ENABLED(FT_MOONLIGHT)
-      // set shared data (eg used in scrolling text effect)
-      sharedData.fps = esp32sveltekit.getAnalyticsService()->lps;
-      sharedData.connectionStatus = (uint8_t)esp32sveltekit.getConnectionStatus();
-      sharedData.clientListSize = esp32sveltekit.getServer()->getClientList().size();
-      sharedData.connectedClients = esp32sveltekit.getSocket()->getConnectedClients();
-      sharedData.activeClients = esp32sveltekit.getSocket()->getActiveClients();
+        // set shared data (eg used in scrolling text effect)
+        sharedData.fps = esp32sveltekit.getAnalyticsService()->lps;
+        sharedData.connectionStatus = (uint8_t)esp32sveltekit.getConnectionStatus();
+        sharedData.clientListSize = esp32sveltekit.getServer()->getClientList().size();
+        sharedData.connectedClients = esp32sveltekit.getSocket()->getConnectedClients();
+        sharedData.activeClients = esp32sveltekit.getSocket()->getActiveClients();
 
     #if FT_ENABLED(FT_LIVESCRIPT)
-      moduleLiveScripts.loop1s();
+        moduleLiveScripts.loop1s();
     #endif
   #endif
-    }
-
-    // every 10 seconds
-    static unsigned long last10Second = 0;
-    if (millis() - last10Second >= 10000) {
-      last10Second = millis();
+  
+        // every 10 seconds
+        static unsigned long last10Second = 0;
+        if (millis() - last10Second >= 10000) {
+          last10Second = millis();
 
-      moduleDevices.loop10s();
+          moduleDevices.loop10s();
+        }
+      }
     }
   });