Skip to content

chore: trigger NVSkills CI for cuopt-user-rules - #1679

Open
ramakrishnap-nv wants to merge 4 commits into
mainfrom
chore/nvskills-ci-cuopt-user-rules
Open

chore: trigger NVSkills CI for cuopt-user-rules#1679
ramakrishnap-nv wants to merge 4 commits into
mainfrom
chore/nvskills-ci-cuopt-user-rules

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

Trivial blank-line addition after SKILL.md frontmatter to trigger NVSkills CI — fetch updated skill card and benchmark for cuopt-user-rules.

@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code owner August 5, 2026 20:33
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@ramakrishnap-nv ramakrishnap-nv self-assigned this Aug 5, 2026
@ramakrishnap-nv ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updated the cuOpt user rules skill metadata, benchmark report, documentation spacing, and Sigstore/in-toto attestation.

Changes

cuOpt user rules publication refresh

Layer / File(s) Summary
Skill metadata and evaluation
skills/cuopt-user-rules/skill-card.md
Updated supported interfaces, credential metadata, references, evaluation identifiers, metric definitions, signals, and agent-specific results.
Publication benchmark
skills/cuopt-user-rules/BENCHMARK.md
Replaced the previous evaluation summary with publication benchmark data, tier statuses, findings, scoring rules, and freshness criteria.
Documentation and attestation
skills/cuopt-user-rules/SKILL.md, skills/cuopt-user-rules/skill.oms.sig
Added heading spacing and updated attestation digests, resource ordering, and DSSE signature.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • NVIDIA/cuopt#1666: Updates the broader cuOpt release metadata, with a directly overlapping skill version change.
  • NVIDIA/cuopt#1675: Applies the same NVSkills benchmark-refresh workflow to another cuOpt skill.

Suggested reviewers: tmckayus, iroy30, afender

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI trigger for the cuopt-user-rules skill, which matches the main objective.
Description check ✅ Passed The description accurately explains the blank-line change and the resulting NVSkills CI updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/nvskills-ci-cuopt-user-rules

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

CI Test Summary

⏭️ All 5 test job(s) skipped.

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/cuopt-user-rules/skill-card.md`:
- Line 74: Correct the Claude Code effectiveness uplift from “+26 points” to
“+27 points” in skills/cuopt-user-rules/skill-card.md lines 74-74 and
skills/cuopt-user-rules/BENCHMARK.md lines 41-41, keeping the surrounding
benchmark values unchanged.
- Around line 18-19: Update the credential metadata in the cuOpt skill card so
it explicitly declares that an NGC API key is required for registry
authentication. Replace the unspecified API-key requirement and “None
identified” credential type with the appropriate NGC API key information,
preserving the existing metadata format.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d44c87df-f0c1-4ba5-95e8-86b1f3385dc5

📥 Commits

Reviewing files that changed from the base of the PR and between 24e086e and a8d1cd0.

📒 Files selected for processing (3)
  • skills/cuopt-user-rules/BENCHMARK.md
  • skills/cuopt-user-rules/skill-card.md
  • skills/cuopt-user-rules/skill.oms.sig

Comment on lines +18 to +19
**Requires API Key or External Credential:** [Not Specified] <br>
**Credential Type(s):** [None identified] <br>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Declare the NGC API key requirement.

Lines 18-19 state that no credential is identified. The cuOpt quick-start requires an NGC API key for registry authentication. Update the credential metadata so consumers do not omit a required credential.

Proposed correction
-**Requires API Key or External Credential:** [Not Specified] <br>
-**Credential Type(s):** [None identified] <br>
+**Requires API Key or External Credential:** [Yes] <br>
+**Credential Type(s):** [NGC API key] <br>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
**Requires API Key or External Credential:** [Not Specified] <br>
**Credential Type(s):** [None identified] <br>
**Requires API Key or External Credential:** [Yes] <br>
**Credential Type(s):** [NGC API key] <br>
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/cuopt-user-rules/skill-card.md` around lines 18 - 19, Update the
credential metadata in the cuOpt skill card so it explicitly declares that an
NGC API key is required for registry authentication. Replace the unspecified
API-key requirement and “None identified” credential type with the appropriate
NGC API key information, preserving the existing metadata format.

| Security | 100% → 100% (±0 points) | 100% → 100% (±0 points) |
| Correctness | 80% → 100% (+20 points) | 20% → 100% (+80 points) |
| Discoverability | 50% → 100% (+50 points) | 44% → 94% (+50 points) |
| Effectiveness | 61% → 88% (+26 points) | 49% → 94% (+45 points) |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Correct the duplicated Claude Code effectiveness uplift.

Both publication artifacts report 61% → 88% (+26 points). The correct uplift is +27 percentage points.

  • skills/cuopt-user-rules/skill-card.md#L74-L74: change +26 points to +27 points.
  • skills/cuopt-user-rules/BENCHMARK.md#L41-L41: change +26 points to +27 points.
📍 Affects 2 files
  • skills/cuopt-user-rules/skill-card.md#L74-L74 (this comment)
  • skills/cuopt-user-rules/BENCHMARK.md#L41-L41
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/cuopt-user-rules/skill-card.md` at line 74, Correct the Claude Code
effectiveness uplift from “+26 points” to “+27 points” in
skills/cuopt-user-rules/skill-card.md lines 74-74 and
skills/cuopt-user-rules/BENCHMARK.md lines 41-41, keeping the surrounding
benchmark values unchanged.

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test a8d1cd0

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test ca45cea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants