chore: trigger NVSkills CI for cuopt-user-rules - #1679
Conversation
|
/nvskills-ci |
📝 WalkthroughWalkthroughUpdated the cuOpt user rules skill metadata, benchmark report, documentation spacing, and Sigstore/in-toto attestation. ChangescuOpt user rules publication refresh
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
CI Test Summary⏭️ All 5 test job(s) skipped. |
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-user-rules/skill-card.md`:
- Line 74: Correct the Claude Code effectiveness uplift from “+26 points” to
“+27 points” in skills/cuopt-user-rules/skill-card.md lines 74-74 and
skills/cuopt-user-rules/BENCHMARK.md lines 41-41, keeping the surrounding
benchmark values unchanged.
- Around line 18-19: Update the credential metadata in the cuOpt skill card so
it explicitly declares that an NGC API key is required for registry
authentication. Replace the unspecified API-key requirement and “None
identified” credential type with the appropriate NGC API key information,
preserving the existing metadata format.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: d44c87df-f0c1-4ba5-95e8-86b1f3385dc5
📒 Files selected for processing (3)
skills/cuopt-user-rules/BENCHMARK.mdskills/cuopt-user-rules/skill-card.mdskills/cuopt-user-rules/skill.oms.sig
| **Requires API Key or External Credential:** [Not Specified] <br> | ||
| **Credential Type(s):** [None identified] <br> |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Declare the NGC API key requirement.
Lines 18-19 state that no credential is identified. The cuOpt quick-start requires an NGC API key for registry authentication. Update the credential metadata so consumers do not omit a required credential.
Proposed correction
-**Requires API Key or External Credential:** [Not Specified] <br>
-**Credential Type(s):** [None identified] <br>
+**Requires API Key or External Credential:** [Yes] <br>
+**Credential Type(s):** [NGC API key] <br>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| **Requires API Key or External Credential:** [Not Specified] <br> | |
| **Credential Type(s):** [None identified] <br> | |
| **Requires API Key or External Credential:** [Yes] <br> | |
| **Credential Type(s):** [NGC API key] <br> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-user-rules/skill-card.md` around lines 18 - 19, Update the
credential metadata in the cuOpt skill card so it explicitly declares that an
NGC API key is required for registry authentication. Replace the unspecified
API-key requirement and “None identified” credential type with the appropriate
NGC API key information, preserving the existing metadata format.
| | Security | 100% → 100% (±0 points) | 100% → 100% (±0 points) | | ||
| | Correctness | 80% → 100% (+20 points) | 20% → 100% (+80 points) | | ||
| | Discoverability | 50% → 100% (+50 points) | 44% → 94% (+50 points) | | ||
| | Effectiveness | 61% → 88% (+26 points) | 49% → 94% (+45 points) | |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Correct the duplicated Claude Code effectiveness uplift.
Both publication artifacts report 61% → 88% (+26 points). The correct uplift is +27 percentage points.
skills/cuopt-user-rules/skill-card.md#L74-L74: change+26 pointsto+27 points.skills/cuopt-user-rules/BENCHMARK.md#L41-L41: change+26 pointsto+27 points.
📍 Affects 2 files
skills/cuopt-user-rules/skill-card.md#L74-L74(this comment)skills/cuopt-user-rules/BENCHMARK.md#L41-L41
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-user-rules/skill-card.md` at line 74, Correct the Claude Code
effectiveness uplift from “+26 points” to “+27 points” in
skills/cuopt-user-rules/skill-card.md lines 74-74 and
skills/cuopt-user-rules/BENCHMARK.md lines 41-41, keeping the surrounding
benchmark values unchanged.
|
/ok to test a8d1cd0 |
|
/ok to test ca45cea |
Trivial blank-line addition after SKILL.md frontmatter to trigger NVSkills CI — fetch updated skill card and benchmark for
cuopt-user-rules.