fix(api): handle rows.Err() and uuid.Parse errors in libsql repositories

- Add rows.Err() check after iteration loop in Index to catch
  network errors or timeouts that silently end iteration
- Propagate uuid.Parse errors in scanHeartbeat and scanHeartbeatRow
  instead of discarding them with _
- Propagate uuid.Parse errors in scanHeartbeatMonitorRow for both
  monitor ID and phone ID fields

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: AchoArnold

api/pkg/repositories/libsql_heartbeat_monitor_repository.go

@@ -185,8 +185,14 @@ func scanHeartbeatMonitorRow(row *sql.Row) (*entities.HeartbeatMonitor, error) {
 	if err != nil {
 		return nil, err
 	}
-	monitor.ID, _ = uuid.Parse(id)
-	monitor.PhoneID, _ = uuid.Parse(phoneID)
+	monitor.ID, err = uuid.Parse(id)
+	if err != nil {
+		return nil, stacktrace.Propagate(err, fmt.Sprintf("cannot parse heartbeat monitor ID [%s]", id))
+	}
+	monitor.PhoneID, err = uuid.Parse(phoneID)
+	if err != nil {
+		return nil, stacktrace.Propagate(err, fmt.Sprintf("cannot parse heartbeat monitor phone ID [%s]", phoneID))
+	}
 	monitor.UserID = entities.UserID(userID)
 	monitor.PhoneOnline = phoneOnline != 0
 	return monitor, nil

api/pkg/repositories/libsql_heartbeat_repository.go

@@ -33,9 +33,11 @@ func NewLibsqlHeartbeatRepository(
 }
 
 func (repository *libsqlHeartbeatRepository) Store(ctx context.Context, heartbeat *entities.Heartbeat) error {
-	ctx, span := repository.tracer.Start(ctx)
+	ctx, span, ctxLogger := repository.tracer.StartWithLogger(ctx, repository.logger)
 	defer span.End()
 
+	ctxLogger.Trace("saving new heartbeat")
+
 	ctx, cancel := context.WithTimeout(ctx, dbOperationDuration)
 	defer cancel()
 
@@ -93,6 +95,10 @@ func (repository *libsqlHeartbeatRepository) Index(ctx context.Context, userID e
 		}
 		heartbeats = append(heartbeats, *heartbeat)
 	}
+	if rowsErr := rows.Err(); rowsErr != nil {
+		msg := fmt.Sprintf("error iterating heartbeat rows for owner [%s]", owner)
+		return nil, repository.tracer.WrapErrorSpan(span, stacktrace.Propagate(rowsErr, msg))
+	}
 
 	return &heartbeats, nil
 }
@@ -147,7 +153,10 @@ func scanHeartbeat(rows *sql.Rows) (*entities.Heartbeat, error) {
 	if err != nil {
 		return nil, err
 	}
-	heartbeat.ID, _ = uuid.Parse(id)
+	heartbeat.ID, err = uuid.Parse(id)
+	if err != nil {
+		return nil, stacktrace.Propagate(err, fmt.Sprintf("cannot parse heartbeat ID [%s]", id))
+	}
 	heartbeat.Charging = charging != 0
 	heartbeat.UserID = entities.UserID(userID)
 	return heartbeat, nil
@@ -162,7 +171,10 @@ func scanHeartbeatRow(row *sql.Row) (*entities.Heartbeat, error) {
 	if err != nil {
 		return nil, err
 	}
-	heartbeat.ID, _ = uuid.Parse(id)
+	heartbeat.ID, err = uuid.Parse(id)
+	if err != nil {
+		return nil, stacktrace.Propagate(err, fmt.Sprintf("cannot parse heartbeat ID [%s]", id))
+	}
 	heartbeat.Charging = charging != 0
 	heartbeat.UserID = entities.UserID(userID)
 	return heartbeat, nil