From fe4ddb8d15114a954050797743b692be9ce2aba2 Mon Sep 17 00:00:00 2001 From: William Moses Date: Mon, 16 Nov 2026 22:24:54 +0000 Subject: [PATCH] Keep the Docker image public Drop the note about registry authentication and make the workflow fail if the published image cannot be pulled anonymously. --- .github/workflows/docker.yml | 16 ++++++++++++++++ README.md | 3 +-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 3ef1097..cf70c7b 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -78,3 +78,19 @@ jobs: outputs: type=image,compression=zstd,compression-level=3,force-compression=true,oci-mediatypes=true # No GitHub Actions cache: the image exceeds the 10 GB GHA cache cap. The persistent # runner keeps BuildKit's local layer cache between builds. + + # The artifact instructions pull this image without credentials, so fail if the + # package is not public. Visibility is set in the package settings on GitHub. + - name: Check that the image is public + if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository + env: + IMAGE: ${{ fromJSON(steps.meta.outputs.json).tags[0] }} + run: | + # An empty Docker configuration has no registry login. + DOCKER_CONFIG=$(mktemp -d) + export DOCKER_CONFIG + if ! docker manifest inspect "$IMAGE" > /dev/null; then + echo "::error::$IMAGE cannot be pulled anonymously. Make the package public: https://github.com/orgs/${GITHUB_REPOSITORY_OWNER}/packages/container/${GITHUB_REPOSITORY#*/}/settings" + exit 1 + fi + echo "$IMAGE is publicly readable." diff --git a/README.md b/README.md index e5aafd2..02ceb5d 100644 --- a/README.md +++ b/README.md @@ -37,8 +37,7 @@ bash docker/run.sh polybench_cpu --cases gemm --target host --size MINI --output ``` The smoke test takes approximately 1–5 minutes and compares every output of -native and raised GEMM. If the registry requires authentication, use an -account with package access or +native and raised GEMM. To use other sources, [build the image locally](#building-and-publishing-docker-images). `docker/run.sh` accepts the same suites and options as `reproduce.py`. In the