Skip to content

Bug in loading dimensions on UGrids for WindowedArrays #2757

Description

@erikvansebille

Parcels version

v4

Description

Yesterday I implemented explicit loading of lon/lat and (if available) depth in to_windowed_arrays() in #2752; but I now realise that this breaks for UGrids - because these don't have lon and lat. That's an easy fix that I will push a PR for soon

However, I now also realise that we don't have any unit tests WindowedArrays for UGrids (which is why I didn't catch it). @fluidnumericsJoe or @wyatt-fluidnumerics, could you perhaps add these unit tests to test_windowed_array.py?

Code sample

Metadata

Metadata

Labels

bugneeds-triageIssue that has not been reviewed by a Parcels team member

Type

No type

Fields

No fields configured for issues without a type.

Projects

Status
Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions