Improve test coverage for BatchEdaController

Add tests for: applying all EDA fields at once, custom redirect URL,
and verifying unchecked fields are skipped.

Author: Sebbeben

tests/Controller/BatchEdaControllerTest.php

@@ -22,7 +22,9 @@
 
 namespace App\Tests\Controller;
 
+use App\Entity\Parts\Part;
 use App\Entity\UserSystem\User;
+use Doctrine\ORM\EntityManagerInterface;
 use PHPUnit\Framework\Attributes\Group;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 
@@ -48,7 +50,6 @@ public function testBatchEdaPageLoads(): void
         $client = static::createClient();
         $this->loginAsUser($client, 'admin');
 
-        // Request with part IDs as comma-separated string (controller uses getString)
         $client->request('GET', '/en/tools/batch_eda_edit', ['ids' => '1,2,3']);
 
         self::assertResponseIsSuccessful();
@@ -59,30 +60,135 @@ public function testBatchEdaPageWithoutPartsRedirects(): void
         $client = static::createClient();
         $this->loginAsUser($client, 'admin');
 
-        // Request without part IDs should redirect
         $client->request('GET', '/en/tools/batch_eda_edit');
 
         self::assertResponseRedirects();
     }
 
+    public function testBatchEdaPageWithoutPartsRedirectsToCustomUrl(): void
+    {
+        $client = static::createClient();
+        $this->loginAsUser($client, 'admin');
+
+        // Empty IDs with a custom redirect URL
+        $client->request('GET', '/en/tools/batch_eda_edit', [
+            'ids' => '',
+            '_redirect' => '/en/parts',
+        ]);
+
+        self::assertResponseRedirects('/en/parts');
+    }
+
     public function testBatchEdaFormSubmission(): void
     {
         $client = static::createClient();
         $this->loginAsUser($client, 'admin');
 
-        // Load the form page first
         $crawler = $client->request('GET', '/en/tools/batch_eda_edit', ['ids' => '1,2']);
 
         self::assertResponseIsSuccessful();
 
-        // Find the form and submit it with reference prefix applied
         $form = $crawler->selectButton('batch_eda[submit]')->form();
         $form['batch_eda[apply_reference_prefix]'] = true;
         $form['batch_eda[reference_prefix]'] = 'R';
 
         $client->submit($form);
 
-        // Should redirect after successful submission
         self::assertResponseRedirects();
     }
+
+    public function testBatchEdaFormSubmissionAppliesAllFields(): void
+    {
+        $client = static::createClient();
+        $this->loginAsUser($client, 'admin');
+
+        $crawler = $client->request('GET', '/en/tools/batch_eda_edit', ['ids' => '1,2']);
+        self::assertResponseIsSuccessful();
+
+        $form = $crawler->selectButton('batch_eda[submit]')->form();
+
+        // Apply all text fields
+        $form['batch_eda[apply_reference_prefix]'] = true;
+        $form['batch_eda[reference_prefix]'] = 'C';
+        $form['batch_eda[apply_value]'] = true;
+        $form['batch_eda[value]'] = '100nF';
+        $form['batch_eda[apply_kicad_symbol]'] = true;
+        $form['batch_eda[kicad_symbol]'] = 'Device:C';
+        $form['batch_eda[apply_kicad_footprint]'] = true;
+        $form['batch_eda[kicad_footprint]'] = 'Capacitor_SMD:C_0402';
+
+        // Apply all tri-state checkboxes
+        $form['batch_eda[apply_visibility]'] = true;
+        $form['batch_eda[apply_exclude_from_bom]'] = true;
+        $form['batch_eda[apply_exclude_from_board]'] = true;
+        $form['batch_eda[apply_exclude_from_sim]'] = true;
+
+        $client->submit($form);
+
+        self::assertResponseRedirects();
+
+        // Verify the changes were actually persisted
+        $em = $client->getContainer()->get('doctrine')->getManager();
+        $part1 = $em->find(Part::class, 1);
+        $part2 = $em->find(Part::class, 2);
+
+        self::assertSame('C', $part1->getEdaInfo()->getReferencePrefix());
+        self::assertSame('100nF', $part1->getEdaInfo()->getValue());
+        self::assertSame('Device:C', $part1->getEdaInfo()->getKicadSymbol());
+        self::assertSame('Capacitor_SMD:C_0402', $part1->getEdaInfo()->getKicadFootprint());
+
+        self::assertSame('C', $part2->getEdaInfo()->getReferencePrefix());
+        self::assertSame('100nF', $part2->getEdaInfo()->getValue());
+    }
+
+    public function testBatchEdaFormSubmissionWithRedirectUrl(): void
+    {
+        $client = static::createClient();
+        $this->loginAsUser($client, 'admin');
+
+        $crawler = $client->request('GET', '/en/tools/batch_eda_edit', [
+            'ids' => '1',
+            '_redirect' => '/en/parts',
+        ]);
+        self::assertResponseIsSuccessful();
+
+        $form = $crawler->selectButton('batch_eda[submit]')->form();
+        $form['batch_eda[apply_reference_prefix]'] = true;
+        $form['batch_eda[reference_prefix]'] = 'U';
+
+        $client->submit($form);
+
+        // Should redirect to the custom URL, not the default route
+        self::assertResponseRedirects('/en/parts');
+    }
+
+    public function testBatchEdaFormSkipsUncheckedFields(): void
+    {
+        $client = static::createClient();
+        $this->loginAsUser($client, 'admin');
+
+        // First, set a known value
+        $em = $client->getContainer()->get('doctrine')->getManager();
+        $part = $em->find(Part::class, 3);
+        $part->getEdaInfo()->setReferencePrefix('ORIGINAL');
+        $em->flush();
+
+        $crawler = $client->request('GET', '/en/tools/batch_eda_edit', ['ids' => '3']);
+        self::assertResponseIsSuccessful();
+
+        $form = $crawler->selectButton('batch_eda[submit]')->form();
+        // Only apply value, NOT reference_prefix
+        $form['batch_eda[apply_value]'] = true;
+        $form['batch_eda[value]'] = 'NewValue';
+        // Explicitly leave apply_reference_prefix unchecked (default)
+
+        $client->submit($form);
+        self::assertResponseRedirects();
+
+        // Refresh entity
+        $em->clear();
+        $part = $em->find(Part::class, 3);
+        self::assertSame('ORIGINAL', $part->getEdaInfo()->getReferencePrefix());
+        self::assertSame('NewValue', $part->getEdaInfo()->getValue());
+    }
 }