bump deploy action version; ~~remove unused~~__add note to__ build.yml#133
Merged
bump deploy action version; ~~remove unused~~__add note to__ build.yml#133
Conversation
AritraDey-Dev
approved these changes
Jan 13, 2026
Member
AritraDey-Dev
left a comment
AritraDey-Dev
left a comment
There was a problem hiding this comment.
Apart from the above suggestion, LGTM.
Member
|
But now there is another issue: by removing the build workflow for each PR, the CI check (i.e., |
Member
Author
|
Good catch! I'll revert the deletion. |
infotroph
force-pushed
the
bump-deploy
branch
from
c2faac7 to
55f60aa
Compare
infotroph
changed the title
AritraDey-Dev
approved these changes
Jan 13, 2026
Member
AritraDey-Dev
left a comment
AritraDey-Dev
left a comment
There was a problem hiding this comment.
I believe there is definitely a way to consolidate this into a single workflow that only runs a build for a PR, and runs both build and deploy after a push. Currently, #123 already exists to handle this, but it has been on my list for a long time. Will try to finish that work soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Slack