Skip to content

Revert "Merge pull request #188 from PolyMC/removal/notifications"#535

Closed
d-513 wants to merge 2 commits into
PolyMC:developfrom
d-513:notifs
Closed

Revert "Merge pull request #188 from PolyMC/removal/notifications"#535
d-513 wants to merge 2 commits into
PolyMC:developfrom
d-513:notifs

Conversation

@d-513

@d-513 d-513 commented May 8, 2022

Copy link
Copy Markdown
Contributor

This reverts commit 5b8003c, reversing
changes made to c071910.

Readds notification system because it can be useful.
Needs PolyMC/files#1

dada513 added 2 commits May 8, 2022 17:39
@Scrumplex

Copy link
Copy Markdown
Contributor

What's wrong with using news? We are going to create a news post about version 1.2.2 anyway. Imo this is just duplicate functionality.

@d-513

d-513 commented May 8, 2022

Copy link
Copy Markdown
Contributor Author

What's wrong with using news? We are going to create a news post about version 1.2.2 anyway. Imo this is just duplicate functionality.

Imo it's more visible, but idk

@d-513

d-513 commented May 8, 2022

Copy link
Copy Markdown
Contributor Author

Also news don't have to have Werid attention grabbing names "IMPORTANT:"

@flowln

flowln commented May 8, 2022

Copy link
Copy Markdown
Contributor

I think the best thing would be to integrate some things of the notification system, like type of news or 'unread news', in the news system. Like dada said, the current system isn't really good at communicating notices to the users, so its impact is pretty minimal to the normal user imo

@d-513

d-513 commented May 8, 2022

Copy link
Copy Markdown
Contributor Author

@txtsd wtf is happening with CI, you should add a timeout :/

@txtsd

txtsd commented May 17, 2022

Copy link
Copy Markdown
Contributor

@txtsd wtf is happening with CI, you should add a timeout :/

What was this about?

@d-513

d-513 commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

@txtsd wtf is happening with CI, you should add a timeout :/

What was this about?

Lmao the cache was running for 12hours

@txtsd

txtsd commented May 17, 2022

Copy link
Copy Markdown
Contributor

Which build was it on? Windows uses a different action than the others. I'll file an issue upstream.

@d-513

d-513 commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

Which build was it on? Windows uses a different action than the others. I'll file an issue upstream.

Windows. But rebuild fixed it. And it was only one of the builds. Looks like GHA died because it had retrieved 98% of cache and was stuck

@flowln

flowln commented May 26, 2022

Copy link
Copy Markdown
Contributor

hmm will this be done in the end? I think we should focus on improving the news system rather than having the two systems, it's less awkward like that imo

@d-513 d-513 closed this May 27, 2022
@d-513 d-513 deleted the notifs branch May 27, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants