Consolidate get_post_types_names() helper #433
Description
Currently we are changing a lot of things related to content tracking & tasks.
In conversation with @aristath we mentioned that Content_Helpers class will probably be remove as not needed anymore.
In parallel we are adding valuable content settings and tasks in following PRs:
- Change 'Create a post' task to 'Create valuable content #428
- Add setting to determine which post types are considered 'valuable content' #430
- [Recommendation] Add task to complete 'valuable post type' setting #432
For now I have copied Content_Helpers::get_post_names() to class-settings.php in one of the branches so that helper is not removed if Content_Helpers is deleted, but we should find a better place for it once refactor is done (and also use it in all above PRs consistently).
Using just \progress_planner()->get_settings()->get( [ 'include_post_types' ], [ 'post', 'page'] ) gets the saved value properly, but since CPT properties (like public) can be changed dynamically I think it's better to have a helper in place which filters out CPTs which are no longer eligible.