Skip to content

[Colab button] Remove .myst suffix for notebooks launcher #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kp992 merged 2 commits into from
Jun 12, 2025
Merged

[Colab button] Remove .myst suffix for notebooks launcher #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3a0434
remove `.myst` suffix for notebooks launcher
kp992 Jun 6, 2025
6e39113
add changeset
kp992 Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/seven-views-pull.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@curvenote/quantecon-book": patch
---

Fix colab link for lecture repo ending with .myst
5 changes: 4 additions & 1 deletion app/components/toolbar/LaunchButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ function LaunchPanel() {
const [privateServiceUrl, setPrivateServiceUrl] = React.useState<string | undefined>();

const hasGitHub = !!project?.github;
const orgRepo = project?.github ? new URL(project?.github).pathname.slice(1) : undefined;
// Remove the `.myst` suffix from the orgRepo URL if present.
const orgRepo = project?.github
? new URL(project?.github).pathname.slice(1).replace(/\.myst$/, '')
: undefined;
const filename = `${page?.location.split('.')[0]}.ipynb`;

const handleSelect = React.useCallback((value: string) => setService(value), []);
Expand Down