[Issue]: Build warnings `#pragma clang diagnostic ignored "-Wlifetime-safety-intra-tu-suggestions"`

[kapilsh]

Problem Description

Hi, I am from the PyTorch team at Meta. we are seeing 1000s of these warnings in PyTorch CI. Wanted to flag this so these can be resolved.

see: https://github.com/pytorch/pytorch/actions/runs/25757667945/job/75670246754?pr=183423 for example

Operating System

Ubuntu 22.04 ("jammy")

CPU

AWS EC2 C7i instance (Intel Xeon Sapphire Rapids, x86_64)

GPU

AMD Instinct MI300A

Other

GPU targets : gfx90a;gfx942;gfx950;gfx1100

ROCm Version

ROCm 6.0.0

ROCm Component

No response

Steps to Reproduce

see: https://github.com/pytorch/pytorch/actions/runs/25757667945/job/75670246754?pr=183423 for example

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

[kapilsh]

Other details: Compiler / toolchain: gcc 13.4.0 (Ubuntu) for C++ host code, /opt/rocm/lib/llvm/bin/clang++ for HIP, ROCm 7.2.1 (ROCM_VERSION=70201, TORCH_HIP_VERSION=702).

[illsilin]

Yeah, we started hitting a lot of these warnings in clang23, so those pragmas are trying to suppress them.
We can add a filter to apply those pragmas only for clang versions >=23.

[illsilin]

It looks like the problem is that we've always used -DCMAKE_CXX_COMPILER=/opt/rocm/llvm/bin/clang++ as the c++ compiler, while TheRock is using gcc. I wasn't able to reproduce those warnings even with much older rocm versions, like rocm6.4 as long as i used clang.

[illsilin]

I've added another precompiler instruction
#pragma clang diagnostic ignored "-Wno-unknown-warning-option"
to ignore unknown flags.
Hopefully this will make all that rubbish output in the logs go away.