From b7e46d9f9607dba631beddcbce0356cc46a90f3e Mon Sep 17 00:00:00 2001 From: Arshil Ahmed Date: Mon, 16 Nov 2026 05:01:34 +0530 Subject: [PATCH] fix(layout-editor): keep mode requests like "change it to dark" in theme refinements --- .../src/lib/generateThemeFromColor.test.js | 16 ++++++++++++++++ .../src/lib/themeGenerationService.js | 9 +++++---- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/packages/layout_editor/src/lib/generateThemeFromColor.test.js b/packages/layout_editor/src/lib/generateThemeFromColor.test.js index 5c3ba44be..762776ad7 100644 --- a/packages/layout_editor/src/lib/generateThemeFromColor.test.js +++ b/packages/layout_editor/src/lib/generateThemeFromColor.test.js @@ -223,6 +223,22 @@ test('an explicit light or dark mode refinement overrides an adapter response', ); }); +test('mode refinements without the word mode or theme are kept', () => { + [ + ['Switch it to dark', 'dark'], + ['Change it to dark', 'dark'], + ['Set it to dark', 'dark'], + ['Turn it to light', 'light'], + ['Change to light', 'light'], + ].forEach(([request, mode]) => { + assert.deepEqual( + limitRefinementSuggestion({ primaryHex: '#ef4444' }, request), + { mode }, + request + ); + }); +}); + test('explicit corner and font refinements override an adapter response', () => { assert.deepEqual( limitRefinementSuggestion( diff --git a/packages/layout_editor/src/lib/themeGenerationService.js b/packages/layout_editor/src/lib/themeGenerationService.js index 970a1e97d..8405d23fa 100644 --- a/packages/layout_editor/src/lib/themeGenerationService.js +++ b/packages/layout_editor/src/lib/themeGenerationService.js @@ -67,11 +67,12 @@ const inferFontFamily = (description) => { return undefined; }; +// "switch to dark", "change it to light", "set it to dark", ... +const MODE_REQUEST = /\b(?:switch|change|set|turn)\s+(?:it\s+)?to\s+(light|dark)\b/; + const inferMode = (description) => { const prompt = description.toLowerCase(); - const requestedMode = prompt.match( - /\b(?:switch|change|set|turn)\s+(?:it\s+)?to\s+(light|dark)\b/ - ); + const requestedMode = prompt.match(MODE_REQUEST); if (requestedMode) return requestedMode[1]; const namedThemeMode = prompt.match(/\b(light|dark)\s+(?:mode|theme)\b/); @@ -125,7 +126,7 @@ const requestedRefinementFields = (description) => { inferFontFamily(description) || /\b(font|typeface|typography)\b/.test(prompt) ) fields.add('fontFamily'); - if (/\b(dark|light)\s+(mode|theme)\b|\bswitch\s+to\s+(dark|light)\b/.test(prompt)) { + if (/\b(dark|light)\s+(mode|theme)\b/.test(prompt) || MODE_REQUEST.test(prompt)) { fields.add('mode'); } if (/\b(message view|message type|bubble|flat)\b/.test(prompt)) {