Skip to content

Fix conditional logic in daily_trading_bot GitHub Actions workflow#68

Merged
Rohan5commit merged 1 commit into
mainfrom
codex/handoff-prompt-for-next-agent-to-continue-work
May 23, 2026
Merged

Fix conditional logic in daily_trading_bot GitHub Actions workflow#68
Rohan5commit merged 1 commit into
mainfrom
codex/handoff-prompt-for-next-agent-to-continue-work

Conversation

@Rohan5commit
Copy link
Copy Markdown
Owner

Motivation

  • Correct mis-grouped if expressions that could prevent AI-related steps from running for non-dispatch runs or when workflow_dispatch inputs indicate AI should run.
  • Ensure steps that depend on whether the run is a manual dispatch or not, and whether disable_ai_trading/run_in_lightning_studio inputs are set, evaluate as intended.

Description

  • Normalized multiple if condition expressions in .github/workflows/daily_trading_bot.yml to use ((github.event_name != 'workflow_dispatch') || !inputs.disable_ai_trading) where appropriate instead of the previous (github.event_name == 'workflow_dispatch' && !inputs.disable_ai_trading) grouping.
  • Adjusted surrounding parentheses and boolean grouping to ensure !(github.event_name == 'workflow_dispatch' && inputs.run_in_lightning_studio) combines correctly with the new dispatch/non-dispatch checks.
  • Applied the conditional fix across all AI/runtime-related steps including install_lightning_deps, plan_ai_runtime, validate_cerebrium_primary_config, enforce_ai_routing_invariants, warm/verify Cerebrium steps, AI run/retry steps, Lightning studio steps, distilled fallback and failure report steps.
  • No other behavior or environment variables were changed beyond the if expressions.

Testing

  • No automated tests were run against this workflow change in this PR.
  • Changes are syntactic logic adjustments to GitHub Actions if expressions and will be validated by the Actions runner on next workflow execution.

Codex Task

@Rohan5commit Rohan5commit merged commit e621dd6 into main May 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant