Fix conditional logic in daily_trading_bot GitHub Actions workflow#68
Merged
Rohan5commit merged 1 commit intoMay 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ifexpressions that could prevent AI-related steps from running for non-dispatch runs or whenworkflow_dispatchinputs indicate AI should run.disable_ai_trading/run_in_lightning_studioinputs are set, evaluate as intended.Description
ifcondition expressions in.github/workflows/daily_trading_bot.ymlto use((github.event_name != 'workflow_dispatch') || !inputs.disable_ai_trading)where appropriate instead of the previous(github.event_name == 'workflow_dispatch' && !inputs.disable_ai_trading)grouping.!(github.event_name == 'workflow_dispatch' && inputs.run_in_lightning_studio)combines correctly with the new dispatch/non-dispatch checks.install_lightning_deps,plan_ai_runtime,validate_cerebrium_primary_config,enforce_ai_routing_invariants, warm/verify Cerebrium steps, AI run/retry steps, Lightning studio steps, distilled fallback and failure report steps.ifexpressions.Testing
ifexpressions and will be validated by the Actions runner on next workflow execution.Codex Task