This code:
pr_warn!(
"{}:{} transaction to {} failed: {source:?}",
info.from_pid,
info.from_tid,
info.to_pid,
);results in this error:
error: expected expression, found `,`
--> linux/drivers/android/binder/thread.rs:1257:21
|
1257 | "{}:{} transaction to {} failed: {source:?}",
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected expression
Because of the trailing comma after info.to_pid. This should be fixed so that trailing commas are allowed. I think the problem is in the fmt! proc macro, which is defined in rust/macros/fmt.rs.
This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes (including generating the documentation if changed, running the Rust doctests if changed, etc.), to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a Suggested-by: tag, and a Link: tag to this issue. Please see https://docs.kernel.org/process/submitting-patches.html and https://rust-for-linux.com/contributing for details.
This code:
results in this error:
Because of the trailing comma after
info.to_pid. This should be fixed so that trailing commas are allowed. I think the problem is in thefmt!proc macro, which is defined inrust/macros/fmt.rs.This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes (including generating the documentation if changed, running the Rust doctests if changed, etc.), to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a
Suggested-by:tag, and aLink:tag to this issue. Please see https://docs.kernel.org/process/submitting-patches.html and https://rust-for-linux.com/contributing for details.