Queued
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report
Test suite run success3806 tests passing in 1462 suites. Report generated by 🧪jest coverage report action from 17c3266 |
dmerand
reviewed
Mar 12, 2026
Contributor
dmerand
left a comment
dmerand
left a comment
There was a problem hiding this comment.
There may be a couple of existing feature tests that we should implement before removing (mostly so we don't forget to reimplement) -- WDYT?
Review assisted by pair-review
Contributor
There was a problem hiding this comment.
(Ref Line 204) Note that we should make a plan for activating the E2E tests as blocking.
Contributor
Author
|
@dmerand I've got a pr incoming on top of this to add tests for action SHA and command graph snapshot. |
5 tasks
isaacroldan
approved these changes
Mar 13, 2026
The packages/features Cucumber test suite has been replaced by the Playwright-based e2e tests in packages/e2e. This removes the entire Cucumber infrastructure: - Delete packages/features (feature files, step definitions, world setup, helpers, snapshots, and config) - Remove test:features and test:regenerate-snapshots scripts - Remove acceptance-tests CI job from PR workflow - Remove acceptance test steps from main and manual workflows - Remove features package from knip config and ESLint overrides - Update testing strategy docs to reference e2e tests Active cucumber scenarios to consider migrating to e2e in a followup: - App scaffold + build (react-router and extension-only apps) - CLI command snapshot validation - GitHub Actions pinning check - Shared node dependency version sync Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Distinguish between `pnpm test` (Vitest unit tests) and `pnpm test:e2e` (Playwright end-to-end suite) so contributors know how to exercise the full test suite. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ryancbahan
force-pushed
the
delete-cucumber
branch
from
d594292 to
17c3266
Compare
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: I will update the branch protection rules to remove cucumber tests once the pr is approved, to reduce diff in time where rules are disabled for actively running infra.
Summary
packages/featuresCucumber test suite, which has been superseded by the Playwright-based e2e tests inpackages/e2epackage.jsonscripts (test:features,test:regenerate-snapshots), knip config, and ESLint overridesCucumber scenarios to migrate to e2e (followup)
The following active scenarios should be considered for migration to the Playwright e2e suite:
Test plan
pnpm-lock.yamlregenerated cleanlypackage.jsonvalidates as valid JSON@shopify/features,cucumber, ortest:featuresin code🤖 Generated with Claude Code