STAC-23466 Proper check for global backup enabled

rb3ckers · rb3ckers · commit ea5fbd8bdf03 · 2026-02-26T10:04:22.000+01:00
diff --git a/internal/foundation/config/config.go b/internal/foundation/config/config.go
@@ -38,7 +38,7 @@ func (c *Config) StorageEnabled() bool {
 	if c.IsLegacyMode() {
 		return c.Minio.Enabled
 	}
-	return c.Storage.Service.Name != ""
+	return c.Storage.GlobalBackupEnabled
 }
 
 // GetStorageService returns the service config for the S3-compatible storage,
@@ -128,9 +128,10 @@ type MinioConfig struct {
 
 // StorageConfig holds S3-compatible storage configuration (new mode, replaces Minio)
 type StorageConfig struct {
-	Service   ServiceConfig `yaml:"service" validate:"omitempty"`
-	AccessKey string        `yaml:"accessKey"` // From secret
-	SecretKey string        `yaml:"secretKey"` // From secret
+	GlobalBackupEnabled bool          `yaml:"globalBackupEnabled" validate:"boolean"`
+	Service             ServiceConfig `yaml:"service" validate:"omitempty"`
+	AccessKey           string        `yaml:"accessKey"` // From secret
+	SecretKey           string        `yaml:"secretKey"` // From secret
 }
 
 // StackgraphConfig holds Stackgraph backup-specific configuration

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ func (c *Config) StorageEnabled() bool {`
`38`	`38`	`if c.IsLegacyMode() {`
`39`	`39`	`return c.Minio.Enabled`
`40`	`40`	`}`
`41`		`- return c.Storage.Service.Name != ""`
	`41`	`+ return c.Storage.GlobalBackupEnabled`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`// GetStorageService returns the service config for the S3-compatible storage,`
`@@ -128,9 +128,10 @@ type MinioConfig struct {`
`128`	`128`
`129`	`129`	`// StorageConfig holds S3-compatible storage configuration (new mode, replaces Minio)`
`130`	`130`	`type StorageConfig struct {`
`131`		- Service ServiceConfig `yaml:"service" validate:"omitempty"`
`132`		- AccessKey string `yaml:"accessKey"` // From secret
`133`		- SecretKey string `yaml:"secretKey"` // From secret
	`131`	+ GlobalBackupEnabled bool `yaml:"globalBackupEnabled" validate:"boolean"`
	`132`	+ Service ServiceConfig `yaml:"service" validate:"omitempty"`
	`133`	+ AccessKey string `yaml:"accessKey"` // From secret
	`134`	+ SecretKey string `yaml:"secretKey"` // From secret
`134`	`135`	`}`
`135`	`136`
`136`	`137`	`// StackgraphConfig holds Stackgraph backup-specific configuration`