test(svelte-query/createQuery): replace 'Promise.resolve' with 'sleep' in render-based 'queryFn'#10903
Conversation
…' in render-based 'queryFn'
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR modifies ChangesQuery Timing and Async Behavior
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 175977d
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
size-limit report 📦
|
🎯 Changes
Replace immediate
Promise.resolve(...)withsleep(10).then(() => ...)in thequeryFnof render-based tests increateQuery.svelte.test.ts, and adjust the correspondingvi.advanceTimersByTimeAsync(...)values to advance by the same10ms thequeryFnnow sleeps for.This makes these tests resolve their data through a fake timer like the rest of the suite, instead of resolving synchronously, keeping the timing model consistent across the file.
✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit