From b3dbc06068f6b744083d28c74f314f9f07ba41e7 Mon Sep 17 00:00:00 2001 From: Sharad Chandran R Date: Wed, 2 Sep 2026 14:30:54 +0530 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=A4=96=20Merge=20PR=20#75448=20oracle?= =?UTF-8?q?db:=20correct=20the=20type=20of=20regid=20of=20the=20result=20o?= =?UTF-8?q?bject=20from=20subscription=20object=20from=20string=20to=20num?= =?UTF-8?q?ber=20by=20@sharadraju?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- types/oracledb/index.d.ts | 2 +- types/oracledb/oracledb-tests.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/types/oracledb/index.d.ts b/types/oracledb/index.d.ts index fd83bd5dc094e9..3334d6be7ad436 100644 --- a/types/oracledb/index.d.ts +++ b/types/oracledb/index.d.ts @@ -2071,7 +2071,7 @@ declare namespace OracleDB { * * For advanced queue SUBSCR_NAMESPACE_AQ subscriptions, regId is undefined. */ - regId?: string | undefined; + regId?: number | undefined; } /** diff --git a/types/oracledb/oracledb-tests.ts b/types/oracledb/oracledb-tests.ts index 6d99745ea991b9..67b4f1bf7c45c1 100644 --- a/types/oracledb/oracledb-tests.ts +++ b/types/oracledb/oracledb-tests.ts @@ -476,6 +476,7 @@ const version4Tests = async () => { }, }); + expectType(sub.regId); console.log(sub.regId); const queue = await connection.getQueue("test", { From 716d0464703b342aaebc4fa564d848302d8aee9d Mon Sep 17 00:00:00 2001 From: Daniel Hensby Date: Wed, 2 Sep 2026 11:57:09 +0100 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=A4=96=20Merge=20PR=20#75443=20[ssh2]?= =?UTF-8?q?=20Add=20missing=20term=20property=20to=20PseudoTtyInfo=20by=20?= =?UTF-8?q?@dhensby?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Patrick Kilgore --- types/ssh2/index.d.ts | 2 ++ types/ssh2/ssh2-tests.ts | 10 ++++++++++ 2 files changed, 12 insertions(+) diff --git a/types/ssh2/index.d.ts b/types/ssh2/index.d.ts index 1b640f7b062df7..097ac283ef6fe0 100644 --- a/types/ssh2/index.d.ts +++ b/types/ssh2/index.d.ts @@ -1487,6 +1487,8 @@ export interface Session extends ServerChannel { } export interface PseudoTtyInfo { + /** The terminal type requested by the client for the pseudo-TTY (e.g. `"vt100"`). */ + term: string; /** The number of columns for the pseudo-TTY. */ cols: number; /** The number of rows for the pseudo-TTY. */ diff --git a/types/ssh2/ssh2-tests.ts b/types/ssh2/ssh2-tests.ts index 0e1e2e2c3ad53a..c9759988097e30 100644 --- a/types/ssh2/ssh2-tests.ts +++ b/types/ssh2/ssh2-tests.ts @@ -407,6 +407,16 @@ new ssh2.Server({ stream.exit(0); stream.end(); }); + session.once("pty", (accept, reject, info) => { + info.term; // $ExpectType string + info.cols; // $ExpectType number + info.rows; // $ExpectType number + info.width; // $ExpectType number + info.height; // $ExpectType number + info.modes; // $ExpectType TerminalModes + info.modes.VINTR; // $ExpectType number | undefined + accept?.(); + }); }); }).on("end", () => { console.log("Client disconnected");