Skip to content

Commit f9d4fa8

Browse files
chore: Rename editor asmdef files to match their assembly names (#4187)
* chore: Rename editor asmdef files to match their assembly names Clears PVP-130-1/PVP-130-2 (US-0038). The .meta files move with the asmdefs, so GUIDs are unchanged and GUID references keep resolving. The PVP-132-2 exemption for CodeGen follows the file to its new path; the stale PackageChecker entry is dropped. * chore: Add CHANGELOG entry for the asmdef filename rename
1 parent ca1608f commit f9d4fa8

10 files changed

Lines changed: 4 additions & 11 deletions

‎com.unity.netcode.gameobjects/CHANGELOG.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,17 @@ Additional documentation and release notes are available at [Multiplayer Documen
1515

1616
### Changed
1717

18+
- Renamed the Editor assembly definition files to match their assembly names. Assembly names and GUIDs are unchanged. (#4187)
19+
1820
### Deprecated
1921

2022
### Removed
2123

2224
### Fixed
2325

26+
- Fixed issue where a prefab added to a `NetworkPrefabsList` while a session was running was registered more than once and logged a duplicate `GlobalObjectIdHash` error. (#4184)
2427
- Issue where moving a `NetworkObject` into another scene made the clients that did not observe it log "Trying to synchronize NetworkObjectId but it was not spawned". The scene migration is now only sent to the clients that observe the `NetworkObject`. (#4176)
2528
- Issue where a `NetworkObject` that was moved into another scene while hidden from a client spawned in that client's active scene when it was shown with `NetworkShow`, instead of the scene it is in on the server. (#4176)
26-
- Fixed issue where a prefab added to a `NetworkPrefabsList` while a session was running was registered more than once and logged a duplicate `GlobalObjectIdHash` error. (#4184)
2729
- Fixed an issue where mixed authority nested `NetworkTransform` instances could stop child/nested instances from updating because an authoritative `NetworkTransform` (root or otherwise) would remove the `NetworkObject` from the update group, preventing non-authoritative instances from updating their state on the authority side. (#4169)
2830
- Issue where the hybrid mode `NetcodeConfig` validation messages were not interpolated, so they reported placeholders instead of the setting that was wrong. (#4144)
2931
- Issue where a hybrid mode session failed to start unless `NetcodeConfig.EnableClientServerBootstrap` was set to `DisableAutomaticBootstrap`. Netcode for GameObjects creates the world itself and no longer needs that setting changed. (#4144)

com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef renamed to com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.GameObjects.Editor.CodeGen.asmdef

File renamed without changes.

com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef.meta renamed to com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.GameObjects.Editor.CodeGen.asmdef.meta

File renamed without changes.

com.unity.netcode.gameobjects/Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef renamed to com.unity.netcode.gameobjects/Editor/PackageChecker/Unity.Netcode.GameObjects.PackageChecker.Editor.asmdef

File renamed without changes.

com.unity.netcode.gameobjects/Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef.meta renamed to com.unity.netcode.gameobjects/Editor/PackageChecker/Unity.Netcode.GameObjects.PackageChecker.Editor.asmdef.meta

File renamed without changes.

com.unity.netcode.gameobjects/Editor/Unity.Netcode.Editor.asmdef renamed to com.unity.netcode.gameobjects/Editor/Unity.Netcode.GameObjects.Editor.asmdef

File renamed without changes.

com.unity.netcode.gameobjects/Editor/Unity.Netcode.Editor.asmdef.meta renamed to com.unity.netcode.gameobjects/Editor/Unity.Netcode.GameObjects.Editor.asmdef.meta

File renamed without changes.

com.unity.netcode.gameobjects/Tests/Editor/Unity.Netcode.Editor.Tests.asmdef renamed to com.unity.netcode.gameobjects/Tests/Editor/Unity.Netcode.GameObjects.Editor.Tests.asmdef

File renamed without changes.

com.unity.netcode.gameobjects/Tests/Editor/Unity.Netcode.Editor.Tests.asmdef.meta renamed to com.unity.netcode.gameobjects/Tests/Editor/Unity.Netcode.GameObjects.Editor.Tests.asmdef.meta

File renamed without changes.

‎pvpExceptions.json‎

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,9 @@
55
"CHANGELOG.md: line 9: Unreleased section is not allowed for public release"
66
]
77
},
8-
"PVP-130-2": {
9-
"errors": [
10-
"Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.CodeGen",
11-
"Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.PackageChecker.Editor",
12-
"Editor/Unity.Netcode.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor",
13-
"Tests/Editor/Unity.Netcode.Editor.Tests.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.Tests"
14-
]
15-
},
168
"PVP-132-2": {
179
"errors": [
18-
"Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef: name of editor assembly should end with '.Editor'",
19-
"Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: name of editor assembly should end with '.Editor'"
10+
"Editor/CodeGen/Unity.Netcode.GameObjects.Editor.CodeGen.asmdef: name of editor assembly should end with '.Editor'"
2011
]
2112
}
2213
}

0 commit comments

Comments
 (0)