[CI] Add ruff python checker. NFC

Author: sbc100

.github/workflows/ci.yml

@@ -39,6 +39,7 @@ jobs:
         sudo ./llvm.sh ${LLVM_VERSION}
         sudo apt-get install clang-format clang-format-${LLVM_VERSION} clang-tidy-${LLVM_VERSION}
     - run: flake8
+    - run: ruff check
     - run: ./scripts/clang-format-diff.sh
     - name: clang-tidy
       run: |

.ruff.toml

@@ -0,0 +1,42 @@
+target-version = "py310"
+
+exclude = [
+  'third_party',
+  'test/lit/lit.cfg.py',
+  'test/spec/testsuite',
+]
+
+[lint]
+select = [
+  "ARG",
+  "ASYNC",
+  "B",
+  "C4",
+  "C90",
+  "COM",
+  "E",
+  "F",
+  "I",
+  "PERF",
+  "PIE",
+  "PL",
+  "UP",
+  "W",
+  "YTT",
+]
+
+ignore = [
+  "C901",
+  "B006",
+  "B011",
+  "B023",
+  "E501",
+  "PERF401",
+  "PLR0912",
+  "PLR0913",
+  "PLR0915",
+  "PLR2004",
+  "PLW0603",
+  "PLW1510",
+  "PLW2901",
+]

check.py

@@ -15,24 +15,19 @@
 # limitations under the License.
 
 import glob
+import io
 import os
+import queue
 import subprocess
 import sys
+import threading
 import unittest
 from collections import OrderedDict
 from concurrent.futures import ThreadPoolExecutor
-from pathlib import Path
-import queue
-import io
-import threading
 from functools import partial
+from pathlib import Path
 
-from scripts.test import binaryenjs
-from scripts.test import lld
-from scripts.test import shared
-from scripts.test import support
-from scripts.test import wasm2js
-from scripts.test import wasm_opt
+from scripts.test import binaryenjs, lld, shared, support, wasm2js, wasm_opt
 
 
 def get_changelog_version():
@@ -55,7 +50,7 @@ def run_version_tests():
                    not any(f.endswith(s) for s in not_executable_suffix) and
                    any(os.path.basename(f).startswith(s) for s in executable_prefix)]
     executables = sorted(executables)
-    assert len(executables)
+    assert executables
 
     changelog_version = get_changelog_version()
     for e in executables:

requirements-dev.txt

@@ -4,5 +4,6 @@
 # Install with `pip3 install -r requirements-dev.txt`
 
 flake8==7.3.0
+ruff==0.14.1
 filecheck==0.0.22
 lit==0.11.0.post1

scripts/auto_update_tests.py

@@ -19,12 +19,7 @@
 import sys
 from collections import OrderedDict
 
-from test import binaryenjs
-from test import lld
-from test import shared
-from test import support
-from test import wasm2js
-from test import wasm_opt
+from test import binaryenjs, lld, shared, support, wasm2js, wasm_opt
 
 
 def update_example_tests():

scripts/clusterfuzz/run.py

@@ -23,14 +23,13 @@
 bundle_clusterfuzz.py.
 '''
 
-import os
 import getopt
 import math
+import os
 import random
 import subprocess
 import sys
 
-
 # The V8 flags we put in the "fuzzer flags" files, which tell ClusterFuzz how to
 # run V8. By default we apply all staging flags.
 FUZZER_FLAGS = '--wasm-staging --experimental-wasm-custom-descriptors'
@@ -141,7 +140,7 @@ def get_wasm_contents(name, output_dir, extra_args=[]):
 
     # wasm-opt may fail to run in rare cases (when the fuzzer emits code it
     # detects as invalid). Just try again in such a case.
-    for attempt in range(0, 100):
+    for attempt in range(100):
         # Generate random data.
         random_size = system_random.randint(1, MAX_RANDOM_SIZE)
         with open(input_data_file_path, 'wb') as file:
@@ -186,7 +185,7 @@ def get_wasm_contents(name, output_dir, extra_args=[]):
     global temp_files
     temp_files += [
         wasm_file_path,
-        input_data_file_path
+        input_data_file_path,
     ]
 
     # Convert to a string, and wrap into a typed array.

scripts/foreach.py

@@ -15,8 +15,8 @@
 # limitations under the License.
 
 import os
-import sys
 import subprocess
+import sys
 
 from test import support
 

scripts/fuzz_opt.py

@@ -27,24 +27,21 @@
 '''
 
 import contextlib
-import os
 import difflib
 import json
 import math
-import shutil
-import subprocess
+import os
 import random
 import re
+import shutil
+import subprocess
 import sys
 import tarfile
 import time
 import traceback
 from os.path import abspath
 
-from test import fuzzing
-from test import shared
-from test import support
-
+from test import fuzzing, shared, support
 
 assert sys.version_info >= (3, 10), 'requires Python 3.10'
 
@@ -457,7 +454,7 @@ def compare(x, y, context, verbose=True):
         if verbose:
             raise Exception(context + " comparison error, expected to have '%s' == '%s', diff:\n\n%s" % (
                 x, y,
-                message
+                message,
             ))
         else:
             raise Exception(context + "\nDiff:\n\n%s" % (message))
@@ -1007,7 +1004,7 @@ def run_vms(self, wasm):
 
         # compare between the vms on this specific input
         num_vms = len(relevant_vms)
-        for i in range(0, num_vms):
+        for i in range(num_vms):
             for j in range(i + 1, num_vms):
                 vm1 = relevant_vms[i]
                 vm2 = relevant_vms[j]
@@ -1036,8 +1033,8 @@ def handle_pair(self, input, before_wasm, after_wasm, opts):
         if (b1 != b2):
             run([in_bin('wasm-dis'), abspath('b1.wasm'), '-o', abspath('b1.wat')] + FEATURE_OPTS)
             run([in_bin('wasm-dis'), abspath('b2.wasm'), '-o', abspath('b2.wat')] + FEATURE_OPTS)
-            t1 = open(abspath('b1.wat'), 'r').read()
-            t2 = open(abspath('b2.wat'), 'r').read()
+            t1 = open(abspath('b1.wat')).read()
+            t2 = open(abspath('b2.wat')).read()
             compare(t1, t2, 'Output must be deterministic.', verbose=False)
 
 
@@ -1243,12 +1240,12 @@ def filter_exports(wasm, output, keep, keep_defaults=True):
     graph = [{
         'name': 'outside',
         'reaches': [f'export-{export}' for export in keep],
-        'root': True
+        'root': True,
     }]
     for export in keep:
         graph.append({
             'name': f'export-{export}',
-            'export': export
+            'export': export,
         })
 
     with open('graph.json', 'w') as f:
@@ -1741,7 +1738,7 @@ def handle_pair(self, input, before_wasm, after_wasm, opts):
         cmd = [shared.V8]
         # The flags are given in the flags file - we do *not* use our normal
         # flags here!
-        with open(flags_file, 'r') as f:
+        with open(flags_file) as f:
             flags = f.read()
         cmd += flags.split(' ')
         # Get V8's extra fuzzing flags, the same as the ClusterFuzz runner does

scripts/fuzz_passes.py

@@ -25,7 +25,6 @@
        Other parameters after the first are used when calling the program.
 '''
 
-from __future__ import print_function
 
 import os
 import random

scripts/fuzz_passes_wast.py

@@ -22,7 +22,6 @@
 Usage: Provide the filename of the wast.
 '''
 
-from __future__ import print_function
 
 import os
 import random