Skip to content

Commit 081d594

Browse files
committed
fixing type errors
1 parent 49d94ea commit 081d594

4 files changed

Lines changed: 6 additions & 14 deletions

File tree

app/actions/framework_versions/sync_framework_versions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ type Params = {
1212
export default class SyncFrameworkVersions {
1313
static async handle({ resource, ids = [] }: Params) {
1414
const frameworkVersions = ids.reduce(
15-
(prev, currentId, i) => ({
15+
(prev, currentId) => ({
1616
...prev,
1717
[currentId]: {},
1818
}),

app/controllers/framework_versions_controller.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,14 @@ import StoreFrameworkVersion from '#actions/framework_versions/store_framework_v
44
import UpdateFrameworkVersion from '#actions/framework_versions/update_framework_version'
55
import FrameworkVersionDto from '#dtos/framework_version'
66
import FrameworkVersion from '#models/framework_version'
7-
import {
8-
frameworkVersionIndexValidator,
9-
frameworkVersionValidator,
10-
} from '#validators/framework_version'
7+
import { frameworkVersionValidator } from '#validators/framework_version'
118
import type { HttpContext } from '@adonisjs/core/http'
129

1310
export default class FrameworkVersionsController {
1411
/**
1512
* Display a list of resource
1613
*/
17-
async index({ inertia, request }: HttpContext) {
18-
const data = await request.validateUsing(frameworkVersionIndexValidator)
14+
async index({ inertia }: HttpContext) {
1915
const frameworkVersions = await GetFrameworkVersions.handle()
2016

2117
return inertia.render('framework_versions/index', {
@@ -36,7 +32,7 @@ export default class FrameworkVersionsController {
3632
async store({ request, response, session }: HttpContext) {
3733
const data = await request.validateUsing(frameworkVersionValidator)
3834

39-
const frameworkVersion = await StoreFrameworkVersion.handle({ data })
35+
await StoreFrameworkVersion.handle({ data })
4036

4137
session.flash('success', 'Framework version created successfully')
4238

app/dtos/collection_form.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ export default class CollectionFormDto extends BaseModelDto {
5454
this.repositoryUrl = collection.repositoryUrl
5555
this.repositoryAccessLevel = collection.repositoryAccessLevel
5656
this.sortOrder = collection.sortOrder
57-
this.createdAt = collection.createdAt.toISO()
58-
this.updatedAt = collection.updatedAt.toISO()
57+
this.createdAt = collection.createdAt.toISO()!
58+
this.updatedAt = collection.updatedAt.toISO()!
5959

6060
this.asset = collection.asset ? new AssetDto(collection.asset) : null
6161
this.taxonomyIds = collection.taxonomies?.map((row) => row.id) ?? []

app/dtos/framework_version.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,4 @@ export default class FrameworkVersionDto extends BaseModelDto {
1818
this.createdAt = frameworkVersion.createdAt?.toISO()!
1919
this.updatedAt = frameworkVersion.updatedAt?.toISO()!
2020
}
21-
22-
static fromArray(frameworkVersions: FrameworkVersion[] = []) {
23-
return frameworkVersions.map((fv) => new FrameworkVersionDto(fv))
24-
}
2521
}

0 commit comments

Comments
 (0)