Skip to content

Commit dc29cca

Browse files
fix(test): Fix flakiness in AMQ4930Test (#1825)
1 parent 4199744 commit dc29cca

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

activemq-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ4930Test.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -109,18 +109,14 @@ public void doTestBrowsePending(int deliveryMode) throws Exception {
109109
browsed = underTest.browse();
110110
LOG.info("Browsed: " + browsed.length);
111111
assertEquals("maxBrowsePageSize", maxBrowsePageSize, browsed.length);
112-
Runtime.getRuntime().gc();
113-
long free = Runtime.getRuntime().freeMemory()/1024;
114-
LOG.info("free at start of check: " + free);
112+
long memoryUsageAtStart = underTest.getMemoryUsage().getUsage();
113+
LOG.info("Memory usage at start of check: " + memoryUsageAtStart);
115114
// check for memory growth
116115
for (int i=0; i<10; i++) {
117-
LOG.info("free: " + Runtime.getRuntime().freeMemory()/1024);
118116
browsed = underTest.browse();
119117
LOG.info("Browsed: " + browsed.length);
120118
assertEquals("maxBrowsePageSize", maxBrowsePageSize, browsed.length);
121-
Runtime.getRuntime().gc();
122-
Runtime.getRuntime().gc();
123-
assertTrue("No growth: " + Runtime.getRuntime().freeMemory()/1024 + " >= " + (free - (free * 0.2)), Runtime.getRuntime().freeMemory()/1024 >= (free - (free * 0.2)));
119+
assertTrue("Memory usage is ballooning: " + underTest.getMemoryUsage().getUsage() + " > " + (memoryUsageAtStart * 1.1), underTest.getMemoryUsage().getUsage() <= (memoryUsageAtStart * 1.1));
124120
}
125121
}
126122

0 commit comments

Comments
 (0)