GH-50855: [R] Fix shellcheck errors in the r/inst/build_arrow_static.sh by hiroyuki-sato · Pull Request #50856 · apache/arrow

hiroyuki-sato · 2026-08-13T02:05:51Z

Rationale for this change

This is the sub issue #44748.

SC2086: Double quote to prevent globbing and word splitting.
SC2223: This default assignment may cause DoS due to globbing. Quote it.
SC2006: Use $(...) notation instead of legacy backticked ....

shellcheck r/inst/build_arrow_static.sh

In r/inst/build_arrow_static.sh line 29:
: ${ARROW_HOME:="$(pwd)"}                       # Only used in default SOURCE/BUILD dirs
  ^---------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In r/inst/build_arrow_static.sh line 30:
: ${SOURCE_DIR:="${ARROW_HOME}/cpp"}            # Where the C++ source is
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In r/inst/build_arrow_static.sh line 31:
: ${BUILD_DIR:="${ARROW_HOME}/r/libarrow/dist"} # Where cmake should build
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In r/inst/build_arrow_static.sh line 32:
: ${DEST_DIR:="$BUILD_DIR"}                     # Where the resulting /lib and /include should be
  ^-----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In r/inst/build_arrow_static.sh line 33:
: ${CMAKE:="$(which cmake)"}
  ^------------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In r/inst/build_arrow_static.sh line 40:
  if [ "`uname -s`" = "Darwin" ]; then
        ^--------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
  if [ "$(uname -s)" = "Darwin" ]; then


In r/inst/build_arrow_static.sh line 49:
  LIBARROW_MINIMAL=`echo $LIBARROW_MINIMAL | tr '[:upper:]' '[:lower:]'`
                   ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                         ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  LIBARROW_MINIMAL=$(echo "$LIBARROW_MINIMAL" | tr '[:upper:]' '[:lower:]')


In r/inst/build_arrow_static.sh line 66:
: ${CMAKE_WRAPPER:=""}
  ^------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In r/inst/build_arrow_static.sh line 70:
${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
                 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
${CMAKE_WRAPPER} "${CMAKE}" -DARROW_BOOST_USE_SHARED=OFF \


In r/inst/build_arrow_static.sh line 75:
    -DARROW_ACERO=${ARROW_ACERO:-ON} \
                  ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_ACERO="${ARROW_ACERO:-ON}" \


In r/inst/build_arrow_static.sh line 78:
    -DARROW_DATASET=${ARROW_DATASET:-ON} \
                    ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_DATASET="${ARROW_DATASET:-ON}" \


In r/inst/build_arrow_static.sh line 79:
    -DARROW_DEPENDENCY_SOURCE=${ARROW_DEPENDENCY_SOURCE:-AUTO} \
                              ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_DEPENDENCY_SOURCE="${ARROW_DEPENDENCY_SOURCE:-AUTO}" \


In r/inst/build_arrow_static.sh line 80:
    -DARROW_DEPENDENCY_USE_SHARED=${ARROW_DEPENDENCY_USE_SHARED:-ON} \
                                  ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_DEPENDENCY_USE_SHARED="${ARROW_DEPENDENCY_USE_SHARED:-ON}" \


In r/inst/build_arrow_static.sh line 81:
    -DARROW_ENABLE_THREADING=${ARROW_ENABLE_THREADING:-ON} \
                             ^---------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_ENABLE_THREADING="${ARROW_ENABLE_THREADING:-ON}" \


In r/inst/build_arrow_static.sh line 82:
    -DAWSSDK_SOURCE=${AWSSDK_SOURCE:-} \
                    ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DAWSSDK_SOURCE="${AWSSDK_SOURCE:-}" \


In r/inst/build_arrow_static.sh line 83:
    -DBoost_SOURCE=${Boost_SOURCE:-} \
                   ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DBoost_SOURCE="${Boost_SOURCE:-}" \


In r/inst/build_arrow_static.sh line 84:
    -Dlz4_SOURCE=${lz4_SOURCE:-} \
                 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -Dlz4_SOURCE="${lz4_SOURCE:-}" \


In r/inst/build_arrow_static.sh line 86:
    -DARROW_GCS=${ARROW_GCS:-OFF} \
                ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_GCS="${ARROW_GCS:-OFF}" \


In r/inst/build_arrow_static.sh line 87:
    -DARROW_AZURE=${ARROW_AZURE:-$ARROW_DEFAULT_PARAM} \
                  ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_AZURE="${ARROW_AZURE:-$ARROW_DEFAULT_PARAM}" \


In r/inst/build_arrow_static.sh line 88:
    -DARROW_JEMALLOC=${ARROW_JEMALLOC:-$ARROW_DEFAULT_PARAM} \
                     ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_JEMALLOC="${ARROW_JEMALLOC:-$ARROW_DEFAULT_PARAM}" \


In r/inst/build_arrow_static.sh line 89:
    -DARROW_MIMALLOC=${ARROW_MIMALLOC:-ON} \
                     ^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_MIMALLOC="${ARROW_MIMALLOC:-ON}" \


In r/inst/build_arrow_static.sh line 90:
    -DARROW_JSON=${ARROW_JSON:-ON} \
                 ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_JSON="${ARROW_JSON:-ON}" \


In r/inst/build_arrow_static.sh line 91:
    -DARROW_PARQUET=${ARROW_PARQUET:-ON} \
                    ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_PARQUET="${ARROW_PARQUET:-ON}" \


In r/inst/build_arrow_static.sh line 92:
    -DARROW_S3=${ARROW_S3:-$ARROW_DEFAULT_PARAM} \
               ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_S3="${ARROW_S3:-$ARROW_DEFAULT_PARAM}" \


In r/inst/build_arrow_static.sh line 93:
    -DARROW_WITH_BROTLI=${ARROW_WITH_BROTLI:-$ARROW_DEFAULT_PARAM} \
                        ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_BROTLI="${ARROW_WITH_BROTLI:-$ARROW_DEFAULT_PARAM}" \


In r/inst/build_arrow_static.sh line 94:
    -DARROW_WITH_BZ2=${ARROW_WITH_BZ2:-$ARROW_DEFAULT_PARAM} \
                     ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_BZ2="${ARROW_WITH_BZ2:-$ARROW_DEFAULT_PARAM}" \


In r/inst/build_arrow_static.sh line 95:
    -DARROW_WITH_LZ4=${ARROW_WITH_LZ4:-ON} \
                     ^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_LZ4="${ARROW_WITH_LZ4:-ON}" \


In r/inst/build_arrow_static.sh line 96:
    -DARROW_WITH_RE2=${ARROW_WITH_RE2:-ON} \
                     ^-------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_RE2="${ARROW_WITH_RE2:-ON}" \


In r/inst/build_arrow_static.sh line 97:
    -DARROW_WITH_SNAPPY=${ARROW_WITH_SNAPPY:-ON} \
                        ^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_SNAPPY="${ARROW_WITH_SNAPPY:-ON}" \


In r/inst/build_arrow_static.sh line 98:
    -DARROW_WITH_UTF8PROC=${ARROW_WITH_UTF8PROC:-ON} \
                          ^------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_UTF8PROC="${ARROW_WITH_UTF8PROC:-ON}" \


In r/inst/build_arrow_static.sh line 99:
    -DARROW_WITH_ZLIB=${ARROW_WITH_ZLIB:-$ARROW_DEFAULT_PARAM} \
                      ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_ZLIB="${ARROW_WITH_ZLIB:-$ARROW_DEFAULT_PARAM}" \


In r/inst/build_arrow_static.sh line 100:
    -DARROW_WITH_ZSTD=${ARROW_WITH_ZSTD:-$ARROW_DEFAULT_PARAM} \
                      ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_ZSTD="${ARROW_WITH_ZSTD:-$ARROW_DEFAULT_PARAM}" \


In r/inst/build_arrow_static.sh line 101:
    -DARROW_VERBOSE_THIRDPARTY_BUILD=${ARROW_VERBOSE_THIRDPARTY_BUILD:-OFF} \
                                     ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_VERBOSE_THIRDPARTY_BUILD="${ARROW_VERBOSE_THIRDPARTY_BUILD:-OFF}" \


In r/inst/build_arrow_static.sh line 102:
    -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE:-Release} \
                       ^--------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DCMAKE_BUILD_TYPE="${CMAKE_BUILD_TYPE:-Release}" \


In r/inst/build_arrow_static.sh line 103:
    -DCMAKE_FIND_DEBUG_MODE=${CMAKE_FIND_DEBUG_MODE:-OFF} \
                            ^---------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DCMAKE_FIND_DEBUG_MODE="${CMAKE_FIND_DEBUG_MODE:-OFF}" \


In r/inst/build_arrow_static.sh line 105:
    -DCMAKE_INSTALL_PREFIX=${DEST_DIR} \
                           ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DCMAKE_INSTALL_PREFIX="${DEST_DIR}" \


In r/inst/build_arrow_static.sh line 108:
    -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
                        ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DCMAKE_UNITY_BUILD="${CMAKE_UNITY_BUILD:-OFF}" \


In r/inst/build_arrow_static.sh line 109:
    -DOPENSSL_ROOT_DIR=${OPENSSL_ROOT_DIR} \
                       ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DOPENSSL_ROOT_DIR="${OPENSSL_ROOT_DIR}" \


In r/inst/build_arrow_static.sh line 110:
    -Dabsl_SOURCE=${absl_SOURCE:-BUNDLED} \
                  ^---------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -Dabsl_SOURCE="${absl_SOURCE:-BUNDLED}" \


In r/inst/build_arrow_static.sh line 111:
    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
                 ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -Dre2_SOURCE="${re2_SOURCE:-BUNDLED}" \


In r/inst/build_arrow_static.sh line 112:
    -Dsimdjson_SOURCE=${simdjson_SOURCE:-BUNDLED} \
                      ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -Dsimdjson_SOURCE="${simdjson_SOURCE:-BUNDLED}" \


In r/inst/build_arrow_static.sh line 113:
    -Dxsimd_SOURCE=${xsimd_SOURCE:-} \
                   ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -Dxsimd_SOURCE="${xsimd_SOURCE:-}" \


In r/inst/build_arrow_static.sh line 114:
    -Dzstd_SOURCE=${zstd_SOURCE:-} \
                  ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -Dzstd_SOURCE="${zstd_SOURCE:-}" \


In r/inst/build_arrow_static.sh line 115:
    ${EXTRA_CMAKE_FLAGS} \
    ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    "${EXTRA_CMAKE_FLAGS}" \


In r/inst/build_arrow_static.sh line 117:
    ${SOURCE_DIR}
    ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    "${SOURCE_DIR}"


In r/inst/build_arrow_static.sh line 119:
${CMAKE} --build . --target install -- -j $N_JOBS
                                          ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
${CMAKE} --build . --target install -- -j "$N_JOBS"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause...
  https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...

What changes are included in this PR?

SC2086: Quote variable expansions to prevent globbing and word splitting.
SC2223: Quote parameter expansion in default assignments to prevent globbing.
SC2006: Use $(...) notation instead of legacy backticked ....

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

GitHub Issue: [R] Fix shellcheck errors in the r/inst/build_arrow_static.sh #50855

…tatic.sh

kou

+1

kou · 2026-08-13T06:25:22Z

Could you update .pre-commit-config.yaml?

Copilot

Pull request overview

This PR updates the R static libarrow build script (r/inst/build_arrow_static.sh) to address ShellCheck findings by improving quoting and modernizing command substitutions, aiming to prevent globbing/word-splitting issues during builds.

Changes:

Quote parameter expansions and command arguments to satisfy SC2086/SC2223.
Replace legacy backticks with $(...) for SC2006.
Introduce a CMAKE_COMMAND array to invoke CMake optionally via a wrapper.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

hiroyuki-sato · 2026-08-13T06:38:45Z

+    -Dxsimd_SOURCE="${xsimd_SOURCE:-}" \
+    -Dzstd_SOURCE="${zstd_SOURCE:-}" \
+    "${EXTRA_CMAKE_FLAGS}" \
    -G "${CMAKE_GENERATOR:-Unix Makefiles}" \
-    ${SOURCE_DIR}
+    "${SOURCE_DIR}"


Fixed.

+# Convert the space-separated options into a Bash array. +# This avoids ShellCheck SC2086 and preserves argument boundaries. +read -r -a ARROW_EXTRA_CMAKE_FLAGS <<< "${EXTRA_CMAKE_FLAGS}" + mkdir -p "${BUILD_DIR}" pushd "${BUILD_DIR}" "${CMAKE_COMMAND[@]}" -DARROW_BOOST_USE_SHARED=OFF \ @@ -117,7 +121,7 @@ pushd "${BUILD_DIR}" -Dsimdjson_SOURCE="${simdjson_SOURCE:-BUNDLED}" \ -Dxsimd_SOURCE="${xsimd_SOURCE:-}" \ -Dzstd_SOURCE="${zstd_SOURCE:-}" \ - "${EXTRA_CMAKE_FLAGS}" \ + "${ARROW_EXTRA_CMAKE_FLAGS[@]}" \ -G "${CMAKE_GENERATOR:-Unix Makefiles}" \ "${SOURCE_DIR}"

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

…tatic.sh

hiroyuki-sato · 2026-08-13T06:37:37Z

Could you update .pre-commit-config.yaml?

Oops: Thanks. Fixed.

hiroyuki-sato · 2026-08-14T00:25:36Z

@kou After your approval, I fixed the issues raised by Copilot. Please take a look when you get a chance. b2e997d

conbench-apache-arrow · 2026-08-14T07:40:19Z

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit a708225.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 82 possible false positives for unstable benchmarks that are known to sometimes produce them.

apacheGH-50855: [R] Fix shellcheck errors in the r/inst/build_arrow_s…

ec0e406

…tatic.sh

hiroyuki-sato requested review from jonkeane and thisisnic as code owners August 13, 2026 02:05

github-actions Bot added awaiting review Awaiting review Component: R labels Aug 13, 2026

apacheGH-50855: [R] Fix shellcheck errors in the r/inst/build_arrow_s…

bb88486

…tatic.sh

kou approved these changes Aug 13, 2026

View reviewed changes

Comment thread r/inst/build_arrow_static.sh Outdated

kou requested a lite review from Copilot August 13, 2026 06:24

Copilot started reviewing on behalf of kou August 13, 2026 06:25 View session

github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Aug 13, 2026

Copilot AI reviewed Aug 13, 2026

View reviewed changes

hiroyuki-sato and others added 2 commits August 13, 2026 15:29

Update r/inst/build_arrow_static.sh

99b7b28

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

apacheGH-50855: [R] Fix shellcheck errors in the r/inst/build_arrow_s…

b2e997d

…tatic.sh

hiroyuki-sato requested a review from raulcd as a code owner August 13, 2026 06:36

kou merged commit a708225 into apache:main Aug 14, 2026
34 checks passed

kou removed the awaiting merge Awaiting merge label Aug 14, 2026

kou mentioned this pull request Aug 14, 2026

[R] Fix shellcheck errors in the r/inst/build_arrow_static.sh #50855

Closed

hiroyuki-sato deleted the topic/shellcheck-build_arrow_static branch August 14, 2026 02:11

Navigation Menu

Uh oh!

GH-50855: [R] Fix shellcheck errors in the r/inst/build_arrow_static.sh - #50856

GH-50855: [R] Fix shellcheck errors in the r/inst/build_arrow_static.sh#50856
kou merged 4 commits into
apache:mainfrom
hiroyuki-sato:topic/shellcheck-build_arrow_static

hiroyuki-sato commented Aug 13, 2026 •

edited by github-actions Bot

Loading

Uh oh!

kou left a comment

Uh oh!

Uh oh!

kou commented Aug 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

hiroyuki-sato Aug 13, 2026

Uh oh!

hiroyuki-sato commented Aug 13, 2026

Uh oh!

hiroyuki-sato commented Aug 14, 2026

Uh oh!

Uh oh!

conbench-apache-arrow Bot commented Aug 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

hiroyuki-sato commented Aug 13, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kou commented Aug 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

hiroyuki-sato Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

hiroyuki-sato commented Aug 13, 2026

Uh oh!

hiroyuki-sato commented Aug 14, 2026

Uh oh!

Uh oh!

conbench-apache-arrow Bot commented Aug 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hiroyuki-sato commented Aug 13, 2026 •

edited by github-actions Bot

Loading