Describe the bug
I noticed that pull request was marked as breaking change when the pr HEAD was behind the base branch
I think this is because of a race condition with actual breaking change that was merged and the git fetch that done might include more commits when the workflow started
For example this was marked as breaking change while it was not:
Thank you for opening this pull request!
Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
Details
Cloning apache/main
Building datafusion-common v54.0.0 (current)
Built [ 34.581s] (current)
Parsing datafusion-common v54.0.0 (current)
Parsed [ 0.060s] (current)
Building datafusion-common v54.0.0 (baseline)
Built [ 34.585s] (baseline)
Parsing datafusion-common v54.0.0 (baseline)
Parsed [ 0.060s] (baseline)
Checking datafusion-common v54.0.0 -> v54.0.0 (no change; assume patch)
Checked [ 0.678s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/inherent_method_missing.ron
Failed in:
Dialect::metadata, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/2ef2431ff13538c16aa6ae96950bc1790d384cf9/datafusion/common/src/config.rs:472
Dialect::available, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/2ef2431ff13538c16aa6ae96950bc1790d384cf9/datafusion/common/src/config.rs:477
--- failure struct_missing: pub struct removed or renamed ---
Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/struct_missing.ron
Failed in:
struct datafusion_common::config::DialectInfo, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/2ef2431ff13538c16aa6ae96950bc1790d384cf9/datafusion/common/src/config.rs:329
Summary semver requires new major version: 2 major and 0 minor checks failed
Finished [ 71.215s] datafusion-common
when my pr was behind this commit:
To Reproduce
No response
Expected behavior
it should run the breaking change detector for the "merged" ref
Additional context
I fixed part of the issue before in:
Describe the bug
I noticed that pull request was marked as breaking change when the pr HEAD was behind the base branch
I think this is because of a race condition with actual breaking change that was merged and the
git fetchthat done might include more commits when the workflow startedFor example this was marked as breaking change while it was not:
assert_*_or_internal_errhelpers #18910 (comment)when my pr was behind this commit:
To Reproduce
No response
Expected behavior
it should run the breaking change detector for the "merged" ref
Additional context
I fixed part of the issue before in: