Skip to content

Proto: migrate ScalarSubqueryExec (adds a subquery-results scope to the decode ctx) #23515

Description

@adriangb

Part of #23494.

scalar_subquery.rs. Encode is straightforward. Decode needs a small ctx addition: a decode_child_with_scalar_subquery_results method (dispatch trait method + ctx wrapper + a one-line datafusion-proto adapter) so ScalarSubqueryExpr nodes in the input subtree resolve against the scoped container. Bundle that ctx addition in this PR.


Follow the pattern in #23494 (reference impl: #23495 / ProjectionExec; full end-state draft: #23496). Add try_to_proto inside impl ExecutionPlan for X, add the inherent X::try_from_proto, repoint the decode arm, and delete the old central arm in the same PR (that is the proof the hook is reached). Keep the wire format byte-for-byte identical.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions