remove unsued function and apply review

Author: voidmatcha

zeppelin-web-angular/e2e/models/home-page.util.ts

@@ -44,56 +44,18 @@ export class HomePageUtil {
     };
   }
 
-  async verifyHomePageIntegrity(): Promise<void> {
-    await this.verifyHomePageElements();
-    await this.verifyNotebookFunctionalities();
-    await this.verifyTutorialNotebooks();
-    await this.verifyExternalLinks();
-  }
-
   async verifyHomePageElements(): Promise<void> {
     await expect(this.homePage.welcomeHeading).toBeVisible();
     await expect(this.homePage.notebookSection).toBeVisible();
     await expect(this.homePage.helpSection).toBeVisible();
     await expect(this.homePage.communitySection).toBeVisible();
   }
 
-  async verifyNotebookFunctionalities(): Promise<void> {
-    await expect(this.homePage.createNewNoteButton).toBeVisible();
-    await expect(this.homePage.importNoteButton).toBeVisible();
-
-    const filterInputCount = await this.homePage.filterInput.count();
-    if (filterInputCount > 0) {
-      await expect(this.homePage.filterInput).toBeVisible();
-    }
-  }
-
-  async verifyTutorialNotebooks(): Promise<void> {
-    await expect(this.homePage.tutorialNotebooks.flinkTutorial).toBeVisible();
-    await expect(this.homePage.tutorialNotebooks.pythonTutorial).toBeVisible();
-    await expect(this.homePage.tutorialNotebooks.sparkTutorial).toBeVisible();
-    await expect(this.homePage.tutorialNotebooks.rTutorial).toBeVisible();
-    await expect(this.homePage.tutorialNotebooks.miscellaneousTutorial).toBeVisible();
-  }
-
   async verifyExternalLinks(): Promise<void> {
-    const docCount = await this.homePage.externalLinks.documentation.count();
-    const mailCount = await this.homePage.externalLinks.mailingList.count();
-    const issuesCount = await this.homePage.externalLinks.issuesTracking.count();
-    const githubCount = await this.homePage.externalLinks.github.count();
-
-    if (docCount > 0) {
-      await expect(this.homePage.externalLinks.documentation).toBeVisible();
-    }
-    if (mailCount > 0) {
-      await expect(this.homePage.externalLinks.mailingList).toBeVisible();
-    }
-    if (issuesCount > 0) {
-      await expect(this.homePage.externalLinks.issuesTracking).toBeVisible();
-    }
-    if (githubCount > 0) {
-      await expect(this.homePage.externalLinks.github).toBeVisible();
-    }
+    await expect(this.homePage.externalLinks.documentation).toBeVisible();
+    await expect(this.homePage.externalLinks.mailingList).toBeVisible();
+    await expect(this.homePage.externalLinks.issuesTracking).toBeVisible();
+    await expect(this.homePage.externalLinks.github).toBeVisible();
   }
 
   async testNavigationConsistency(): Promise<{

zeppelin-web-angular/e2e/models/notebook-keyboard-page.ts

@@ -971,25 +971,6 @@ export class NotebookKeyboardPage extends BasePage {
     throw new Error(`No paragraphs found after ${timeout}ms - system appears broken`);
   }
 
-  async getCurrentCursorPosition(): Promise<{ line: number; column: number } | null> {
-    try {
-      return await this.page.evaluate(() => {
-        // tslint:disable-next-line:no-any
-        const win = (window as unknown) as any;
-        const editor = win.monaco?.editor?.getModels?.()?.[0];
-        if (editor) {
-          const position = editor.getPosition?.();
-          if (position) {
-            return { line: position.lineNumber, column: position.column };
-          }
-        }
-        return null;
-      });
-    } catch {
-      return null;
-    }
-  }
-
   async isSearchDialogVisible(): Promise<boolean> {
     const searchDialog = this.page.locator('.search-widget, .find-widget, [role="dialog"]:has-text("Find")');
     return await searchDialog.isVisible();
@@ -1007,13 +988,6 @@ export class NotebookKeyboardPage extends BasePage {
     return selectedClass?.includes('focused') || selectedClass?.includes('selected') || false;
   }
 
-  async getSelectedContent(): Promise<string> {
-    return await this.page.evaluate(() => {
-      const selection = window.getSelection();
-      return selection?.toString() || '';
-    });
-  }
-
   async clickModalOkButton(timeout: number = 10000): Promise<void> {
     // Wait for any modal to appear
     const modal = this.page.locator('.ant-modal, .modal-dialog, .ant-modal-confirm');

zeppelin-web-angular/e2e/models/notebook-page.util.ts

@@ -103,29 +103,6 @@ export class NotebookPageUtil extends BasePage {
     }
   }
 
-  // ===== NAVIGATION VERIFICATION METHODS =====
-
-  async verifyNotebookNavigationPatterns(noteId: string): Promise<void> {
-    await this.notebookPage.navigateToNotebook(noteId);
-    expect(this.page.url()).toContain(`/#/notebook/${noteId}`);
-
-    await expect(this.notebookPage.notebookContainer).toBeVisible();
-  }
-
-  async verifyRevisionNavigationIfSupported(noteId: string, revisionId: string): Promise<void> {
-    await this.notebookPage.navigateToNotebookRevision(noteId, revisionId);
-    expect(this.page.url()).toContain(`/#/notebook/${noteId}/revision/${revisionId}`);
-
-    await expect(this.notebookPage.notebookContainer).toBeVisible();
-  }
-
-  async verifyParagraphModeNavigation(noteId: string, paragraphId: string): Promise<void> {
-    await this.notebookPage.navigateToNotebookParagraph(noteId, paragraphId);
-    expect(this.page.url()).toContain(`/#/notebook/${noteId}/paragraph/${paragraphId}`);
-
-    await expect(this.notebookPage.notebookContainer).toBeVisible();
-  }
-
   // ===== LAYOUT VERIFICATION METHODS =====
 
   async verifyGridLayoutForParagraphs(): Promise<void> {

zeppelin-web-angular/e2e/tests/authentication/anonymous-login-redirect.spec.ts

@@ -62,7 +62,7 @@ test.describe('Anonymous User Login Redirect', () => {
       await waitForZeppelinReady(page);
       await page.waitForURL(url => !url.toString().includes('#/login'));
 
-      await homePageUtil.verifyHomePageIntegrity();
+      await homePageUtil.verifyHomePageElements();
     });
 
     test('When clicking Zeppelin logo after redirect, Then should maintain home URL and content', async ({ page }) => {