140086: Add config support to disable bitstream replacement

Joran De Braekeleer · Joran De Braekeleer · commit cbc4db082449 · 2026-03-31T17:13:07.000+02:00
diff --git a/src/app/bitstream-page/bitstream-page-routes.ts b/src/app/bitstream-page/bitstream-page-routes.ts
@@ -15,6 +15,7 @@ import { bitstreamPageAuthorizationsGuard } from './bitstream-page-authorization
 import { ThemedEditBitstreamPageComponent } from './edit-bitstream-page/themed-edit-bitstream-page.component';
 import { legacyBitstreamURLRedirectGuard } from './legacy-bitstream-url-redirect.guard';
 import { ReplaceBitstreamPageComponent } from './replace-bitstream-page/replace-bitstream-page.component';
+import { replaceBitstreamPageGuard } from './replace-bitstream-page/replace-bitstream-page.guard';
 
 const EDIT_BITSTREAM_PATH = ':id/edit';
 const EDIT_BITSTREAM_AUTHORIZATIONS_PATH = ':id/authorizations';
@@ -61,7 +62,7 @@ export const ROUTES: Route[] = [
       bitstream: bitstreamPageResolver,
       breadcrumb: i18nBreadcrumbResolver,
     },
-    canActivate: [authenticatedGuard],
+    canActivate: [authenticatedGuard, replaceBitstreamPageGuard],
     data: {
       title: 'bitstream.replace.page.title',
       breadcrumbKey: 'bitstream.replace.page',
diff --git a/src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.html b/src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.html
@@ -25,12 +25,15 @@ <h1 class="h2 dont-break-out">{{dsoNameService.getName(bitstreamRD?.payload)}} <
               <div additional class="container py-3">
                 <p>
                   <a
-                    [routerLink]="['/bitstreams', bitstreamRD?.payload?.id, 'authorizations']">{{'bitstream.edit.authorizations.link' | translate}}</a>
+                    [routerLink]="['/bitstreams', bitstreamRD?.payload?.id, 'authorizations']">{{ 'bitstream.edit.authorizations.link' | translate }}</a>
                 </p>
-                <p>
-                  <a
-                    [routerLink]="['/bitstreams', bitstreamRD?.payload?.id, 'replace']">{{'bitstream.edit.replace.link' | translate}}</a>
-                </p>              </div>
+                @if (showReplaceButton$ | async) {
+                  <p>
+                    <a
+                      [routerLink]="['/bitstreams', bitstreamRD?.payload?.id, 'replace']">{{ 'bitstream.edit.replace.link' | translate }}</a>
+                  </p>
+                }
+              </div>
             </ds-form>
           }
         </div>
diff --git a/src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.spec.ts b/src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.spec.ts
@@ -19,6 +19,7 @@ import { RouterTestingModule } from '@angular/router/testing';
 import { DSONameService } from '@dspace/core/breadcrumbs/dso-name.service';
 import { BitstreamDataService } from '@dspace/core/data/bitstream-data.service';
 import { BitstreamFormatDataService } from '@dspace/core/data/bitstream-format-data.service';
+import { ConfigurationDataService } from '@dspace/core/data/configuration-data.service';
 import { PrimaryBitstreamService } from '@dspace/core/data/primary-bitstream.service';
 import {
   INotification,
@@ -31,6 +32,7 @@ import { BitstreamFormat } from '@dspace/core/shared/bitstream-format.model';
 import { BitstreamFormatSupportLevel } from '@dspace/core/shared/bitstream-format-support-level';
 import { Item } from '@dspace/core/shared/item.model';
 import { MetadataValueFilter } from '@dspace/core/shared/metadata.models';
+import { ConfigurationDataServiceStub } from '@dspace/core/testing/configuration-data.service.stub';
 import { createPaginatedList } from '@dspace/core/testing/utils.test';
 import {
   createSuccessfulRemoteDataObject,
@@ -231,6 +233,7 @@ describe('EditBitstreamPageComponent', () => {
           { provide: BitstreamFormatDataService, useValue: bitstreamFormatService },
           { provide: PrimaryBitstreamService, useValue: primaryBitstreamService },
           ChangeDetectorRef,
+          { provide: ConfigurationDataService, useValue: new ConfigurationDataServiceStub() },
         ],
         schemas: [NO_ERRORS_SCHEMA],
       }).compileComponents();
@@ -526,6 +529,7 @@ describe('EditBitstreamPageComponent', () => {
           { provide: BitstreamFormatDataService, useValue: bitstreamFormatService },
           { provide: PrimaryBitstreamService, useValue: primaryBitstreamService },
           ChangeDetectorRef,
+          { provide: ConfigurationDataService, useValue: new ConfigurationDataServiceStub() },
         ],
         schemas: [NO_ERRORS_SCHEMA],
       }).compileComponents();
@@ -649,6 +653,7 @@ describe('EditBitstreamPageComponent', () => {
           { provide: BitstreamFormatDataService, useValue: bitstreamFormatService },
           { provide: PrimaryBitstreamService, useValue: primaryBitstreamService },
           ChangeDetectorRef,
+          { provide: ConfigurationDataService, useValue: new ConfigurationDataServiceStub() },
         ],
         schemas: [NO_ERRORS_SCHEMA],
       }).compileComponents();
diff --git a/src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.ts b/src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.ts
@@ -16,6 +16,7 @@ import { DSONameService } from '@dspace/core/breadcrumbs/dso-name.service';
 import { FindAllDataImpl } from '@dspace/core/data/base/find-all-data';
 import { BitstreamDataService } from '@dspace/core/data/bitstream-data.service';
 import { BitstreamFormatDataService } from '@dspace/core/data/bitstream-format-data.service';
+import { ConfigurationDataService } from '@dspace/core/data/configuration-data.service';
 import { PrimaryBitstreamService } from '@dspace/core/data/primary-bitstream.service';
 import { RemoteData } from '@dspace/core/data/remote-data';
 import { NotificationsService } from '@dspace/core/notification-system/notifications.service';
@@ -428,6 +429,11 @@ export class EditBitstreamPageComponent implements OnInit, OnDestroy {
    */
   isIIIF = false;
 
+  /**
+   * Whether bitstream replacement is enabled in the backend
+   */
+  showReplaceButton$: Observable<boolean>;
+
   /**
    * Array to track all subscriptions and unsubscribe them onDestroy
    * @type {Array}
@@ -455,6 +461,7 @@ export class EditBitstreamPageComponent implements OnInit, OnDestroy {
               private notificationsService: NotificationsService,
               private bitstreamFormatService: BitstreamFormatDataService,
               private primaryBitstreamService: PrimaryBitstreamService,
+              private configurationService: ConfigurationDataService,
   ) {
   }
 
@@ -469,6 +476,10 @@ export class EditBitstreamPageComponent implements OnInit, OnDestroy {
     this.itemId = this.route.snapshot.queryParams.itemId;
     this.entityType = this.route.snapshot.queryParams.entityType;
     this.bitstreamRD$ = this.route.data.pipe(map((data: any) => data.bitstream));
+    this.showReplaceButton$ = this.configurationService.findByPropertyName('replace-bitstream.enabled').pipe(
+      getFirstSucceededRemoteDataPayload(),
+      map(payload => payload?.values.length > 0 && payload?.values[0] === 'true'),
+    );
 
     const bitstream$ = this.bitstreamRD$.pipe(
       getFirstSucceededRemoteData(),
diff --git a/src/app/bitstream-page/replace-bitstream-page/replace-bitstream-page.guard.ts b/src/app/bitstream-page/replace-bitstream-page/replace-bitstream-page.guard.ts
@@ -0,0 +1,22 @@
+import { inject } from '@angular/core';
+import {
+  ActivatedRouteSnapshot,
+  CanActivateFn,
+  RouterStateSnapshot,
+  UrlTree,
+} from '@angular/router';
+import { ConfigurationDataService } from '@dspace/core/data/configuration-data.service';
+import { getFirstSucceededRemoteDataPayload } from '@dspace/core/shared/operators';
+import { Observable } from 'rxjs';
+import { map } from 'rxjs/operators';
+
+export const replaceBitstreamPageGuard: CanActivateFn = (
+  route: ActivatedRouteSnapshot,
+  state: RouterStateSnapshot,
+  configurationService: ConfigurationDataService = inject(ConfigurationDataService),
+): Observable<UrlTree | boolean> => {
+  return configurationService.findByPropertyName('replace-bitstream.enabled').pipe(
+    getFirstSucceededRemoteDataPayload(),
+    map(payload => payload?.values.length > 0 && payload?.values[0] === 'true'),
+  );
+};
diff --git a/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream-bundle/item-edit-bitstream-bundle.component.html b/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream-bundle/item-edit-bitstream-bundle.component.html
@@ -109,10 +109,12 @@
                           title="{{'item.edit.bitstreams.edit.buttons.edit' | translate}}">
                           <i class="fas fa-edit fa-fw"></i>
                         </button>
-                        <button [routerLink]="['/bitstreams/', entry.id, 'replace']" class="btn btn-outline-primary btn-sm"
-                                title="{{'item.edit.bitstreams.edit.buttons.replace' | translate}}">
-                          <i class="fas fa-retweet fa-fw"></i>
-                        </button>
+                        @if (showReplaceButton$ | async) {
+                          <button [routerLink]="['/bitstreams/', entry.id, 'replace']" class="btn btn-outline-primary btn-sm"
+                                  title="{{'item.edit.bitstreams.edit.buttons.replace' | translate}}">
+                            <i class="fas fa-retweet fa-fw"></i>
+                          </button>
+                        }
                         <button [dsBtnDisabled]="!canRemove(update)" (click)="remove(entry.bitstream)"
                           [attr.aria-label]=" 'item. edit bitstreams.edit.buttons.remove' | translate"
                           class="btn btn-outline-danger btn-sm"
diff --git a/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream-bundle/item-edit-bitstream-bundle.component.spec.ts b/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream-bundle/item-edit-bitstream-bundle.component.spec.ts
@@ -9,13 +9,15 @@ import {
   waitForAsync,
 } from '@angular/core/testing';
 import { BundleDataService } from '@dspace/core/data/bundle-data.service';
+import { ConfigurationDataService } from '@dspace/core/data/configuration-data.service';
 import { FieldChangeType } from '@dspace/core/data/object-updates/field-change-type.model';
 import { FieldUpdate } from '@dspace/core/data/object-updates/field-update.model';
 import { ObjectUpdatesService } from '@dspace/core/data/object-updates/object-updates.service';
 import { RequestService } from '@dspace/core/data/request.service';
 import { PaginationService } from '@dspace/core/pagination/pagination.service';
 import { Bundle } from '@dspace/core/shared/bundle.model';
 import { Item } from '@dspace/core/shared/item.model';
+import { ConfigurationDataServiceStub } from '@dspace/core/testing/configuration-data.service.stub';
 import { PaginationServiceStub } from '@dspace/core/testing/pagination-service.stub';
 import { getMockRequestService } from '@dspace/core/testing/request.service.mock';
 import { createPaginatedList } from '@dspace/core/testing/utils.test';
@@ -88,6 +90,7 @@ describe('ItemEditBitstreamBundleComponent', () => {
         { provide: PaginationService, useValue: new PaginationServiceStub() },
         { provide: RequestService, useValue: getMockRequestService() },
         { provide: ItemBitstreamsService, useValue: itemBitstreamsService },
+        { provide: ConfigurationDataService, useValue: new ConfigurationDataServiceStub() },
       ],
       schemas: [
         NO_ERRORS_SCHEMA,
diff --git a/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream-bundle/item-edit-bitstream-bundle.component.ts b/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream-bundle/item-edit-bitstream-bundle.component.ts
@@ -15,6 +15,7 @@ import {
 import { RouterLink } from '@angular/router';
 import { DSONameService } from '@dspace/core/breadcrumbs/dso-name.service';
 import { BundleDataService } from '@dspace/core/data/bundle-data.service';
+import { ConfigurationDataService } from '@dspace/core/data/configuration-data.service';
 import { FieldChangeType } from '@dspace/core/data/object-updates/field-change-type.model';
 import { FieldUpdate } from '@dspace/core/data/object-updates/field-update.model';
 import { FieldUpdates } from '@dspace/core/data/object-updates/field-updates.model';
@@ -31,6 +32,7 @@ import { followLink } from '@dspace/core/shared/follow-link-config.model';
 import { Item } from '@dspace/core/shared/item.model';
 import {
   getAllSucceededRemoteData,
+  getFirstSucceededRemoteDataPayload,
   paginatedListToArray,
 } from '@dspace/core/shared/operators';
 import { PaginatedSearchOptions } from '@dspace/core/shared/search/models/paginated-search-options.model';
@@ -186,6 +188,11 @@ export class ItemEditBitstreamBundleComponent implements OnInit, OnDestroy {
    */
   updates$: BehaviorSubject<FieldUpdates> = new BehaviorSubject(null);
 
+  /**
+   * Whether bitstream replacement is enabled in the backend
+   */
+  showReplaceButton$: Observable<boolean>;
+
   /**
    * Array containing all subscriptions created by this component
    */
@@ -200,6 +207,7 @@ export class ItemEditBitstreamBundleComponent implements OnInit, OnDestroy {
     protected paginationService: PaginationService,
     protected requestService: RequestService,
     protected itemBitstreamsService: ItemBitstreamsService,
+    protected configurationService: ConfigurationDataService,
   ) {
   }
 
@@ -209,6 +217,10 @@ export class ItemEditBitstreamBundleComponent implements OnInit, OnDestroy {
     this.itemPageRoute = getItemPageRoute(this.item);
     this.bundleName = this.dsoNameService.getName(this.bundle);
     this.bundleUrl = this.bundle.self;
+    this.showReplaceButton$ = this.configurationService.findByPropertyName('replace-bitstream.enabled').pipe(
+      getFirstSucceededRemoteDataPayload(),
+      map(payload => payload?.values.length > 0 && payload?.values[0] === 'true'),
+    );
 
     this.initializePagination();
     this.initializeBitstreams();
diff --git a/src/app/submission/sections/upload/file/section-upload-file.component.html b/src/app/submission/sections/upload/file/section-upload-file.component.html
@@ -36,9 +36,8 @@
                   (click)="$event.preventDefault();editBitstreamData();">
             <i class="fa fa-edit fa-2x text-normal"></i>
           </button>
-          @if (shouldShowReplaceButton$ | async) {
-            <button
-                    class="btn btn-link-focus"
+          @if (showReplaceButton$ | async) {
+            <button class="btn btn-link-focus"
                     [attr.aria-label]="'bitstream.edit.replace.link' | translate"
                     title="{{ 'bitstream.edit.replace.link' | translate }}"
                     (click)="$event.preventDefault();replaceBitstream();">
diff --git a/src/app/submission/sections/upload/file/section-upload-file.component.spec.ts b/src/app/submission/sections/upload/file/section-upload-file.component.spec.ts
@@ -14,10 +14,12 @@ import {
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { LinkService } from '@dspace/core/cache/builders/link.service';
+import { ConfigurationDataService } from '@dspace/core/data/configuration-data.service';
 import { JsonPatchOperationPathCombiner } from '@dspace/core/json-patch/builder/json-patch-operation-path-combiner';
 import { JsonPatchOperationsBuilder } from '@dspace/core/json-patch/builder/json-patch-operations-builder';
 import { HALEndpointService } from '@dspace/core/shared/hal-endpoint.service';
 import { SubmissionJsonPatchOperationsService } from '@dspace/core/submission/submission-json-patch-operations.service';
+import { ConfigurationDataServiceStub } from '@dspace/core/testing/configuration-data.service.stub';
 import { HALEndpointServiceStub } from '@dspace/core/testing/hal-endpoint-service.stub';
 import { getMockLinkService } from '@dspace/core/testing/link-service.mock';
 import { getMockSectionUploadService } from '@dspace/core/testing/section-upload.service.mock';
@@ -118,6 +120,7 @@ describe('SubmissionSectionUploadFileComponent', () => {
         SubmissionSectionUploadFileComponent,
         SubmissionSectionUploadFileEditComponent,
         FormBuilderService,
+        { provide: ConfigurationDataService, useValue: new ConfigurationDataServiceStub() },
       ],
     })
       .overrideComponent(SubmissionSectionUploadFileComponent, {
diff --git a/src/app/submission/sections/upload/file/section-upload-file.component.ts b/src/app/submission/sections/upload/file/section-upload-file.component.ts
@@ -10,13 +10,15 @@ import {
 } from '@angular/core';
 import { LinkService } from '@dspace/core/cache/builders/link.service';
 import { SubmissionFormsModel } from '@dspace/core/config/models/config-submission-forms.model';
+import { ConfigurationDataService } from '@dspace/core/data/configuration-data.service';
 import { JsonPatchOperationPathCombiner } from '@dspace/core/json-patch/builder/json-patch-operation-path-combiner';
 import { JsonPatchOperationsBuilder } from '@dspace/core/json-patch/builder/json-patch-operations-builder';
 import { Bitstream } from '@dspace/core/shared/bitstream.model';
 import { followLink } from '@dspace/core/shared/follow-link-config.model';
 import { Item } from '@dspace/core/shared/item.model';
 import {
   getAllSucceededRemoteData,
+  getFirstSucceededRemoteDataPayload,
   getRemoteDataPayload,
 } from '@dspace/core/shared/operators';
 import { WorkspaceitemSectionUploadFileObject } from '@dspace/core/submission/models/workspaceitem-section-upload-file.model';
@@ -33,6 +35,7 @@ import { DynamicFormControlModel } from '@ng-dynamic-forms/core';
 import { TranslateModule } from '@ngx-translate/core';
 import {
   BehaviorSubject,
+  combineLatest,
   Observable,
   Subscription,
 } from 'rxjs';
@@ -200,20 +203,19 @@ export class SubmissionSectionUploadFileComponent implements OnChanges, OnInit,
    * Whether to display the replace file button
    * @protected
    */
-  protected shouldShowReplaceButton$ = new BehaviorSubject(false);
+  protected showReplaceButton$ = new BehaviorSubject(false);
 
   /**
    * Initialize instance variables
    *
-   * @param {ChangeDetectorRef} cdr
    * @param {FormService} formService
-   * @param {HALEndpointService} halService
    * @param {NgbModal} modalService
    * @param {JsonPatchOperationsBuilder} operationsBuilder
    * @param {SubmissionJsonPatchOperationsService} operationsService
    * @param {SubmissionService} submissionService
    * @param {SectionUploadService} uploadService
    * @param {LinkService} linkService
+   * @param {ConfigurationDataService} configurationService
    */
   constructor(
     private formService: FormService,
@@ -223,6 +225,7 @@ export class SubmissionSectionUploadFileComponent implements OnChanges, OnInit,
     private submissionService: SubmissionService,
     private uploadService: SectionUploadService,
     private linkService: LinkService,
+    private configurationService: ConfigurationDataService,
   ) {
     this.readMode = true;
   }
@@ -253,16 +256,21 @@ export class SubmissionSectionUploadFileComponent implements OnChanges, OnInit,
     this.processingSaveStatus$ = this.submissionService.getSubmissionSaveProcessingStatus(this.submissionId);
     this.pathCombiner = new JsonPatchOperationPathCombiner('sections', this.sectionId);
     this.loadFormMetadata();
-    this.subscriptions.push(this.submissionService.retrieveSubmission(this.submissionId)
-      .pipe(
+    this.subscriptions.push(combineLatest([
+      this.submissionService.retrieveSubmission(this.submissionId).pipe(
         getAllSucceededRemoteData(),
         map((submissionObjectRD) => Object.assign(new Item(), submissionObjectRD.payload?.item)),
         map((item: Item) => this.linkService.resolveLink(item, followLink('version'))),
         switchMap((item: Item) => item.version),
         getAllSucceededRemoteData(),
         getRemoteDataPayload(),
-        map((version) => hasValue(version)))
-      .subscribe((isVersioned: boolean) => this.shouldShowReplaceButton$.next(isVersioned)),
+        map((version) => hasValue(version)),
+      ),
+      this.configurationService.findByPropertyName('replace-bitstream.enabled').pipe(
+        getFirstSucceededRemoteDataPayload(),
+        map(payload => payload?.values.length > 0 && payload?.values[0] === 'true'),
+      ),
+    ]).subscribe(([isVersioned, replaceEnabled]) => this.showReplaceButton$.next(isVersioned && replaceEnabled)),
     );
   }
 
