Enhance Architecture Reviewer Agent to Recognize Spring Boot Patterns

[shawnewallace]

Description

Update the existing Architecture Reviewer agent (.github/agents/architecture-reviewer.agent.md) to recognize and validate both .NET and Spring Boot architectural patterns.

Note: This enhances the current agent rather than creating a new one. The Architecture Reviewer agent concepts are already mostly stack-agnostic.

Acceptance Criteria

• Add Spring Boot pattern recognition to agent context section
• Recognize Spring Boot module structure (domain/application/infrastructure/api)
• Validate Spring Boot dependency directions (same Clean Architecture rules)
• Detect Spring Boot-specific violations:
  • Domain depending on Spring frameworks
  • Infrastructure concerns in Application layer
  • Repository pattern violations (stored procedures, etc.)
• Test agent with both .NET and Spring Boot code samples
• Update agent documentation/examples to show both stacks
• No need for separate agent - one agent handles both

Context Section Update

Add to agent's context:

## Context

This project supports two technology stacks following Clean Architecture:

**.NET 9:**
- Structure: TaskManager.Domain / .Application / .Infrastructure / .Api
- Layers enforce dependency direction: Domain ← Application ← Infrastructure ← Api

**Spring Boot 3.x:**
- Structure: taskmanager-domain / -application / -infrastructure / -api (Maven modules)
- Same dependency direction enforcement
- Recognizes Spring annotations but enforces architectural boundaries

**Common Violations to Detect (Both Stacks):**
- Domain layer depending on frameworks or external libraries
- Application layer containing infrastructure concerns
- Circular dependencies between layers
- Primitive obsession (no strongly-typed IDs)
- Direct navigation between aggregates

Testing

Validate with:

• .NET TaskManager code (existing)
• Spring Boot TaskManager code (from Add Spring Boot Code Samples to Starter Solution #31)
• Mixed violation examples (architecture boundary issues)

Related Issues

• Part of Epic Epic: Adapt Workshop for Enterprise Java/Spring Boot Client #16
• Works with Add Spring Boot Code Samples to Starter Solution #31 (Spring Boot code samples for testing)
• Complements Create Modernization Agent (Mule → Spring Boot) #20 (Modernization Agent focuses on Mule → Spring Boot migration patterns)

[shawnewallace]

Progress Update - Agent Enhancements Complete

✅ Completed:

• Updated agent persona to be stack-agnostic (.NET + Spring Boot)
• Enhanced Context section with dual-stack structure patterns
• Added Spring Boot-specific violation examples
• Committed changes (6f995a3)

Changes Summary:

• Agent now recognizes both .NET and Spring Boot architectural patterns
• Added comprehensive context for both technology stacks
• Documented common violations across both stacks
• Added stack-specific violation examples for .NET and Spring Boot

Next Steps:

• Test agent with .NET TaskManager code
• Test agent with Spring Boot TaskManager code
• Update custom-agent-catalog.md with dual-stack examples

Commit: 6f995a3 on feature/epic-16-spring-boot-adaptation branch

[shawnewallace]

✅ Issue #23 Complete - Architecture Reviewer Enhanced for Dual-Stack Support

All acceptance criteria have been met. The Architecture Reviewer agent now fully supports both .NET and Spring Boot architectures.

Changes Implemented

1. Agent Enhancement (.github/agents/architecture-reviewer.agent.md)

• ✅ Updated agent persona to be stack-agnostic (.NET + Spring Boot)
• ✅ Added comprehensive Context section with dual-stack structure patterns
• ✅ Added Spring Boot-specific violation examples
• ✅ Documented common violations across both stacks

2. Documentation Update (docs/guides/custom-agent-catalog.md)

• ✅ Updated purpose to mention both technology stacks
• ✅ Added note about stack-specific pattern recognition
• ✅ Included dual-stack example prompts

3. Testing Validation

• ✅ Tested agent with .NET TaskManager code - correctly identified .NET patterns
• ✅ Tested agent with Spring Boot TaskManager code - correctly identified Java/Spring patterns
• ✅ Agent properly recognizes architectural principles across both stacks

Test Results Summary

.NET Review:

• Correctly identified Clean Architecture compliance
• Recognized DDD patterns (aggregates, value objects)
• Detected missing repository interface
• Provided .NET-specific recommendations

Spring Boot Review:

• Correctly identified Clean Architecture compliance
• Recognized Java records as value objects
• Validated zero Spring dependencies in domain layer
• Provided Java-specific recommendations

Commits

• 6f995a3 - feat(epic-16): enhance architecture-reviewer agent for dual-stack support
• b20c2e2 - docs(epic-16): update custom-agent-catalog for dual-stack architecture-reviewer

Epic #16 Progress

10 of 15 issues complete (67%) 🎉

The Architecture Reviewer agent is now production-ready for bilingual workshop delivery.