fixed bug where local references were not being deleted

Author: chame1eon

CHANGELOG.md

@@ -1,5 +1,8 @@
 # jnitrace Change Log
 
+## 3.0.7
+- Fixed a bug where local JNI references were not being deleted. The result was reuse by the runtime of reference values led to other arguments/return values being incorrectly named
+
 ## 3.0.6
 - Bumped versions of all JavaScript dependencies to latest and fixed linter errors
 - Bug fix where all JavaVM calls were being labeled as JNIEnv calls

jnitrace/src/transport/data_transport.ts

@@ -327,9 +327,9 @@ class DataTransport {
             this.updateFieldIDs(data);
         } else if (["FindClass", "DefineClass"].includes(name)) {
             this.updateClassIDs(data);
-        } else if (name.startsWith("New") && name.endsWith("GlobalRef")) {
+        } else if (name.startsWith("New") && name.endsWith("Ref")) {
             this.updateObjectIDsFromRefs(data, true);
-        } else if (name.startsWith("Delete") && name.endsWith("GlobalRef")) {
+        } else if (name.startsWith("Delete") && name.endsWith("Ref")) {
             this.updateObjectIDsFromRefs(data, false);
         } else if (name === "GetObjectClass") {
             this.updateObjectIDsFromClass(data);

package.json

@@ -1,6 +1,6 @@
 {
   "name": "jnitrace",
-  "version": "3.0.6",
+  "version": "3.0.7",
   "description": "A tool for tracing use of the JNI in Android apps",
   "private": true,
   "main": "jnitrace/src/main.js",

setup.py

@@ -8,7 +8,7 @@
 
 setup(
     name='jnitrace',
-    version='3.0.6',
+    version='3.0.7',
     description='A tool for tracing use of the JNI in Android apps',
     long_description=long_description,
     long_description_content_type='text/markdown',