fix issues (#136)

* fix: prevent delete button click when card is not swiped open

* refactor: improve CreateRepoInput type safety

* security: require AUTH_SECRET and use secure random generation

* fix: SSH key path validation, async passphrase stripping, and port handling

* fix: use correct console methods for logger levels

* Add error handling to DB update functions and improve migration logging

* Add error handling for session lookup in auth middleware

* Add structured git error handling with user-friendly messages

- Parse git errors with specific error codes (AUTH_FAILED, REPO_NOT_FOUND,
  PUSH_REJECTED, MERGE_CONFLICT, etc.) and appropriate HTTP status codes
- Return structured error responses with summary and detail from backend
- Add GitErrorBanner component for better error display in UI
- Add optional onError callback to useGit hook for external error handling

* Make IPC server initialization/disposal async and fix SSH host key handler

* add try-catch error handling in frontend lib utilities

* remove unresolved promise handlers in speech synthesizer callbacks

* Extract error types to shared package

* Import GitErrorCode from shared package

* Refactor API layer to use shared FetchError and fetchWrapper

* Update prompt parser and source control components

* Extract MCP server list to separate component with improved badge menu UX

* merge useSettingsDialogUrl into useSettingsDialog and extract getRepoDisplayName utility

* add separate loading state for passkey sign in

* refactor hooks: use fetchWrapper, improve error handling, add proper types

* replace browser confirm() with DeleteDialog component in settings

* fix: add missing variables parameter in React Query onError callbacks

* Refactor message parts to use separate Zustand store

* Update QuestionPrompt styling for light/dark mode

Author: chriswritescode-dev

backend/src/auth/middleware.ts

@@ -18,9 +18,15 @@ export function createAuthMiddleware(auth: AuthInstance) {
       logger.debug(`Cookie names: ${cookieNames}`)
     }
 
-    const session = await auth.api.getSession({
-      headers: c.req.raw.headers,
-    })
+    let session
+    try {
+      session = await auth.api.getSession({
+        headers: c.req.raw.headers,
+      })
+    } catch (error) {
+      logger.error('Session lookup failed', { error })
+      return c.json({ error: 'Internal Server Error' }, 500)
+    }
 
     logger.debug(`Session result: ${session ? 'found' : 'not found'}`)
 
@@ -69,9 +75,15 @@ export function createAdminMiddleware(auth: AuthInstance) {
       user: Session['user']
     }
   }>(async (c, next) => {
-    const session = await auth.api.getSession({
-      headers: c.req.raw.headers,
-    })
+    let session
+    try {
+      session = await auth.api.getSession({
+        headers: c.req.raw.headers,
+      })
+    } catch (error) {
+      logger.error('Session lookup failed', { error })
+      return c.json({ error: 'Internal Server Error' }, 500)
+    }
 
     if (!session) {
       return c.json({ error: 'Unauthorized' }, 401)

backend/src/db/migrations.ts

@@ -66,7 +66,7 @@ export function runMigrations(db: Database): void {
         WHERE branch IS NOT NULL
       `)
     } catch (error) {
-      logger.debug('Index already exists or could not be created', error)
+      logger.warn('Index already exists or could not be created', error)
     }
 
     try {
@@ -75,7 +75,7 @@ export function runMigrations(db: Database): void {
         ON repos(local_path)
       `)
     } catch (error) {
-      logger.debug('Local path index already exists or could not be created', error)
+      logger.warn('Local path index already exists or could not be created', error)
     }
 
     const requiredColumns = [
@@ -111,7 +111,7 @@ export function runMigrations(db: Database): void {
       try {
         db.run(indexSql)
       } catch (error) {
-        logger.debug('Index already exists:', error)
+        logger.warn('Index already exists:', error)
       }
     }
 

backend/src/db/queries.ts

@@ -40,7 +40,7 @@ export function createRepo(db: Database, repo: CreateRepoInput): Repo {
 
   const existing = repo.isLocal 
     ? getRepoByLocalPath(db, normalizedPath)
-    : getRepoByUrlAndBranch(db, repo.repoUrl!, repo.branch)
+    : getRepoByUrlAndBranch(db, repo.repoUrl, repo.branch)
 
   if (existing) {
     return existing
@@ -73,7 +73,7 @@ export function createRepo(db: Database, repo: CreateRepoInput): Repo {
     if (errorMessage.includes('UNIQUE constraint failed') || (error && typeof error === 'object' && 'code' in error && error.code === 'SQLITE_CONSTRAINT_UNIQUE')) {
       const conflictRepo = repo.isLocal 
         ? getRepoByLocalPath(db, normalizedPath)
-        : getRepoByUrlAndBranch(db, repo.repoUrl!, repo.branch)
+        : getRepoByUrlAndBranch(db, repo.repoUrl, repo.branch)
 
       if (conflictRepo) {
         return conflictRepo
@@ -158,22 +158,34 @@ function getRepoName(repo: Repo): string {
 
 export function updateRepoStatus(db: Database, id: number, cloneStatus: Repo['cloneStatus']): void {
   const stmt = db.prepare('UPDATE repos SET clone_status = ? WHERE id = ?')
-  stmt.run(cloneStatus, id)
+  const result = stmt.run(cloneStatus, id)
+  if (result.changes === 0) {
+    throw new Error(`Repository with id ${id} not found`)
+  }
 }
 
 export function updateRepoConfigName(db: Database, id: number, configName: string): void {
   const stmt = db.prepare('UPDATE repos SET opencode_config_name = ? WHERE id = ?')
-  stmt.run(configName, id)
+  const result = stmt.run(configName, id)
+  if (result.changes === 0) {
+    throw new Error(`Repository with id ${id} not found`)
+  }
 }
 
 export function updateLastPulled(db: Database, id: number): void {
   const stmt = db.prepare('UPDATE repos SET last_pulled = ? WHERE id = ?')
-  stmt.run(Date.now(), id)
+  const result = stmt.run(Date.now(), id)
+  if (result.changes === 0) {
+    throw new Error(`Repository with id ${id} not found`)
+  }
 }
 
 export function updateRepoBranch(db: Database, id: number, branch: string): void {
   const stmt = db.prepare('UPDATE repos SET branch = ? WHERE id = ?')
-  stmt.run(branch, id)
+  const result = stmt.run(branch, id)
+  if (result.changes === 0) {
+    throw new Error(`Repository with id ${id} not found`)
+  }
 }
 
 export function deleteRepo(db: Database, id: number): void {

backend/src/db/transactions.ts

@@ -189,7 +189,7 @@ try {
   settingsService.initializeLastKnownGoodConfig()
 
   ipcServer = await createIPCServer(process.env.STORAGE_PATH || undefined)
-  gitAuthService.initialize(ipcServer, db)
+  await gitAuthService.initialize(ipcServer, db)
   logger.info(`Git IPC server running at ${ipcServer.ipcHandlePath}`)
 
   opencodeServerManager.setDatabase(db)
@@ -340,7 +340,7 @@ const shutdown = async (signal: string) => {
     sseAggregator.shutdown()
     logger.info('SSE Aggregator stopped')
     if (ipcServer) {
-      ipcServer.dispose()
+      await ipcServer.dispose()
       logger.info('Git IPC server stopped')
     }
     await opencodeServerManager.stop()

backend/src/index.ts

@@ -77,8 +77,10 @@ export class IPCServer {
     })
   }
 
-  dispose(): void {
-    this.server.close()
+  dispose(): Promise<void> {
+    return new Promise((resolve) => {
+      this.server.close(() => resolve())
+    })
   }
 }
 

backend/src/ipc/ipcServer.ts

@@ -119,8 +119,8 @@ export class SSHHostKeyHandler implements IPCHandler {
     const result = await executeCommand(
       ['ssh-keyscan', '-t', 'ed25519,rsa,ecdsa', ...portArgs, host],
       { silent: true, ignoreExitCode: true }
-    )
-    const output = (result as unknown as { stdout: string }).stdout
+    ) as string | { exitCode: number; stdout: string; stderr: string }
+    const output = typeof result === 'string' ? result : result.stdout
     const bracketedHost = port && port !== '22' ? `[${host}]:${port}` : host
     const lines = output.trim().split('\n')
     for (const line of lines) {