fix(clerk-js,shared): Mark params optional for sendPhoneCode#7898
fix(clerk-js,shared): Mark params optional for sendPhoneCode#7898
Conversation
🦋 Changeset detectedLatest commit: 413b970 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughA patch is applied to the clerk-js and shared packages. The sendPhoneCode method signature in SignUpFuture is modified to accept an optional parameter instead of requiring one. The parameter type SignUpFuturePhoneCodeSendParams is made optional in both the implementation file and its type definition. When the parameter is undefined, it defaults to an empty object with the channel defaulting to 'sms'. A new changeset file documents these changes. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Description
This PR fixes an issue where we expected at least one argument to the
sendPhoneCodeparameter. It has now been made optional.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit