Skip to content

Comments

fix(clerk-js,shared): Mark params optional for sendPhoneCode#7898

Merged
dstaley merged 1 commit intomainfrom
ds.fix/optional-sendphonecode-params
Feb 20, 2026
Merged

fix(clerk-js,shared): Mark params optional for sendPhoneCode#7898
dstaley merged 1 commit intomainfrom
ds.fix/optional-sendphonecode-params

Conversation

@dstaley
Copy link
Member

@dstaley dstaley commented Feb 20, 2026

Description

This PR fixes an issue where we expected at least one argument to the sendPhoneCode parameter. It has now been made optional.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where the phone code sending functionality incorrectly required parameters when they should have been optional. The method now properly handles optional parameters, allowing it to be called with or without arguments as needed. This simplifies API usage and improves the overall authentication experience.

@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2026

🦋 Changeset detected

Latest commit: 413b970

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@clerk/clerk-js Patch
@clerk/shared Patch
@clerk/chrome-extension Patch
@clerk/expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/react Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Feb 20, 2026 8:48pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 20, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

A patch is applied to the clerk-js and shared packages. The sendPhoneCode method signature in SignUpFuture is modified to accept an optional parameter instead of requiring one. The parameter type SignUpFuturePhoneCodeSendParams is made optional in both the implementation file and its type definition. When the parameter is undefined, it defaults to an empty object with the channel defaulting to 'sms'. A new changeset file documents these changes.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: making the params parameter optional for sendPhoneCode across both clerk-js and shared packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 20, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7898

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7898

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7898

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7898

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7898

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7898

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7898

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7898

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7898

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7898

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@7898

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7898

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7898

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7898

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7898

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7898

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7898

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7898

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7898

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7898

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7898

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7898

commit: 413b970

@dstaley dstaley merged commit c97e6af into main Feb 20, 2026
67 of 68 checks passed
@dstaley dstaley deleted the ds.fix/optional-sendphonecode-params branch February 20, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants